From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org,
Anthony Nguyen <anthony.l.nguyen@intel.com>,
Intel Wired LAN <intel-wired-lan@lists.osuosl.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [Intel-wired-lan] [intel-net] ice: remove unnecessary CONFIG_ICE_GNSS
Date: Wed, 22 Feb 2023 21:17:42 -0800 [thread overview]
Message-ID: <20230222211742.4000f650@kernel.org> (raw)
In-Reply-To: <20230222223558.2328428-1-jacob.e.keller@intel.com>
On Wed, 22 Feb 2023 14:35:58 -0800 Jacob Keller wrote:
> I'm sending to both Intel-wired-lan and netdev lists since this was
> discussed publicly on the netdev list. I'm not sure how we want to queue it
> up, so I currently have it tagged as intel-net to go through Tony's IWL
> tree. I'm happy however it gets pulled. I believe this is the best solution
> as the total number of #ifdefs is the same as with CONFIG_ICE_GNSS, as is
> the Makefile line. As far as I can tell the Kbuild just does the right thing
> here so there is no need for an additional flag.
>
> I'm happy to respin with a "depends" check if we think the flag has other
> value.
Sorry for late response. Do you mean depends as in keeping the separate
Kconfig? IS_REACHABLE() is a bit of a hack, makes figuring out what
gets built a lot harder for users. How about we keep the IS_ENABLED()
but add a dependency to ICE as a whole?
I mean instead of s/IS_ENABLED/IS_REACHABLE/ do this:
index 3facb55b7161..198995b3eab5 100644
--- a/drivers/net/ethernet/intel/Kconfig
+++ b/drivers/net/ethernet/intel/Kconfig
@@ -296,6 +296,7 @@ config ICE
default n
depends on PCI_MSI
depends on PTP_1588_CLOCK_OPTIONAL
+ depends on GNSS || GNSS=n
select AUXILIARY_BUS
select DIMLIB
select NET_DEVLINK
Or do you really care about building ICE with no GNSS.. ?
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Intel Wired LAN <intel-wired-lan@lists.osuosl.org>,
netdev@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Alexander Lobakin <alexandr.lobakin@intel.com>,
Anthony Nguyen <anthony.l.nguyen@intel.com>
Subject: Re: [intel-net] ice: remove unnecessary CONFIG_ICE_GNSS
Date: Wed, 22 Feb 2023 21:17:42 -0800 [thread overview]
Message-ID: <20230222211742.4000f650@kernel.org> (raw)
In-Reply-To: <20230222223558.2328428-1-jacob.e.keller@intel.com>
On Wed, 22 Feb 2023 14:35:58 -0800 Jacob Keller wrote:
> I'm sending to both Intel-wired-lan and netdev lists since this was
> discussed publicly on the netdev list. I'm not sure how we want to queue it
> up, so I currently have it tagged as intel-net to go through Tony's IWL
> tree. I'm happy however it gets pulled. I believe this is the best solution
> as the total number of #ifdefs is the same as with CONFIG_ICE_GNSS, as is
> the Makefile line. As far as I can tell the Kbuild just does the right thing
> here so there is no need for an additional flag.
>
> I'm happy to respin with a "depends" check if we think the flag has other
> value.
Sorry for late response. Do you mean depends as in keeping the separate
Kconfig? IS_REACHABLE() is a bit of a hack, makes figuring out what
gets built a lot harder for users. How about we keep the IS_ENABLED()
but add a dependency to ICE as a whole?
I mean instead of s/IS_ENABLED/IS_REACHABLE/ do this:
index 3facb55b7161..198995b3eab5 100644
--- a/drivers/net/ethernet/intel/Kconfig
+++ b/drivers/net/ethernet/intel/Kconfig
@@ -296,6 +296,7 @@ config ICE
default n
depends on PCI_MSI
depends on PTP_1588_CLOCK_OPTIONAL
+ depends on GNSS || GNSS=n
select AUXILIARY_BUS
select DIMLIB
select NET_DEVLINK
Or do you really care about building ICE with no GNSS.. ?
next prev parent reply other threads:[~2023-02-23 5:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 22:35 [Intel-wired-lan] [intel-net] ice: remove unnecessary CONFIG_ICE_GNSS Jacob Keller
2023-02-22 22:35 ` Jacob Keller
2023-02-23 5:17 ` Jakub Kicinski [this message]
2023-02-23 5:17 ` Jakub Kicinski
2023-02-23 22:55 ` [Intel-wired-lan] " Jacob Keller
2023-02-23 22:55 ` Jacob Keller
2023-02-24 0:13 ` [Intel-wired-lan] " Jakub Kicinski
2023-02-24 0:13 ` Jakub Kicinski
2023-02-24 0:32 ` [Intel-wired-lan] " Jacob Keller
2023-02-24 0:32 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222211742.4000f650@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.