From: David Teigland <teigland@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - vgimport: invalidate hints
Date: Wed, 22 Feb 2023 22:24:36 +0000 (GMT) [thread overview]
Message-ID: <20230222222436.2BA493858412@sourceware.org> (raw)
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=25cb6a042fab1af7ea4f4a164771a810e1acdef5
Commit: 25cb6a042fab1af7ea4f4a164771a810e1acdef5
Parent: 0f6da9926d0e7be66e759c27f42baf0c414c1ff8
Author: David Teigland <teigland@redhat.com>
AuthorDate: Wed Feb 22 16:19:48 2023 -0600
Committer: David Teigland <teigland@redhat.com>
CommitterDate: Wed Feb 22 16:19:48 2023 -0600
vgimport: invalidate hints
There may be some unconventional methods of sharing disks with vgimport
where hints could cause confusion. Hints should be disabled when
sharing disks, or pvscan --cache used to regenerate hints as needed,
but invalidating hints from vgimport might help reduce confusion.
---
tools/vgimport.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tools/vgimport.c b/tools/vgimport.c
index 84b76bd8d..d94b11314 100644
--- a/tools/vgimport.c
+++ b/tools/vgimport.c
@@ -14,6 +14,7 @@
*/
#include "tools.h"
+#include "lib/label/hints.h"
static int _vgimport_single(struct cmd_context *cmd,
const char *vg_name,
@@ -48,6 +49,13 @@ static int _vgimport_single(struct cmd_context *cmd,
log_print_unless_silent("Volume group \"%s\" successfully imported", vg->name);
+ /*
+ * This is not necessary for any normal, known cases, but it could be
+ * associated with some unconventional method of sharing disks. Hints
+ * should be disabled when sharing disks, but this might help.
+ */
+ invalidate_hints(cmd);
+
return ECMD_PROCESSED;
bad:
reply other threads:[~2023-02-22 22:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222222436.2BA493858412@sourceware.org \
--to=teigland@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.