* main - vgimport: invalidate hints
@ 2023-02-22 22:24 David Teigland
0 siblings, 0 replies; only message in thread
From: David Teigland @ 2023-02-22 22:24 UTC (permalink / raw)
To: lvm-devel
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=25cb6a042fab1af7ea4f4a164771a810e1acdef5
Commit: 25cb6a042fab1af7ea4f4a164771a810e1acdef5
Parent: 0f6da9926d0e7be66e759c27f42baf0c414c1ff8
Author: David Teigland <teigland@redhat.com>
AuthorDate: Wed Feb 22 16:19:48 2023 -0600
Committer: David Teigland <teigland@redhat.com>
CommitterDate: Wed Feb 22 16:19:48 2023 -0600
vgimport: invalidate hints
There may be some unconventional methods of sharing disks with vgimport
where hints could cause confusion. Hints should be disabled when
sharing disks, or pvscan --cache used to regenerate hints as needed,
but invalidating hints from vgimport might help reduce confusion.
---
tools/vgimport.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tools/vgimport.c b/tools/vgimport.c
index 84b76bd8d..d94b11314 100644
--- a/tools/vgimport.c
+++ b/tools/vgimport.c
@@ -14,6 +14,7 @@
*/
#include "tools.h"
+#include "lib/label/hints.h"
static int _vgimport_single(struct cmd_context *cmd,
const char *vg_name,
@@ -48,6 +49,13 @@ static int _vgimport_single(struct cmd_context *cmd,
log_print_unless_silent("Volume group \"%s\" successfully imported", vg->name);
+ /*
+ * This is not necessary for any normal, known cases, but it could be
+ * associated with some unconventional method of sharing disks. Hints
+ * should be disabled when sharing disks, but this might help.
+ */
+ invalidate_hints(cmd);
+
return ECMD_PROCESSED;
bad:
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-22 22:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-22 22:24 main - vgimport: invalidate hints David Teigland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.