From: "Michael S. Tsirkin" <mst@redhat.com>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: Alvaro Karsz <alvaro.karsz@solid-run.com>,
virtio-dev@lists.oasis-open.org,
virtio-comment@lists.oasis-open.org,
Parav Pandit <parav@nvidia.com>,
David Edmondson <david.edmondson@oracle.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [virtio-comment] Re: [virtio-dev] Re: [PATCH v9] virtio-net: support the virtqueue coalescing moderation
Date: Tue, 28 Feb 2023 02:49:41 -0500 [thread overview]
Message-ID: <20230228024829-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <46d5248b-1632-22b1-03b0-7ca64d536f04@linux.alibaba.com>
On Tue, Feb 28, 2023 at 10:41:18AM +0800, Heng Qi wrote:
> > The problem is the global qualifier. And it's not even global -
> > there are two sets for rx and for tx and does not apply to cvq at all.
> > How about "RX/TX coalescing parameters"?
>
> As Parav suggested, we probably don't need to mention "global
> values/coalescing parameters" since this values/parameters are the ones set
> by CTRL_NOTF_COAL_RX/TX_SET.
>
> Just like this:
> "
> After disabling and re-enabling a virtuqueue, the device MUST revert to
> coalescing parameters to the one configured using VIRTIO_NET_CTRL_NOTF_COAL.
> "
>
> Thanks.
VIRTIO_NET_CTRL_NOTF_COAL is not a thing. Let's wait for Alvaro's new
patch to be merged though, see what teminology he comes up with and
reuse.
--
MST
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: Alvaro Karsz <alvaro.karsz@solid-run.com>,
virtio-dev@lists.oasis-open.org,
virtio-comment@lists.oasis-open.org,
Parav Pandit <parav@nvidia.com>,
David Edmondson <david.edmondson@oracle.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [virtio-dev] Re: [PATCH v9] virtio-net: support the virtqueue coalescing moderation
Date: Tue, 28 Feb 2023 02:49:41 -0500 [thread overview]
Message-ID: <20230228024829-mutt-send-email-mst@kernel.org> (raw)
Message-ID: <20230228074941.8F7h5TdMMMiEnEbVoWb6q0vm4a2TLbf7xw7o5XG7Wio@z> (raw)
In-Reply-To: <46d5248b-1632-22b1-03b0-7ca64d536f04@linux.alibaba.com>
On Tue, Feb 28, 2023 at 10:41:18AM +0800, Heng Qi wrote:
> > The problem is the global qualifier. And it's not even global -
> > there are two sets for rx and for tx and does not apply to cvq at all.
> > How about "RX/TX coalescing parameters"?
>
> As Parav suggested, we probably don't need to mention "global
> values/coalescing parameters" since this values/parameters are the ones set
> by CTRL_NOTF_COAL_RX/TX_SET.
>
> Just like this:
> "
> After disabling and re-enabling a virtuqueue, the device MUST revert to
> coalescing parameters to the one configured using VIRTIO_NET_CTRL_NOTF_COAL.
> "
>
> Thanks.
VIRTIO_NET_CTRL_NOTF_COAL is not a thing. Let's wait for Alvaro's new
patch to be merged though, see what teminology he comes up with and
reuse.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-02-28 7:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 9:37 [virtio-comment] [PATCH v9] virtio-net: support the virtqueue coalescing moderation Heng Qi
2023-02-26 9:37 ` [virtio-dev] " Heng Qi
2023-02-26 19:33 ` [virtio-comment] " Alvaro Karsz
2023-02-26 19:33 ` [virtio-dev] " Alvaro Karsz
2023-02-27 13:02 ` Heng Qi
2023-02-27 16:25 ` [virtio-comment] " Heng Qi
2023-02-27 16:25 ` Heng Qi
2023-02-27 16:27 ` [virtio-comment] " Parav Pandit
2023-02-27 16:27 ` [virtio-dev] " Parav Pandit
2023-02-27 18:45 ` Alvaro Karsz
2023-02-27 20:19 ` Michael S. Tsirkin
2023-02-27 20:41 ` [virtio-comment] " Alvaro Karsz
2023-02-27 20:41 ` Alvaro Karsz
2023-02-28 2:41 ` [virtio-comment] " Heng Qi
2023-02-28 2:41 ` Heng Qi
2023-02-28 7:49 ` Michael S. Tsirkin [this message]
2023-02-28 7:49 ` Michael S. Tsirkin
2023-02-28 8:10 ` [virtio-comment] " Heng Qi
2023-02-28 8:10 ` [virtio-dev] " Heng Qi
2023-02-28 1:40 ` [virtio-comment] " Parav Pandit
2023-02-28 1:40 ` [virtio-dev] " Parav Pandit
2023-02-28 2:19 ` [virtio-comment] " Heng Qi
2023-02-28 2:19 ` [virtio-dev] " Heng Qi
2023-02-28 7:47 ` [virtio-comment] " Michael S. Tsirkin
2023-02-28 7:47 ` [virtio-dev] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228024829-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=david.edmondson@oracle.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.