All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, tsbogend@alpha.franken.de,
	mpe@ellerman.id.au, paul.walmsley@sifive.com, palmer@dabbelt.com,
	robh+dt@kernel.org, hch@lst.de, m.szyprowski@samsung.com,
	robin.murphy@arm.com, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 5/5] of: address: Always use dma_default_coherent for default coherency
Date: Wed, 1 Mar 2023 14:06:13 +0100	[thread overview]
Message-ID: <20230301130613.GC467@lst.de> (raw)
In-Reply-To: <20230223113644.23356-6-jiaxun.yang@flygoat.com>

> -	select OF_DMA_DEFAULT_COHERENT		if !NOT_COHERENT_CACHE

Doesn't powerpc need to select CONFIG_ARCH_DMA_DEFAULT_COHERENT now,
or even better should be doing that in the patch adding that
symbol?

In fact I wonder if adding CONFIG_ARCH_DMA_DEFAULT_COHERENT and removing
OF_DMA_DEFAULT_COHERENT should be one patch, as that seems to bring
over the intent a little better I'd say.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, tsbogend@alpha.franken.de,
	mpe@ellerman.id.au, paul.walmsley@sifive.com, palmer@dabbelt.com,
	robh+dt@kernel.org, hch@lst.de, m.szyprowski@samsung.com,
	robin.murphy@arm.com, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 5/5] of: address: Always use dma_default_coherent for default coherency
Date: Wed, 1 Mar 2023 14:06:13 +0100	[thread overview]
Message-ID: <20230301130613.GC467@lst.de> (raw)
In-Reply-To: <20230223113644.23356-6-jiaxun.yang@flygoat.com>

> -	select OF_DMA_DEFAULT_COHERENT		if !NOT_COHERENT_CACHE

Doesn't powerpc need to select CONFIG_ARCH_DMA_DEFAULT_COHERENT now,
or even better should be doing that in the patch adding that
symbol?

In fact I wonder if adding CONFIG_ARCH_DMA_DEFAULT_COHERENT and removing
OF_DMA_DEFAULT_COHERENT should be one patch, as that seems to bring
over the intent a little better I'd say.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: tsbogend@alpha.franken.de, linux-mips@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	palmer@dabbelt.com, paul.walmsley@sifive.com,
	robin.murphy@arm.com, linux-riscv@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org, hch@lst.de,
	m.szyprowski@samsung.com
Subject: Re: [PATCH v2 5/5] of: address: Always use dma_default_coherent for default coherency
Date: Wed, 1 Mar 2023 14:06:13 +0100	[thread overview]
Message-ID: <20230301130613.GC467@lst.de> (raw)
In-Reply-To: <20230223113644.23356-6-jiaxun.yang@flygoat.com>

> -	select OF_DMA_DEFAULT_COHERENT		if !NOT_COHERENT_CACHE

Doesn't powerpc need to select CONFIG_ARCH_DMA_DEFAULT_COHERENT now,
or even better should be doing that in the patch adding that
symbol?

In fact I wonder if adding CONFIG_ARCH_DMA_DEFAULT_COHERENT and removing
OF_DMA_DEFAULT_COHERENT should be one patch, as that seems to bring
over the intent a little better I'd say.

  reply	other threads:[~2023-03-01 13:06 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 11:36 [PATCH v2 0/5] Use dma_default_coherent for devicetree default coherency Jiaxun Yang
2023-02-23 11:36 ` Jiaxun Yang
2023-02-23 11:36 ` Jiaxun Yang
2023-02-23 11:36 ` [PATCH v2 1/5] of: address: Fix default coherency for MIPS Jiaxun Yang
2023-02-23 11:36   ` Jiaxun Yang
2023-02-23 11:36   ` Jiaxun Yang
2023-02-23 11:36 ` [PATCH v2 2/5] dma-mapping: Provide a fallback dma_default_coherent Jiaxun Yang
2023-02-23 11:36   ` Jiaxun Yang
2023-02-23 11:36   ` Jiaxun Yang
2023-03-01 13:03   ` Christoph Hellwig
2023-03-01 13:03     ` Christoph Hellwig
2023-03-01 13:03     ` Christoph Hellwig
2023-02-23 11:36 ` [PATCH v2 3/5] dma-mapping: Provide CONFIG_ARCH_DMA_DEFAULT_COHERENT Jiaxun Yang
2023-02-23 11:36   ` Jiaxun Yang
2023-02-23 11:36   ` Jiaxun Yang
2023-03-01 13:03   ` Christoph Hellwig
2023-03-01 13:03     ` Christoph Hellwig
2023-03-01 13:03     ` Christoph Hellwig
2023-02-23 11:36 ` [PATCH v2 4/5] riscv: Select ARCH_DMA_DEFAULT_COHERENT Jiaxun Yang
2023-02-23 11:36   ` Jiaxun Yang
2023-02-23 11:36   ` Jiaxun Yang
2023-02-23 22:20   ` Conor Dooley
2023-02-23 22:20     ` Conor Dooley
2023-02-23 22:20     ` Conor Dooley
2023-03-15  2:07     ` Palmer Dabbelt
2023-03-15  2:07       ` Palmer Dabbelt
2023-03-15  2:07       ` Palmer Dabbelt
2023-02-23 11:36 ` [PATCH v2 5/5] of: address: Always use dma_default_coherent for default coherency Jiaxun Yang
2023-02-23 11:36   ` Jiaxun Yang
2023-02-23 11:36   ` Jiaxun Yang
2023-03-01 13:06   ` Christoph Hellwig [this message]
2023-03-01 13:06     ` Christoph Hellwig
2023-03-01 13:06     ` Christoph Hellwig
2023-03-01 14:18     ` Jiaxun Yang
2023-03-01 14:18       ` Jiaxun Yang
2023-03-01 14:18       ` Jiaxun Yang
2023-03-03  0:11       ` Michael Ellerman
2023-03-03  0:11         ` Michael Ellerman
2023-03-03  0:11         ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230301130613.GC467@lst.de \
    --to=hch@lst.de \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mpe@ellerman.id.au \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.