* [PATCH] accel: Build sub-directories based on config options
@ 2023-03-01 16:25 Stanislaw Gruszka
2023-03-01 16:31 ` Jeffrey Hugo
0 siblings, 1 reply; 5+ messages in thread
From: Stanislaw Gruszka @ 2023-03-01 16:25 UTC (permalink / raw)
To: dri-devel; +Cc: Stanislaw Gruszka, Oded Gabbay, Jeffrey Hugo, Jacek Lawrynowicz
When accel drivers are disabled do not process into
sub-directories and create built-in archives:
AR drivers/accel/habanalabs/built-in.a
AR drivers/accel/ivpu/built-in.a
Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
---
drivers/accel/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/accel/Makefile b/drivers/accel/Makefile
index 07aa77aed1c8..f22fd44d586b 100644
--- a/drivers/accel/Makefile
+++ b/drivers/accel/Makefile
@@ -1,4 +1,4 @@
# SPDX-License-Identifier: GPL-2.0-only
-obj-y += habanalabs/
-obj-y += ivpu/
+obj-$(CONFIG_DRM_ACCEL_HABANALABS) += habanalabs/
+obj-$(CONFIG_DRM_ACCEL_IVPU) += ivpu/
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] accel: Build sub-directories based on config options
2023-03-01 16:25 [PATCH] accel: Build sub-directories based on config options Stanislaw Gruszka
@ 2023-03-01 16:31 ` Jeffrey Hugo
2023-03-01 16:53 ` Stanislaw Gruszka
0 siblings, 1 reply; 5+ messages in thread
From: Jeffrey Hugo @ 2023-03-01 16:31 UTC (permalink / raw)
To: Stanislaw Gruszka, dri-devel; +Cc: Oded Gabbay, Jacek Lawrynowicz
On 3/1/2023 9:25 AM, Stanislaw Gruszka wrote:
> When accel drivers are disabled do not process into
> sub-directories and create built-in archives:
>
> AR drivers/accel/habanalabs/built-in.a
> AR drivers/accel/ivpu/built-in.a
>
> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Should there be a fixes tag? Feels like something that should be
back-ported.
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] accel: Build sub-directories based on config options
2023-03-01 16:31 ` Jeffrey Hugo
@ 2023-03-01 16:53 ` Stanislaw Gruszka
2023-03-01 17:08 ` Jeffrey Hugo
2023-03-13 11:46 ` Jacek Lawrynowicz
0 siblings, 2 replies; 5+ messages in thread
From: Stanislaw Gruszka @ 2023-03-01 16:53 UTC (permalink / raw)
To: Jeffrey Hugo; +Cc: Oded Gabbay, Jacek Lawrynowicz, dri-devel
On Wed, Mar 01, 2023 at 09:31:10AM -0700, Jeffrey Hugo wrote:
> On 3/1/2023 9:25 AM, Stanislaw Gruszka wrote:
> > When accel drivers are disabled do not process into
> > sub-directories and create built-in archives:
> >
> > AR drivers/accel/habanalabs/built-in.a
> > AR drivers/accel/ivpu/built-in.a
> >
> > Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
>
> Should there be a fixes tag? Feels like something that should be
> back-ported.
This tag could be added:
Fixes: 35b137630f08 ("accel/ivpu: Introduce a new DRM driver for Intel VPU")
but since then Makefile changed with habanalabs addition.
I expect this will go to drm-misc-fixes and then to linux 6.3-rcX
from there, so (stable) back-port will not be needed.
Regards
Stanislaw
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] accel: Build sub-directories based on config options
2023-03-01 16:53 ` Stanislaw Gruszka
@ 2023-03-01 17:08 ` Jeffrey Hugo
2023-03-13 11:46 ` Jacek Lawrynowicz
1 sibling, 0 replies; 5+ messages in thread
From: Jeffrey Hugo @ 2023-03-01 17:08 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: Oded Gabbay, Jacek Lawrynowicz, dri-devel
On 3/1/2023 9:53 AM, Stanislaw Gruszka wrote:
> On Wed, Mar 01, 2023 at 09:31:10AM -0700, Jeffrey Hugo wrote:
>> On 3/1/2023 9:25 AM, Stanislaw Gruszka wrote:
>>> When accel drivers are disabled do not process into
>>> sub-directories and create built-in archives:
>>>
>>> AR drivers/accel/habanalabs/built-in.a
>>> AR drivers/accel/ivpu/built-in.a
>>>
>>> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
>>
>> Should there be a fixes tag? Feels like something that should be
>> back-ported.
>
> This tag could be added:
>
> Fixes: 35b137630f08 ("accel/ivpu: Introduce a new DRM driver for Intel VPU")
>
> but since then Makefile changed with habanalabs addition.
>
> I expect this will go to drm-misc-fixes and then to linux 6.3-rcX
> from there, so (stable) back-port will not be needed.
Makes sense. I thought this would apply to 6.2 as well, but it looks
like no.
-Jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] accel: Build sub-directories based on config options
2023-03-01 16:53 ` Stanislaw Gruszka
2023-03-01 17:08 ` Jeffrey Hugo
@ 2023-03-13 11:46 ` Jacek Lawrynowicz
1 sibling, 0 replies; 5+ messages in thread
From: Jacek Lawrynowicz @ 2023-03-13 11:46 UTC (permalink / raw)
To: Stanislaw Gruszka, Jeffrey Hugo; +Cc: Oded Gabbay, dri-devel
Thanks. Applied to drm-misc-next and cherry-picked to drm-misc-fixes.
On 01.03.2023 17:53, Stanislaw Gruszka wrote:
> On Wed, Mar 01, 2023 at 09:31:10AM -0700, Jeffrey Hugo wrote:
>> On 3/1/2023 9:25 AM, Stanislaw Gruszka wrote:
>>> When accel drivers are disabled do not process into
>>> sub-directories and create built-in archives:
>>>
>>> AR drivers/accel/habanalabs/built-in.a
>>> AR drivers/accel/ivpu/built-in.a
>>>
>>> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
>>
>> Should there be a fixes tag? Feels like something that should be
>> back-ported.
>
> This tag could be added:
>
> Fixes: 35b137630f08 ("accel/ivpu: Introduce a new DRM driver for Intel VPU")
>
> but since then Makefile changed with habanalabs addition.
>
> I expect this will go to drm-misc-fixes and then to linux 6.3-rcX
> from there, so (stable) back-port will not be needed.
>
> Regards
> Stanislaw
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-13 11:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-01 16:25 [PATCH] accel: Build sub-directories based on config options Stanislaw Gruszka
2023-03-01 16:31 ` Jeffrey Hugo
2023-03-01 16:53 ` Stanislaw Gruszka
2023-03-01 17:08 ` Jeffrey Hugo
2023-03-13 11:46 ` Jacek Lawrynowicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.