From: Florian Westphal <fw@strlen.de>
To: dccp@vger.kernel.org
Subject: Re: [PATCH] [net:netfilter]: Keep conntrack reference until IPsecv6 policy checks are done
Date: Thu, 02 Mar 2023 11:35:23 +0000 [thread overview]
Message-ID: <20230302113523.GD23204@breakpoint.cc> (raw)
Madhu Koriginja <madhu.koriginja@nxp.com> wrote:
> Keep the conntrack reference until policy checks have been performed for
> IPsec V6 NAT support. The reference needs to be dropped before a packet is
> queued to avoid having the conntrack module unloadable.
Subject Line should be:
[PATCH net] net: netfilter: Keep conntrack reference until IPsecv6 policy checks are done
or
[PATCH net-next] net: netfilter: Keep ..
see below why net-next makes more sense to me.
> Signed-off-by: Madhu Koriginja <madhu.koriginja@nxp.com>
> V1-V2: added missing () in ip6_input.c in below condition
> if (!(ipprot->flags & INET6_PROTO_NOPOLICY))
This should appear before your signed-off-by, or
> ---
> net/dccp/ipv6.c | 1 +
... here.
I think its fine to place it here because in this case
the mini-changelog doesn't provide any additional context
worth keeping in git.
Paolo, Jakub, David: This is a bug, but its not a regression
either. I would suggest that Madhu resubmits this AFTER
net-next re-opens.
Madhu, if thats the agreed-upon procedure, you may include
Reviewed-by: Florian Westphal <fw@strlen.de>
when you resend this patch as-is.
WARNING: multiple messages have this Message-ID (diff)
From: Florian Westphal <fw@strlen.de>
To: Madhu Koriginja <madhu.koriginja@nxp.com>
Cc: gerrit@erg.abdn.ac.uk, davem@davemloft.net, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, edumazet@google.com,
dccp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, vani.namala@nxp.com
Subject: Re: [PATCH] [net:netfilter]: Keep conntrack reference until IPsecv6 policy checks are done
Date: Thu, 2 Mar 2023 12:35:23 +0100 [thread overview]
Message-ID: <20230302113523.GD23204@breakpoint.cc> (raw)
In-Reply-To: <20230302112324.906365-1-madhu.koriginja@nxp.com>
Madhu Koriginja <madhu.koriginja@nxp.com> wrote:
> Keep the conntrack reference until policy checks have been performed for
> IPsec V6 NAT support. The reference needs to be dropped before a packet is
> queued to avoid having the conntrack module unloadable.
Subject Line should be:
[PATCH net] net: netfilter: Keep conntrack reference until IPsecv6 policy checks are done
or
[PATCH net-next] net: netfilter: Keep ..
see below why net-next makes more sense to me.
> Signed-off-by: Madhu Koriginja <madhu.koriginja@nxp.com>
> V1-V2: added missing () in ip6_input.c in below condition
> if (!(ipprot->flags & INET6_PROTO_NOPOLICY))
This should appear before your signed-off-by, or
> ---
> net/dccp/ipv6.c | 1 +
... here.
I think its fine to place it here because in this case
the mini-changelog doesn't provide any additional context
worth keeping in git.
Paolo, Jakub, David: This is a bug, but its not a regression
either. I would suggest that Madhu resubmits this AFTER
net-next re-opens.
Madhu, if thats the agreed-upon procedure, you may include
Reviewed-by: Florian Westphal <fw@strlen.de>
when you resend this patch as-is.
next reply other threads:[~2023-03-02 11:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 11:35 Florian Westphal [this message]
2023-03-02 11:35 ` [PATCH] [net:netfilter]: Keep conntrack reference until IPsecv6 policy checks are done Florian Westphal
2023-03-02 14:27 ` Paolo Abeni
2023-03-02 14:27 ` Paolo Abeni
-- strict thread matches above, loose matches on Subject: below --
2023-03-21 15:58 [PATCH] net : netfilter: " Madhu Koriginja
2023-03-03 9:53 [EXT] Re: [PATCH] [net:netfilter]: " Madhu Koriginja
2023-03-03 9:53 ` Madhu Koriginja
2023-03-07 6:22 ` Madhu Koriginja
2023-03-07 6:22 ` Madhu Koriginja
2023-03-02 11:23 Madhu Koriginja
2023-03-02 11:35 ` Madhu Koriginja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302113523.GD23204@breakpoint.cc \
--to=fw@strlen.de \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.