From: Halil Pasic <pasic@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Parav Pandit <parav@nvidia.com>,
virtio-dev@lists.oasis-open.org,
virtio-comment@lists.oasis-open.org, shahafs@nvidia.com,
Halil Pasic <pasic@linux.ibm.com>
Subject: [virtio-dev] Re: [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number
Date: Thu, 2 Mar 2023 16:58:54 +0100 [thread overview]
Message-ID: <20230302165854.3e7cdee7.pasic@linux.ibm.com> (raw)
In-Reply-To: <87a60vmbub.fsf@redhat.com>
On Thu, 02 Mar 2023 16:06:52 +0100
Cornelia Huck <cohuck@redhat.com> wrote:
> > And then for extra fun, in the RSS section we say "0 based index" where we
> > seem to mean "this number in the queue name, but subtract 1 in your head".
> > Why subtract 1? I guess we wanted these 5 year olds to practice math ...
>
> Heh :)
>
> Yeah, that looks like a mess... I don't think we should use a weird
> substraction scheme. I haven't looked at the RSS stuff much, would it be
> hard to fix it up?
I just did. I wrote a somewhat lengthy email on that. The TL;DR is:
we should probably rename the receive and transmit queues (receiveq1
should become receiveq0 and receiveqN should becaome receiveqN-1 for N >
0).
Regards,
Halil
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-03-02 15:59 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 5:46 [PATCH 0/3] Rename queue index to queue number Parav Pandit
2023-02-23 5:46 ` [PATCH 1/3] transport-pci: Refer to the vq by its number Parav Pandit
2023-02-24 10:05 ` [virtio-dev] " Jiri Pirko
2023-02-23 5:46 ` [PATCH 2/3] transport-mmio: Rename QueueNum register Parav Pandit
2023-02-24 10:06 ` [virtio-dev] " Jiri Pirko
2023-02-27 17:36 ` Michael S. Tsirkin
2023-02-27 17:36 ` [virtio-dev] " Michael S. Tsirkin
2023-02-23 5:46 ` [PATCH 3/3] transport-mmio: Refer to the vq by its number Parav Pandit
2023-02-24 10:06 ` [virtio-dev] " Jiri Pirko
2023-02-27 8:45 ` [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number Cornelia Huck
2023-02-27 8:45 ` [virtio-dev] " Cornelia Huck
2023-02-27 16:00 ` Parav Pandit
2023-02-27 16:00 ` [virtio-dev] " Parav Pandit
2023-02-27 17:33 ` [virtio-dev] " Michael S. Tsirkin
2023-03-01 17:22 ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
2023-03-01 17:37 ` Michael S. Tsirkin
2023-03-02 13:42 ` [virtio-dev] " Parav Pandit
2023-03-02 15:06 ` [virtio-dev] " Cornelia Huck
2023-03-02 15:58 ` Halil Pasic [this message]
2023-03-03 7:42 ` Michael S. Tsirkin
2023-03-03 21:49 ` [virtio-comment] " Halil Pasic
2023-03-03 21:49 ` Halil Pasic
2023-03-05 9:51 ` [virtio-comment] " Michael S. Tsirkin
2023-03-05 9:51 ` Michael S. Tsirkin
2023-03-09 16:46 ` [virtio-comment] " Halil Pasic
2023-03-09 16:46 ` Halil Pasic
2023-03-09 16:53 ` [virtio-comment] " Michael S. Tsirkin
2023-03-09 16:53 ` Michael S. Tsirkin
2023-03-10 14:05 ` [virtio-comment] " Halil Pasic
2023-03-10 14:05 ` Halil Pasic
2023-02-27 17:39 ` Michael S. Tsirkin
2023-02-27 17:39 ` [virtio-dev] " Michael S. Tsirkin
2023-03-02 15:52 ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
2023-03-02 16:12 ` [virtio-dev] " Parav Pandit
2023-03-02 23:38 ` [virtio-dev] " Michael S. Tsirkin
2023-03-07 15:20 ` Parav Pandit
2023-03-07 15:20 ` [virtio-dev] " Parav Pandit
2023-03-03 15:38 ` Halil Pasic
2023-03-03 15:38 ` [virtio-dev] " Halil Pasic
2023-03-05 9:29 ` Michael S. Tsirkin
2023-03-05 9:29 ` [virtio-dev] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302165854.3e7cdee7.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.