From: Jiri Pirko <jiri@nvidia.com>
To: Parav Pandit <parav@nvidia.com>
Cc: mst@redhat.com, virtio-dev@lists.oasis-open.org,
cohuck@redhat.com, virtio-comment@lists.oasis-open.org,
shahafs@nvidia.com
Subject: Re: [virtio-dev] [PATCH 2/3] transport-mmio: Rename QueueNum register
Date: Fri, 24 Feb 2023 11:06:22 +0100 [thread overview]
Message-ID: <Y/iMHsSWc7aaB/1Z@nanopsycho> (raw)
In-Reply-To: <20230223054624.168042-3-parav@nvidia.com>
Thu, Feb 23, 2023 at 06:46:23AM CET, parav@nvidia.com wrote:
>Currently, the specification uses virtqueue index and number
>interchangeably to refer to the virtqueue.
>
>It is better to identify it using one terminology.
>
>Two registers QueueNumMax and QueueNum actually reflect the queue size
>or queue depth indicating max and actual number of entries in the queue.
>Equivalent register in PCI transport is named differently as queue_size.
>
>To bring consistency between pci and mmio transport, and to avoid
>confusion between number and index, rename the QueueNumMax and QueueNum
>registers to QueueSizeMax and QueueSize respectively.
>
>[1] https://lists.oasis-open.org/archives/virtio-dev/202302/msg00527.html
>
>Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
>Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2023-02-24 10:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 5:46 [PATCH 0/3] Rename queue index to queue number Parav Pandit
2023-02-23 5:46 ` [PATCH 1/3] transport-pci: Refer to the vq by its number Parav Pandit
2023-02-24 10:05 ` [virtio-dev] " Jiri Pirko
2023-02-23 5:46 ` [PATCH 2/3] transport-mmio: Rename QueueNum register Parav Pandit
2023-02-24 10:06 ` Jiri Pirko [this message]
2023-02-27 17:36 ` Michael S. Tsirkin
2023-02-27 17:36 ` [virtio-dev] " Michael S. Tsirkin
2023-02-23 5:46 ` [PATCH 3/3] transport-mmio: Refer to the vq by its number Parav Pandit
2023-02-24 10:06 ` [virtio-dev] " Jiri Pirko
2023-02-27 8:45 ` [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number Cornelia Huck
2023-02-27 8:45 ` [virtio-dev] " Cornelia Huck
2023-02-27 16:00 ` Parav Pandit
2023-02-27 16:00 ` [virtio-dev] " Parav Pandit
2023-02-27 17:33 ` [virtio-dev] " Michael S. Tsirkin
2023-03-01 17:22 ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
2023-03-01 17:37 ` Michael S. Tsirkin
2023-03-02 13:42 ` [virtio-dev] " Parav Pandit
2023-03-02 15:06 ` [virtio-dev] " Cornelia Huck
2023-03-02 15:58 ` Halil Pasic
2023-03-03 7:42 ` Michael S. Tsirkin
2023-03-03 21:49 ` [virtio-comment] " Halil Pasic
2023-03-03 21:49 ` Halil Pasic
2023-03-05 9:51 ` [virtio-comment] " Michael S. Tsirkin
2023-03-05 9:51 ` Michael S. Tsirkin
2023-03-09 16:46 ` [virtio-comment] " Halil Pasic
2023-03-09 16:46 ` Halil Pasic
2023-03-09 16:53 ` [virtio-comment] " Michael S. Tsirkin
2023-03-09 16:53 ` Michael S. Tsirkin
2023-03-10 14:05 ` [virtio-comment] " Halil Pasic
2023-03-10 14:05 ` Halil Pasic
2023-02-27 17:39 ` Michael S. Tsirkin
2023-02-27 17:39 ` [virtio-dev] " Michael S. Tsirkin
2023-03-02 15:52 ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
2023-03-02 16:12 ` [virtio-dev] " Parav Pandit
2023-03-02 23:38 ` [virtio-dev] " Michael S. Tsirkin
2023-03-07 15:20 ` Parav Pandit
2023-03-07 15:20 ` [virtio-dev] " Parav Pandit
2023-03-03 15:38 ` Halil Pasic
2023-03-03 15:38 ` [virtio-dev] " Halil Pasic
2023-03-05 9:29 ` Michael S. Tsirkin
2023-03-05 9:29 ` [virtio-dev] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/iMHsSWc7aaB/1Z@nanopsycho \
--to=jiri@nvidia.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.