From: Yue Hu <zbestahu@gmail.com>
To: Yangtao Li <frank.li@vivo.com>
Cc: linux-kernel@vger.kernel.org, zhangwen@coolpad.com,
huyue2@coolpad.com, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v2] erofs: mark z_erofs_lzma_init/erofs_pcpubuf_init w/ __init
Date: Fri, 3 Mar 2023 15:29:37 +0800 [thread overview]
Message-ID: <20230303152937.0000571a.zbestahu@gmail.com> (raw)
In-Reply-To: <20230303063731.66760-1-frank.li@vivo.com>
On Fri, 3 Mar 2023 14:37:31 +0800
Yangtao Li <frank.li@vivo.com> wrote:
> They are used during the erofs module init phase. Let's mark it as
> __init like any other function.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Yue Hu <huyue2@coolpad.com>
> ---
> v2:
> -change in internal.h
> fs/erofs/decompressor_lzma.c | 2 +-
> fs/erofs/internal.h | 4 ++--
> fs/erofs/pcpubuf.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/erofs/decompressor_lzma.c b/fs/erofs/decompressor_lzma.c
> index 091fd5adf818..307b37f0b9f5 100644
> --- a/fs/erofs/decompressor_lzma.c
> +++ b/fs/erofs/decompressor_lzma.c
> @@ -47,7 +47,7 @@ void z_erofs_lzma_exit(void)
> }
> }
>
> -int z_erofs_lzma_init(void)
> +int __init z_erofs_lzma_init(void)
> {
> unsigned int i;
>
> diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
> index 3f3561d37d1b..1db018f8c2e8 100644
> --- a/fs/erofs/internal.h
> +++ b/fs/erofs/internal.h
> @@ -486,7 +486,7 @@ static inline void *erofs_vm_map_ram(struct page **pages, unsigned int count)
> void *erofs_get_pcpubuf(unsigned int requiredpages);
> void erofs_put_pcpubuf(void *ptr);
> int erofs_pcpubuf_growsize(unsigned int nrpages);
> -void erofs_pcpubuf_init(void);
> +void __init erofs_pcpubuf_init(void);
> void erofs_pcpubuf_exit(void);
>
> int erofs_register_sysfs(struct super_block *sb);
> @@ -545,7 +545,7 @@ static inline int z_erofs_fill_inode(struct inode *inode) { return -EOPNOTSUPP;
> #endif /* !CONFIG_EROFS_FS_ZIP */
>
> #ifdef CONFIG_EROFS_FS_ZIP_LZMA
> -int z_erofs_lzma_init(void);
> +int __init z_erofs_lzma_init(void);
> void z_erofs_lzma_exit(void);
> int z_erofs_load_lzma_config(struct super_block *sb,
> struct erofs_super_block *dsb,
> diff --git a/fs/erofs/pcpubuf.c b/fs/erofs/pcpubuf.c
> index a2efd833d1b6..c7a4b1d77069 100644
> --- a/fs/erofs/pcpubuf.c
> +++ b/fs/erofs/pcpubuf.c
> @@ -114,7 +114,7 @@ int erofs_pcpubuf_growsize(unsigned int nrpages)
> return ret;
> }
>
> -void erofs_pcpubuf_init(void)
> +void __init erofs_pcpubuf_init(void)
> {
> int cpu;
>
WARNING: multiple messages have this Message-ID (diff)
From: Yue Hu <zbestahu@gmail.com>
To: Yangtao Li <frank.li@vivo.com>
Cc: xiang@kernel.org, chao@kernel.org, jefflexu@linux.alibaba.com,
linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
zhangwen@coolpad.com, huyue2@coolpad.com
Subject: Re: [PATCH v2] erofs: mark z_erofs_lzma_init/erofs_pcpubuf_init w/ __init
Date: Fri, 3 Mar 2023 15:29:37 +0800 [thread overview]
Message-ID: <20230303152937.0000571a.zbestahu@gmail.com> (raw)
In-Reply-To: <20230303063731.66760-1-frank.li@vivo.com>
On Fri, 3 Mar 2023 14:37:31 +0800
Yangtao Li <frank.li@vivo.com> wrote:
> They are used during the erofs module init phase. Let's mark it as
> __init like any other function.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Yue Hu <huyue2@coolpad.com>
> ---
> v2:
> -change in internal.h
> fs/erofs/decompressor_lzma.c | 2 +-
> fs/erofs/internal.h | 4 ++--
> fs/erofs/pcpubuf.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/erofs/decompressor_lzma.c b/fs/erofs/decompressor_lzma.c
> index 091fd5adf818..307b37f0b9f5 100644
> --- a/fs/erofs/decompressor_lzma.c
> +++ b/fs/erofs/decompressor_lzma.c
> @@ -47,7 +47,7 @@ void z_erofs_lzma_exit(void)
> }
> }
>
> -int z_erofs_lzma_init(void)
> +int __init z_erofs_lzma_init(void)
> {
> unsigned int i;
>
> diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
> index 3f3561d37d1b..1db018f8c2e8 100644
> --- a/fs/erofs/internal.h
> +++ b/fs/erofs/internal.h
> @@ -486,7 +486,7 @@ static inline void *erofs_vm_map_ram(struct page **pages, unsigned int count)
> void *erofs_get_pcpubuf(unsigned int requiredpages);
> void erofs_put_pcpubuf(void *ptr);
> int erofs_pcpubuf_growsize(unsigned int nrpages);
> -void erofs_pcpubuf_init(void);
> +void __init erofs_pcpubuf_init(void);
> void erofs_pcpubuf_exit(void);
>
> int erofs_register_sysfs(struct super_block *sb);
> @@ -545,7 +545,7 @@ static inline int z_erofs_fill_inode(struct inode *inode) { return -EOPNOTSUPP;
> #endif /* !CONFIG_EROFS_FS_ZIP */
>
> #ifdef CONFIG_EROFS_FS_ZIP_LZMA
> -int z_erofs_lzma_init(void);
> +int __init z_erofs_lzma_init(void);
> void z_erofs_lzma_exit(void);
> int z_erofs_load_lzma_config(struct super_block *sb,
> struct erofs_super_block *dsb,
> diff --git a/fs/erofs/pcpubuf.c b/fs/erofs/pcpubuf.c
> index a2efd833d1b6..c7a4b1d77069 100644
> --- a/fs/erofs/pcpubuf.c
> +++ b/fs/erofs/pcpubuf.c
> @@ -114,7 +114,7 @@ int erofs_pcpubuf_growsize(unsigned int nrpages)
> return ret;
> }
>
> -void erofs_pcpubuf_init(void)
> +void __init erofs_pcpubuf_init(void)
> {
> int cpu;
>
next prev parent reply other threads:[~2023-03-03 7:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 6:37 [PATCH v2] erofs: mark z_erofs_lzma_init/erofs_pcpubuf_init w/ __init Yangtao Li
2023-03-03 7:29 ` Yue Hu [this message]
2023-03-03 7:29 ` Yue Hu
2023-03-03 7:59 ` Gao Xiang
2023-03-09 14:32 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303152937.0000571a.zbestahu@gmail.com \
--to=zbestahu@gmail.com \
--cc=frank.li@vivo.com \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangwen@coolpad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.