From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Yosry Ahmed <yosryahmed@google.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Minchan Kim <minchan@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCHv3 2/4] zsmalloc: fine-grained inuse ratio based fullness grouping
Date: Sat, 4 Mar 2023 11:01:52 +0900 [thread overview]
Message-ID: <20230304020152.GB5231@google.com> (raw)
In-Reply-To: <20230303152833.24d7a42102bd712e09f95cd5@linux-foundation.org>
On (23/03/03 15:28), Andrew Morton wrote:
> Date: Fri, 3 Mar 2023 15:28:33 -0800
> From: Andrew Morton <akpm@linux-foundation.org>
> To: Yosry Ahmed <yosryahmed@google.com>
> Cc: Sergey Senozhatsky <senozhatsky@chromium.org>, Minchan Kim
> <minchan@kernel.org>, linux-kernel@vger.kernel.org, linux-mm@kvack.org
> Subject: Re: [PATCHv3 2/4] zsmalloc: fine-grained inuse ratio based
> fullness grouping
> Message-Id: <20230303152833.24d7a42102bd712e09f95cd5@linux-foundation.org>
> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
>
> On Fri, 3 Mar 2023 08:58:55 -0800 Yosry Ahmed <yosryahmed@google.com> wrote:
>
> > > > + for (fg = ZS_INUSE_RATIO_70; fg <= ZS_INUSE_RATIO_99; fg++)
> > > > + class_almost_full = zs_stat_get(class, fg);
> > > > + for (fg = ZS_INUSE_RATIO_10; fg < ZS_INUSE_RATIO_70; fg++)
> > > > + class_almost_empty = zs_stat_get(class, fg);
> > >
> > > Aren't these supposed to be += ?
Good catch Yosry! Thanks for taking a look.
> I'll fix that up anyway, to avoid a bisection hole. And in case [patch 4/4]
> gets dropped from the series or is later reverted or whatever.
Thanks Andrew, should I just send out a v4 with 3/4 and 4/4 fixed up?
next prev parent reply other threads:[~2023-03-04 2:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 7:31 [PATCHv3 0/4] zsmalloc: fine-grained fullness and new compaction algorithm Sergey Senozhatsky
2023-03-03 7:31 ` [PATCHv3 1/4] zsmalloc: remove insert_zspage() ->inuse optimization Sergey Senozhatsky
2023-03-03 7:31 ` [PATCHv3 2/4] zsmalloc: fine-grained inuse ratio based fullness grouping Sergey Senozhatsky
2023-03-03 16:55 ` Yosry Ahmed
2023-03-03 16:58 ` Yosry Ahmed
2023-03-03 23:28 ` Andrew Morton
2023-03-04 2:01 ` Sergey Senozhatsky [this message]
2023-03-03 7:31 ` [PATCHv3 3/4] zsmalloc: rework compaction algorithm Sergey Senozhatsky
2023-03-03 7:31 ` [PATCHv3 4/4] zsmalloc: show per fullness group class stats Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230304020152.GB5231@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.