From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mm-commits@vger.kernel.org, yosryahmed@google.com,
senozhatsky@chromium.org, minchan@kernel.org
Subject: Re: + zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix.patch added to mm-unstable branch
Date: Sat, 4 Mar 2023 11:35:36 +0900 [thread overview]
Message-ID: <20230304023536.GD5231@google.com> (raw)
In-Reply-To: <20230303232902.1CD39C433A0@smtp.kernel.org>
On (23/03/03 15:29), Andrew Morton wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix
> Date: Fri Mar 3 03:25:23 PM PST 2023
>
> fix zs_stats_size_show() accumulation, per Yosry
[..]
> --- a/mm/zsmalloc.c~zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix
> +++ a/mm/zsmalloc.c
> @@ -651,9 +651,9 @@ static int zs_stats_size_show(struct seq
> * stats.
> */
> for (fg = ZS_INUSE_RATIO_70; fg <= ZS_INUSE_RATIO_99; fg++)
> - class_almost_full = zs_stat_get(class, fg);
> + class_almost_full += zs_stat_get(class, fg);
> for (fg = ZS_INUSE_RATIO_10; fg < ZS_INUSE_RATIO_70; fg++)
> - class_almost_empty = zs_stat_get(class, fg);
> + class_almost_empty += zs_stat_get(class, fg);
>
> obj_allocated = zs_stat_get(class, ZS_OBJS_ALLOCATED);
> obj_used = zs_stat_get(class, ZS_OBJS_INUSE);
This also needs to set class_almost_full and class_almost_empty to 0
for each class.
Andrew, I'll send v4 in a bit.
prev parent reply other threads:[~2023-03-04 2:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 23:29 + zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix.patch added to mm-unstable branch Andrew Morton
2023-03-04 2:35 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230304023536.GD5231@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.