+ zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix.patch added to mm-unstable branch

+ zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix.patch added to mm-unstable branch

[Andrew Morton]

The patch titled
     Subject: zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix
has been added to the -mm mm-unstable branch.  Its filename is
     zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix.patch

This patch will later appear in the mm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix
Date: Fri Mar  3 03:25:23 PM PST 2023

fix zs_stats_size_show() accumulation, per Yosry

Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---


--- a/mm/zsmalloc.c~zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix
+++ a/mm/zsmalloc.c
@@ -651,9 +651,9 @@ static int zs_stats_size_show(struct seq
 		 * stats.
 		 */
 		for (fg = ZS_INUSE_RATIO_70; fg <= ZS_INUSE_RATIO_99; fg++)
-			class_almost_full = zs_stat_get(class, fg);
+			class_almost_full += zs_stat_get(class, fg);
 		for (fg = ZS_INUSE_RATIO_10; fg < ZS_INUSE_RATIO_70; fg++)
-			class_almost_empty = zs_stat_get(class, fg);
+			class_almost_empty += zs_stat_get(class, fg);
 
 		obj_allocated = zs_stat_get(class, ZS_OBJS_ALLOCATED);
 		obj_used = zs_stat_get(class, ZS_OBJS_INUSE);
_

Patches currently in -mm which might be from akpm@linux-foundation.org are

mm-page_alloc-reduce-page-alloc-free-sanity-checks-checkpatch-fixes.patch
mm-page_alloc-reduce-page-alloc-free-sanity-checks-fix.patch
mm-userfaultfd-support-wp-on-multiple-vmas-fix.patch
zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix.patch
zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix.patch

Re: + zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix.patch added to mm-unstable branch

[Sergey Senozhatsky]

On (23/03/03 15:29), Andrew Morton wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix
> Date: Fri Mar  3 03:25:23 PM PST 2023
> 
> fix zs_stats_size_show() accumulation, per Yosry

[..]

> --- a/mm/zsmalloc.c~zsmalloc-fine-grained-inuse-ratio-based-fullness-grouping-fix-fix
> +++ a/mm/zsmalloc.c
> @@ -651,9 +651,9 @@ static int zs_stats_size_show(struct seq
>  		 * stats.
>  		 */
>  		for (fg = ZS_INUSE_RATIO_70; fg <= ZS_INUSE_RATIO_99; fg++)
> -			class_almost_full = zs_stat_get(class, fg);
> +			class_almost_full += zs_stat_get(class, fg);
>  		for (fg = ZS_INUSE_RATIO_10; fg < ZS_INUSE_RATIO_70; fg++)
> -			class_almost_empty = zs_stat_get(class, fg);
> +			class_almost_empty += zs_stat_get(class, fg);
>  
>  		obj_allocated = zs_stat_get(class, ZS_OBJS_ALLOCATED);
>  		obj_used = zs_stat_get(class, ZS_OBJS_INUSE);

This also needs to set class_almost_full and class_almost_empty to 0
for each class.

Andrew, I'll send v4 in a bit.