From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: netdev@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
virtualization@lists.linux-foundation.org, bpf@vger.kernel.org
Subject: Re: [PATCH net 0/2] add checking sq is full inside xdp xmit
Date: Mon, 6 Mar 2023 12:58:22 -0500 [thread overview]
Message-ID: <20230306125742-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230306041535.73319-1-xuanzhuo@linux.alibaba.com>
On Mon, Mar 06, 2023 at 12:15:33PM +0800, Xuan Zhuo wrote:
> If the queue of xdp xmit is not an independent queue, then when the xdp
> xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter
> the following error.
>
> net ens4: Unexpected TXQ (0) queue failure: -28
>
> This patch adds a check whether sq is full in XDP Xmit.
>
> Thanks.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
needed for stable?
> Xuan Zhuo (2):
> virtio_net: separate the logic of checking whether sq is full
> virtio_net: add checking sq is full inside xdp xmit
>
> drivers/net/virtio_net.c | 78 ++++++++++++++++++++++++----------------
> 1 file changed, 47 insertions(+), 31 deletions(-)
>
> --
> 2.32.0.3.g01195cf9f
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: Jesper Dangaard Brouer <hawk@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, John Fastabend <john.fastabend@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
virtualization@lists.linux-foundation.org,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
bpf@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net 0/2] add checking sq is full inside xdp xmit
Date: Mon, 6 Mar 2023 12:58:22 -0500 [thread overview]
Message-ID: <20230306125742-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230306041535.73319-1-xuanzhuo@linux.alibaba.com>
On Mon, Mar 06, 2023 at 12:15:33PM +0800, Xuan Zhuo wrote:
> If the queue of xdp xmit is not an independent queue, then when the xdp
> xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter
> the following error.
>
> net ens4: Unexpected TXQ (0) queue failure: -28
>
> This patch adds a check whether sq is full in XDP Xmit.
>
> Thanks.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
needed for stable?
> Xuan Zhuo (2):
> virtio_net: separate the logic of checking whether sq is full
> virtio_net: add checking sq is full inside xdp xmit
>
> drivers/net/virtio_net.c | 78 ++++++++++++++++++++++++----------------
> 1 file changed, 47 insertions(+), 31 deletions(-)
>
> --
> 2.32.0.3.g01195cf9f
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-03-06 18:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 4:15 [PATCH net 0/2] add checking sq is full inside xdp xmit Xuan Zhuo
2023-03-06 4:15 ` Xuan Zhuo
2023-03-06 4:15 ` [PATCH net 1/2] virtio_net: separate the logic of checking whether sq is full Xuan Zhuo
2023-03-06 4:15 ` Xuan Zhuo
2023-03-07 8:34 ` Jason Wang
2023-03-07 8:34 ` Jason Wang
2023-03-06 4:15 ` [PATCH net 2/2] virtio_net: add checking sq is full inside xdp xmit Xuan Zhuo
2023-03-06 4:15 ` Xuan Zhuo
2023-03-06 17:57 ` Michael S. Tsirkin
2023-03-06 17:57 ` Michael S. Tsirkin
2023-03-07 1:47 ` Xuan Zhuo
2023-03-07 1:47 ` Xuan Zhuo
2023-03-06 16:49 ` [PATCH net 0/2] " Alexander H Duyck
2023-03-06 16:49 ` Alexander H Duyck
2023-03-06 17:58 ` Michael S. Tsirkin [this message]
2023-03-06 17:58 ` Michael S. Tsirkin
2023-03-07 1:49 ` Xuan Zhuo
2023-03-07 1:49 ` Xuan Zhuo
2023-03-07 9:53 ` Paolo Abeni
2023-03-07 9:53 ` Paolo Abeni
2023-03-07 11:08 ` Xuan Zhuo
2023-03-07 11:08 ` Xuan Zhuo
2023-03-07 15:59 ` Michael S. Tsirkin
2023-03-07 15:59 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306125742-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.