From: Andrew Davis <afd@ti.com>
To: "Russell King" <linux@armlinux.org.uk>,
"Baruch Siach" <baruch@tkos.co.il>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Nick Hawkins" <nick.hawkins@hpe.com>,
"Oleksij Rempel" <linux@rempel-privat.de>,
"Andreas Färber" <afaerber@suse.de>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Allison Randal" <allison@lohutok.net>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Qin Jian" <qinjian@cqplus1.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, Andrew Davis <afd@ti.com>
Subject: [PATCH 07/10] ARM: mach-digicolor: Rework support and directory structure
Date: Mon, 6 Mar 2023 10:34:38 -0600 [thread overview]
Message-ID: <20230306163441.16179-7-afd@ti.com> (raw)
In-Reply-To: <20230306163441.16179-1-afd@ti.com>
Having a platform need a mach-* directory should be seen as a negative,
it means the platform needs special non-standard handling. ARM64 support
does not allow mach-* directories at all. While we may not get to that
given all the non-standard architectures we support, we should still try
to get as close as we can and reduce the number of mach directories.
The mach-digicolor/ directory and files, provides just one "feature":
having the kernel print the machine name if the DTB does not also contain
a "model" string (which they always do). To reduce the number of mach-*
directories let's do without that feature and remove this directory.
Signed-off-by: Andrew Davis <afd@ti.com>
---
arch/arm/Kconfig | 2 --
arch/arm/Kconfig.platforms | 11 +++++++++++
arch/arm/Makefile | 1 -
arch/arm/mach-digicolor/Kconfig | 11 -----------
arch/arm/mach-digicolor/Makefile | 2 --
arch/arm/mach-digicolor/digicolor.c | 15 ---------------
6 files changed, 11 insertions(+), 31 deletions(-)
delete mode 100644 arch/arm/mach-digicolor/Kconfig
delete mode 100644 arch/arm/mach-digicolor/Makefile
delete mode 100644 arch/arm/mach-digicolor/digicolor.c
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e8ac56398f76..90086040de90 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -363,8 +363,6 @@ source "arch/arm/mach-clps711x/Kconfig"
source "arch/arm/mach-davinci/Kconfig"
-source "arch/arm/mach-digicolor/Kconfig"
-
source "arch/arm/mach-dove/Kconfig"
source "arch/arm/mach-ep93xx/Kconfig"
diff --git a/arch/arm/Kconfig.platforms b/arch/arm/Kconfig.platforms
index 38457d5a18ff..c74392419cc3 100644
--- a/arch/arm/Kconfig.platforms
+++ b/arch/arm/Kconfig.platforms
@@ -87,6 +87,17 @@ config MACH_ASM9260
help
Support for Alphascale ASM9260 based platform.
+config ARCH_DIGICOLOR
+ bool "Conexant Digicolor SoC Support"
+ depends on ARCH_MULTI_V7
+ select CLKSRC_MMIO
+ select DIGICOLOR_TIMER
+ select GENERIC_IRQ_CHIP
+ select GPIOLIB
+ select MFD_SYSCON
+ select PINCTRL
+ select PINCTRL_DIGICOLOR
+
menuconfig ARCH_MOXART
bool "MOXA ART SoC"
depends on ARCH_MULTI_V4
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index d146db4ce15d..c2f5925b15fa 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -176,7 +176,6 @@ machine-$(CONFIG_ARCH_BCM) += bcm
machine-$(CONFIG_ARCH_BERLIN) += berlin
machine-$(CONFIG_ARCH_CLPS711X) += clps711x
machine-$(CONFIG_ARCH_DAVINCI) += davinci
-machine-$(CONFIG_ARCH_DIGICOLOR) += digicolor
machine-$(CONFIG_ARCH_DOVE) += dove
machine-$(CONFIG_ARCH_EP93XX) += ep93xx
machine-$(CONFIG_ARCH_EXYNOS) += exynos
diff --git a/arch/arm/mach-digicolor/Kconfig b/arch/arm/mach-digicolor/Kconfig
deleted file mode 100644
index 90394433c405..000000000000
--- a/arch/arm/mach-digicolor/Kconfig
+++ /dev/null
@@ -1,11 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-config ARCH_DIGICOLOR
- bool "Conexant Digicolor SoC Support"
- depends on ARCH_MULTI_V7
- select CLKSRC_MMIO
- select DIGICOLOR_TIMER
- select GENERIC_IRQ_CHIP
- select GPIOLIB
- select MFD_SYSCON
- select PINCTRL
- select PINCTRL_DIGICOLOR
diff --git a/arch/arm/mach-digicolor/Makefile b/arch/arm/mach-digicolor/Makefile
deleted file mode 100644
index fc5b7c98c824..000000000000
--- a/arch/arm/mach-digicolor/Makefile
+++ /dev/null
@@ -1,2 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-only
-obj-$(CONFIG_ARCH_DIGICOLOR) += digicolor.o
diff --git a/arch/arm/mach-digicolor/digicolor.c b/arch/arm/mach-digicolor/digicolor.c
deleted file mode 100644
index 156d0d5996a9..000000000000
--- a/arch/arm/mach-digicolor/digicolor.c
+++ /dev/null
@@ -1,15 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-/*
- * Support for Conexant Digicolor SoCs
-*/
-
-#include <asm/mach/arch.h>
-
-static const char *const digicolor_dt_compat[] __initconst = {
- "cnxt,cx92755",
- NULL,
-};
-
-DT_MACHINE_START(DIGICOLOR, "Conexant Digicolor (Flattened Device Tree)")
- .dt_compat = digicolor_dt_compat,
-MACHINE_END
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Davis <afd@ti.com>
To: "Russell King" <linux@armlinux.org.uk>,
"Baruch Siach" <baruch@tkos.co.il>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Nick Hawkins" <nick.hawkins@hpe.com>,
"Oleksij Rempel" <linux@rempel-privat.de>,
"Andreas Färber" <afaerber@suse.de>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Allison Randal" <allison@lohutok.net>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Qin Jian" <qinjian@cqplus1.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, Andrew Davis <afd@ti.com>
Subject: [PATCH 07/10] ARM: mach-digicolor: Rework support and directory structure
Date: Mon, 6 Mar 2023 10:34:38 -0600 [thread overview]
Message-ID: <20230306163441.16179-7-afd@ti.com> (raw)
In-Reply-To: <20230306163441.16179-1-afd@ti.com>
Having a platform need a mach-* directory should be seen as a negative,
it means the platform needs special non-standard handling. ARM64 support
does not allow mach-* directories at all. While we may not get to that
given all the non-standard architectures we support, we should still try
to get as close as we can and reduce the number of mach directories.
The mach-digicolor/ directory and files, provides just one "feature":
having the kernel print the machine name if the DTB does not also contain
a "model" string (which they always do). To reduce the number of mach-*
directories let's do without that feature and remove this directory.
Signed-off-by: Andrew Davis <afd@ti.com>
---
arch/arm/Kconfig | 2 --
arch/arm/Kconfig.platforms | 11 +++++++++++
arch/arm/Makefile | 1 -
arch/arm/mach-digicolor/Kconfig | 11 -----------
arch/arm/mach-digicolor/Makefile | 2 --
arch/arm/mach-digicolor/digicolor.c | 15 ---------------
6 files changed, 11 insertions(+), 31 deletions(-)
delete mode 100644 arch/arm/mach-digicolor/Kconfig
delete mode 100644 arch/arm/mach-digicolor/Makefile
delete mode 100644 arch/arm/mach-digicolor/digicolor.c
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e8ac56398f76..90086040de90 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -363,8 +363,6 @@ source "arch/arm/mach-clps711x/Kconfig"
source "arch/arm/mach-davinci/Kconfig"
-source "arch/arm/mach-digicolor/Kconfig"
-
source "arch/arm/mach-dove/Kconfig"
source "arch/arm/mach-ep93xx/Kconfig"
diff --git a/arch/arm/Kconfig.platforms b/arch/arm/Kconfig.platforms
index 38457d5a18ff..c74392419cc3 100644
--- a/arch/arm/Kconfig.platforms
+++ b/arch/arm/Kconfig.platforms
@@ -87,6 +87,17 @@ config MACH_ASM9260
help
Support for Alphascale ASM9260 based platform.
+config ARCH_DIGICOLOR
+ bool "Conexant Digicolor SoC Support"
+ depends on ARCH_MULTI_V7
+ select CLKSRC_MMIO
+ select DIGICOLOR_TIMER
+ select GENERIC_IRQ_CHIP
+ select GPIOLIB
+ select MFD_SYSCON
+ select PINCTRL
+ select PINCTRL_DIGICOLOR
+
menuconfig ARCH_MOXART
bool "MOXA ART SoC"
depends on ARCH_MULTI_V4
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index d146db4ce15d..c2f5925b15fa 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -176,7 +176,6 @@ machine-$(CONFIG_ARCH_BCM) += bcm
machine-$(CONFIG_ARCH_BERLIN) += berlin
machine-$(CONFIG_ARCH_CLPS711X) += clps711x
machine-$(CONFIG_ARCH_DAVINCI) += davinci
-machine-$(CONFIG_ARCH_DIGICOLOR) += digicolor
machine-$(CONFIG_ARCH_DOVE) += dove
machine-$(CONFIG_ARCH_EP93XX) += ep93xx
machine-$(CONFIG_ARCH_EXYNOS) += exynos
diff --git a/arch/arm/mach-digicolor/Kconfig b/arch/arm/mach-digicolor/Kconfig
deleted file mode 100644
index 90394433c405..000000000000
--- a/arch/arm/mach-digicolor/Kconfig
+++ /dev/null
@@ -1,11 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-config ARCH_DIGICOLOR
- bool "Conexant Digicolor SoC Support"
- depends on ARCH_MULTI_V7
- select CLKSRC_MMIO
- select DIGICOLOR_TIMER
- select GENERIC_IRQ_CHIP
- select GPIOLIB
- select MFD_SYSCON
- select PINCTRL
- select PINCTRL_DIGICOLOR
diff --git a/arch/arm/mach-digicolor/Makefile b/arch/arm/mach-digicolor/Makefile
deleted file mode 100644
index fc5b7c98c824..000000000000
--- a/arch/arm/mach-digicolor/Makefile
+++ /dev/null
@@ -1,2 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-only
-obj-$(CONFIG_ARCH_DIGICOLOR) += digicolor.o
diff --git a/arch/arm/mach-digicolor/digicolor.c b/arch/arm/mach-digicolor/digicolor.c
deleted file mode 100644
index 156d0d5996a9..000000000000
--- a/arch/arm/mach-digicolor/digicolor.c
+++ /dev/null
@@ -1,15 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-/*
- * Support for Conexant Digicolor SoCs
-*/
-
-#include <asm/mach/arch.h>
-
-static const char *const digicolor_dt_compat[] __initconst = {
- "cnxt,cx92755",
- NULL,
-};
-
-DT_MACHINE_START(DIGICOLOR, "Conexant Digicolor (Flattened Device Tree)")
- .dt_compat = digicolor_dt_compat,
-MACHINE_END
--
2.39.2
next prev parent reply other threads:[~2023-03-06 16:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 16:34 [PATCH 01/10] ARM: Kconfig: move platform selection into its own Kconfig file Andrew Davis
2023-03-06 16:34 ` Andrew Davis
2023-03-06 16:34 ` [PATCH 02/10] ARM: mach-asm9260: Move ASM9260 support into Kconfig.platforms Andrew Davis
2023-03-06 16:34 ` Andrew Davis
2023-03-07 6:09 ` Oleksij Rempel
2023-03-07 6:09 ` Oleksij Rempel
2023-03-06 16:34 ` [PATCH 03/10] ARM: mach-rda: Move RDA Micro " Andrew Davis
2023-03-06 16:34 ` Andrew Davis
2023-03-06 16:34 ` [PATCH 04/10] ARM: mach-uniphier: Move Socionext UniPhier " Andrew Davis
2023-03-06 16:34 ` Andrew Davis
2023-03-06 16:34 ` [PATCH 05/10] ARM: mach-moxart: Move MOXA ART " Andrew Davis
2023-03-06 16:34 ` Andrew Davis
2023-03-06 16:34 ` [PATCH 06/10] ARM: mach-airoha: Rework support and directory structure Andrew Davis
2023-03-06 16:34 ` Andrew Davis
2023-03-06 16:34 ` Andrew Davis [this message]
2023-03-06 16:34 ` [PATCH 07/10] ARM: mach-digicolor: " Andrew Davis
2023-03-06 16:34 ` [PATCH 08/10] ARM: mach-hpe: " Andrew Davis
2023-03-06 16:34 ` Andrew Davis
2023-03-06 16:34 ` [PATCH 09/10] ARM: mach-lpc18xx: " Andrew Davis
2023-03-06 16:34 ` Andrew Davis
2023-03-06 16:34 ` [PATCH 10/10] ARM: mach-sunplus: " Andrew Davis
2023-03-06 16:34 ` Andrew Davis
-- strict thread matches above, loose matches on Subject: below --
2023-05-15 16:02 [PATCH 01/10] ARM: Kconfig: move platform selection into its own Kconfig file Andrew Davis
2023-05-15 16:02 ` [PATCH 07/10] ARM: mach-digicolor: Rework support and directory structure Andrew Davis
2023-05-15 16:02 ` Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306163441.16179-7-afd@ti.com \
--to=afd@ti.com \
--cc=afaerber@suse.de \
--cc=allison@lohutok.net \
--cc=arnd@arndb.de \
--cc=baruch@tkos.co.il \
--cc=hayashi.kunihiko@socionext.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=mhiramat@kernel.org \
--cc=nick.hawkins@hpe.com \
--cc=qinjian@cqplus1.com \
--cc=tglx@linutronix.de \
--cc=vz@mleia.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.