All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herve Codina <herve.codina@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Li Yang <leoyang.li@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Qiang Zhao <qiang.zhao@nxp.com>, Takashi Iwai <tiwai@suse.com>,
	Shengjiu Wang <shengjiu.wang@gmail.com>,
	Xiubo Li <Xiubo.Lee@gmail.com>,
	Fabio Estevam <festevam@gmail.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v6 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller
Date: Mon, 6 Mar 2023 16:41:58 +0100	[thread overview]
Message-ID: <20230306164158.767e6420@bootlin.com> (raw)
In-Reply-To: <20230226174833.GA76710-robh@kernel.org>

Hi Rob,
On Sun, 26 Feb 2023 11:48:33 -0600
Rob Herring <robh@kernel.org> wrote:

[...]
> > +  '#size-cells':
> > +    const: 0
> > +
> > +  '#fsl,serial-cells':  
> 
> #foo-cells is for when there are differing foo providers which need 
> different number of cells. That's not the case here.
> 

Ok, I will remove the #fsl,serial-cells property on the next iteration.

On the next series iteration, I will also remove the #fsl,chan-cells property
present later on a patch related to the QMC binding. The #fsl,chan-cells needs
to be removed exactly for the same reason.

> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    const: 1
> > +    description:
> > +      TSA consumers that use a phandle to TSA need to pass the serial identifier
> > +      with this phandle (defined in dt-bindings/soc/fsl,tsa.h).
> > +      For instance "fsl,tsa-serial = <&tsa FSL_CPM_TSA_SCC4>;".  

Thanks for the review.
Hervé

WARNING: multiple messages have this Message-ID (diff)
From: Herve Codina <herve.codina@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	Fabio Estevam <festevam@gmail.com>,
	linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Xiubo Li <Xiubo.Lee@gmail.com>, Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>, Li Yang <leoyang.li@nxp.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	linuxppc-dev@lists.ozlabs.org, Mark Brown <broonie@kernel.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Jaroslav Kysela <perex@perex.cz>,
	Shengjiu Wang <shengjiu.wang@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Qiang Zhao <qiang.zhao@nxp.com>
Subject: Re: [PATCH v6 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller
Date: Mon, 6 Mar 2023 16:41:58 +0100	[thread overview]
Message-ID: <20230306164158.767e6420@bootlin.com> (raw)
In-Reply-To: <20230226174833.GA76710-robh@kernel.org>

Hi Rob,
On Sun, 26 Feb 2023 11:48:33 -0600
Rob Herring <robh@kernel.org> wrote:

[...]
> > +  '#size-cells':
> > +    const: 0
> > +
> > +  '#fsl,serial-cells':  
> 
> #foo-cells is for when there are differing foo providers which need 
> different number of cells. That's not the case here.
> 

Ok, I will remove the #fsl,serial-cells property on the next iteration.

On the next series iteration, I will also remove the #fsl,chan-cells property
present later on a patch related to the QMC binding. The #fsl,chan-cells needs
to be removed exactly for the same reason.

> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    const: 1
> > +    description:
> > +      TSA consumers that use a phandle to TSA need to pass the serial identifier
> > +      with this phandle (defined in dt-bindings/soc/fsl,tsa.h).
> > +      For instance "fsl,tsa-serial = <&tsa FSL_CPM_TSA_SCC4>;".  

Thanks for the review.
Hervé

WARNING: multiple messages have this Message-ID (diff)
From: Herve Codina <herve.codina@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Li Yang <leoyang.li@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Qiang Zhao <qiang.zhao@nxp.com>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Shengjiu Wang <shengjiu.wang@gmail.com>,
	Xiubo Li <Xiubo.Lee@gmail.com>,
	Fabio Estevam <festevam@gmail.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v6 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller
Date: Mon, 6 Mar 2023 16:41:58 +0100	[thread overview]
Message-ID: <20230306164158.767e6420@bootlin.com> (raw)
In-Reply-To: <20230226174833.GA76710-robh@kernel.org>

Hi Rob,
On Sun, 26 Feb 2023 11:48:33 -0600
Rob Herring <robh@kernel.org> wrote:

[...]
> > +  '#size-cells':
> > +    const: 0
> > +
> > +  '#fsl,serial-cells':  
> 
> #foo-cells is for when there are differing foo providers which need 
> different number of cells. That's not the case here.
> 

Ok, I will remove the #fsl,serial-cells property on the next iteration.

On the next series iteration, I will also remove the #fsl,chan-cells property
present later on a patch related to the QMC binding. The #fsl,chan-cells needs
to be removed exactly for the same reason.

> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    const: 1
> > +    description:
> > +      TSA consumers that use a phandle to TSA need to pass the serial identifier
> > +      with this phandle (defined in dt-bindings/soc/fsl,tsa.h).
> > +      For instance "fsl,tsa-serial = <&tsa FSL_CPM_TSA_SCC4>;".  

Thanks for the review.
Hervé

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Herve Codina <herve.codina@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Li Yang <leoyang.li@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Qiang Zhao <qiang.zhao@nxp.com>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Shengjiu Wang <shengjiu.wang@gmail.com>,
	Xiubo Li <Xiubo.Lee@gmail.com>,
	Fabio Estevam <festevam@gmail.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v6 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller
Date: Mon, 6 Mar 2023 16:41:58 +0100	[thread overview]
Message-ID: <20230306164158.767e6420@bootlin.com> (raw)
In-Reply-To: <20230226174833.GA76710-robh@kernel.org>

Hi Rob,
On Sun, 26 Feb 2023 11:48:33 -0600
Rob Herring <robh@kernel.org> wrote:

[...]
> > +  '#size-cells':
> > +    const: 0
> > +
> > +  '#fsl,serial-cells':  
> 
> #foo-cells is for when there are differing foo providers which need 
> different number of cells. That's not the case here.
> 

Ok, I will remove the #fsl,serial-cells property on the next iteration.

On the next series iteration, I will also remove the #fsl,chan-cells property
present later on a patch related to the QMC binding. The #fsl,chan-cells needs
to be removed exactly for the same reason.

> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    const: 1
> > +    description:
> > +      TSA consumers that use a phandle to TSA need to pass the serial identifier
> > +      with this phandle (defined in dt-bindings/soc/fsl,tsa.h).
> > +      For instance "fsl,tsa-serial = <&tsa FSL_CPM_TSA_SCC4>;".  

Thanks for the review.
Hervé

  reply	other threads:[~2023-03-06 15:43 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17 14:56 [PATCH v6 00/10] Add the PowerQUICC audio support using the QMC Herve Codina
2023-02-17 14:56 ` Herve Codina
2023-02-17 14:56 ` Herve Codina
2023-02-17 14:56 ` [PATCH v6 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 16:27   ` Christophe Leroy
2023-02-17 16:27     ` Christophe Leroy
2023-02-17 16:27     ` Christophe Leroy
2023-02-26 17:48   ` Rob Herring
2023-02-26 17:48     ` Rob Herring
2023-02-26 17:48     ` Rob Herring
2023-02-26 17:48     ` Rob Herring
2023-03-06 15:41     ` Herve Codina [this message]
2023-03-06 15:41       ` Herve Codina
2023-03-06 15:41       ` Herve Codina
2023-03-06 15:41       ` Herve Codina
2023-02-17 14:56 ` [PATCH v6 02/10] soc: fsl: cpm1: Add support for TSA Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 16:26   ` Christophe Leroy
2023-02-17 16:26     ` Christophe Leroy
2023-02-17 16:26     ` Christophe Leroy
2023-02-17 14:56 ` [PATCH v6 03/10] MAINTAINERS: add the Freescale TSA controller entry Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 16:27   ` Christophe Leroy
2023-02-17 16:27     ` Christophe Leroy
2023-02-17 16:27     ` Christophe Leroy
2023-02-17 14:56 ` [PATCH v6 04/10] powerpc/8xx: Use a larger CPM1 command check mask Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 14:56 ` [PATCH v6 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 16:27   ` Christophe Leroy
2023-02-17 16:27     ` Christophe Leroy
2023-02-17 16:27     ` Christophe Leroy
2023-02-17 14:56 ` [PATCH v6 06/10] soc: fsl: cpm1: Add support for QMC Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 16:28   ` Christophe Leroy
2023-02-17 16:28     ` Christophe Leroy
2023-02-17 16:28     ` Christophe Leroy
2023-02-17 14:56 ` [PATCH v6 07/10] MAINTAINERS: add the Freescale QMC controller entry Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 16:28   ` Christophe Leroy
2023-02-17 16:28     ` Christophe Leroy
2023-02-17 16:28     ` Christophe Leroy
2023-02-17 14:56 ` [PATCH v6 08/10] dt-bindings: sound: Add support for QMC audio Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 16:29   ` Christophe Leroy
2023-02-17 16:29     ` Christophe Leroy
2023-02-17 16:29     ` Christophe Leroy
2023-02-17 14:56 ` [PATCH v6 09/10] ASoC: fsl: " Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 16:30   ` Christophe Leroy
2023-02-17 16:30     ` Christophe Leroy
2023-02-17 16:30     ` Christophe Leroy
2023-02-17 14:56 ` [PATCH v6 10/10] MAINTAINERS: add the Freescale QMC audio entry Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 14:56   ` Herve Codina
2023-02-17 16:30   ` Christophe Leroy
2023-02-17 16:30     ` Christophe Leroy
2023-02-17 16:30     ` Christophe Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230306164158.767e6420@bootlin.com \
    --to=herve.codina@bootlin.com \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leoyang.li@nxp.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=nicoleotsuka@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=qiang.zhao@nxp.com \
    --cc=robh@kernel.org \
    --cc=shengjiu.wang@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.