* [Buildroot] [PATCH next] package/openfpgaloader: fix typos
@ 2023-03-06 21:16 Vincent Stehlé via buildroot
2023-03-06 21:29 ` Gwenhael Goavec-Merou
2023-03-12 9:07 ` Thomas Petazzoni via buildroot
0 siblings, 2 replies; 3+ messages in thread
From: Vincent Stehlé via buildroot @ 2023-03-06 21:16 UTC (permalink / raw)
To: buildroot; +Cc: Jean Burgat, Vincent Stehlé
Fix a typo in the name of two configuration options.
This repairs the selection of libgpiod support.
Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Cc: Jean Burgat <jeanburgat33@gmail.com>
---
Hi,
The fix for the BR2_PACKAGE_OPENFPGALOADER_LIBGPIOD has a functional change and
is applicable to the next branch only.
The fix for the BR2_PACKAGE_OPENFPGALOADER_CMSIS is also applicable to the
master branch if desired, but as it has no functional effect I think it is not
that urgent.
Best regards,
Vincent.
package/openfpgaloader/Config.in | 2 +-
package/openfpgaloader/openfpgaloader.mk | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/openfpgaloader/Config.in b/package/openfpgaloader/Config.in
index 4ba01d12d3..bd83ad415b 100644
--- a/package/openfpgaloader/Config.in
+++ b/package/openfpgaloader/Config.in
@@ -12,7 +12,7 @@ config BR2_PACKAGE_OPENFPGALOADER
if BR2_PACKAGE_OPENFPGALOADER
-config BR2_PACAKGE_OPENFPGALOADER_CMSIS
+config BR2_PACKAGE_OPENFPGALOADER_CMSIS
bool "CMSIS-DAP support"
depends on BR2_PACKAGE_HAS_UDEV # hidapi
depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # hidapi
diff --git a/package/openfpgaloader/openfpgaloader.mk b/package/openfpgaloader/openfpgaloader.mk
index 042b16612e..6d7fbd9850 100644
--- a/package/openfpgaloader/openfpgaloader.mk
+++ b/package/openfpgaloader/openfpgaloader.mk
@@ -17,14 +17,14 @@ else
OPENFPGALOADER_CONF_OPTS += -DENABLE_UDEV=OFF
endif
-ifeq ($(BR2_PACAKGE_OPENFPGALOADER_CMSIS),y)
+ifeq ($(BR2_PACKAGE_OPENFPGALOADER_CMSIS),y)
OPENFPGALOADER_DEPENDENCIES += hidapi
OPENFPGALOADER_CONF_OPTS += -DENABLE_CMSISDAP=ON
else
OPENFPGALOADER_CONF_OPTS += -DENABLE_CMSISDAP=OFF
endif
-ifeq ($(BR2_PACAKGE_OPENFPGALOADER_LIBGPIOD),y)
+ifeq ($(BR2_PACKAGE_OPENFPGALOADER_LIBGPIOD),y)
OPENFPGALOADER_DEPENDENCIES += libgpiod
OPENFPGALOADER_CONF_OPTS += -DENABLE_LIBGPIOD=ON
else
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH next] package/openfpgaloader: fix typos
2023-03-06 21:16 [Buildroot] [PATCH next] package/openfpgaloader: fix typos Vincent Stehlé via buildroot
@ 2023-03-06 21:29 ` Gwenhael Goavec-Merou
2023-03-12 9:07 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Gwenhael Goavec-Merou @ 2023-03-06 21:29 UTC (permalink / raw)
To: Vincent Stehlé via buildroot; +Cc: Jean Burgat, Vincent Stehlé
On Mon, 6 Mar 2023 22:16:46 +0100
Vincent Stehlé via buildroot <buildroot@buildroot.org> wrote:
> Fix a typo in the name of two configuration options.
> This repairs the selection of libgpiod support.
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Jean Burgat <jeanburgat33@gmail.com>
> ---
>
>
> Hi,
>
> The fix for the BR2_PACKAGE_OPENFPGALOADER_LIBGPIOD has a functional change
> and is applicable to the next branch only.
>
> The fix for the BR2_PACKAGE_OPENFPGALOADER_CMSIS is also applicable to the
> master branch if desired, but as it has no functional effect I think it is not
> that urgent.
>
> Best regards,
> Vincent.
>
>
> package/openfpgaloader/Config.in | 2 +-
> package/openfpgaloader/openfpgaloader.mk | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/openfpgaloader/Config.in
> b/package/openfpgaloader/Config.in index 4ba01d12d3..bd83ad415b 100644
> --- a/package/openfpgaloader/Config.in
> +++ b/package/openfpgaloader/Config.in
> @@ -12,7 +12,7 @@ config BR2_PACKAGE_OPENFPGALOADER
>
> if BR2_PACKAGE_OPENFPGALOADER
>
> -config BR2_PACAKGE_OPENFPGALOADER_CMSIS
> +config BR2_PACKAGE_OPENFPGALOADER_CMSIS
> bool "CMSIS-DAP support"
> depends on BR2_PACKAGE_HAS_UDEV # hidapi
> depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # hidapi
> diff --git a/package/openfpgaloader/openfpgaloader.mk
> b/package/openfpgaloader/openfpgaloader.mk index 042b16612e..6d7fbd9850 100644
> --- a/package/openfpgaloader/openfpgaloader.mk
> +++ b/package/openfpgaloader/openfpgaloader.mk
> @@ -17,14 +17,14 @@ else
> OPENFPGALOADER_CONF_OPTS += -DENABLE_UDEV=OFF
> endif
>
> -ifeq ($(BR2_PACAKGE_OPENFPGALOADER_CMSIS),y)
> +ifeq ($(BR2_PACKAGE_OPENFPGALOADER_CMSIS),y)
> OPENFPGALOADER_DEPENDENCIES += hidapi
> OPENFPGALOADER_CONF_OPTS += -DENABLE_CMSISDAP=ON
> else
> OPENFPGALOADER_CONF_OPTS += -DENABLE_CMSISDAP=OFF
> endif
>
> -ifeq ($(BR2_PACAKGE_OPENFPGALOADER_LIBGPIOD),y)
> +ifeq ($(BR2_PACKAGE_OPENFPGALOADER_LIBGPIOD),y)
> OPENFPGALOADER_DEPENDENCIES += libgpiod
> OPENFPGALOADER_CONF_OPTS += -DENABLE_LIBGPIOD=ON
> else
> --
Acked-by: Gwenhael Goavec-merou <gwenhael.goavec-merou@trabucayre.com>
Thanks!
Regards
Gwen
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH next] package/openfpgaloader: fix typos
2023-03-06 21:16 [Buildroot] [PATCH next] package/openfpgaloader: fix typos Vincent Stehlé via buildroot
2023-03-06 21:29 ` Gwenhael Goavec-Merou
@ 2023-03-12 9:07 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-03-12 9:07 UTC (permalink / raw)
To: Vincent Stehlé via buildroot; +Cc: Jean Burgat, Vincent Stehlé
On Mon, 6 Mar 2023 22:16:46 +0100
Vincent Stehlé via buildroot <buildroot@buildroot.org> wrote:
> Fix a typo in the name of two configuration options.
> This repairs the selection of libgpiod support.
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Jean Burgat <jeanburgat33@gmail.com>
> ---
Applied to next, after adding Config.in.legacy handling for
BR2_PACAKGE_OPENFPGALOADER_CMSIS. Indeed this option was already there,
and we don't want to break silently existing configurations.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-12 9:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-06 21:16 [Buildroot] [PATCH next] package/openfpgaloader: fix typos Vincent Stehlé via buildroot
2023-03-06 21:29 ` Gwenhael Goavec-Merou
2023-03-12 9:07 ` Thomas Petazzoni via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.