Re: [PATCH v2] mtd: Avoid printing error messages on probe deferrals

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Michael,

michael@walle.cc wrote on Tue, 07 Mar 2023 21:35:05 +0100:

> Am 2023-03-07 20:25, schrieb Miquel Raynal:
> > There is no reason to complain about probe errors in case of deferrals.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > Changes in v2:
> > * Use of dev_err_probe().
> > 
> >  drivers/mtd/mtdcore.c | 9 ++++-----
> >  1 file changed, 4 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> > index 0feacb9fbdac..e4e102585021 100644
> > --- a/drivers/mtd/mtdcore.c
> > +++ b/drivers/mtd/mtdcore.c
> > @@ -536,12 +536,11 @@ static int mtd_nvmem_add(struct mtd_info *mtd)
> >  	mtd->nvmem = nvmem_register(&config);
> >  	if (IS_ERR(mtd->nvmem)) {
> >  		/* Just ignore if there is no NVMEM support in the kernel */
> > -		if (PTR_ERR(mtd->nvmem) == -EOPNOTSUPP) {
> > +		if (PTR_ERR(mtd->nvmem) == -EOPNOTSUPP)
> >  			mtd->nvmem = NULL;
> > -		} else {
> > -			dev_err(&mtd->dev, "Failed to register NVMEM device\n");
> > -			return PTR_ERR(mtd->nvmem);
> > -		}
> > +		else
> > +			return dev_err_probe(&mtd->dev,	PTR_ERR(mtd->nvmem),  
> 
> There is a '\t' after the ",".

Mmmh, didn't notice, will fix it while applying.

> 
> With that fixed,
> Reviewed-by: Michael Walle <michael@walle.cc>
> 
> -michael


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/