Re: [PATCH v2] mtd: Avoid printing error messages on probe deferrals

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] mtd: Avoid printing error messages on probe deferrals
Date: Mon, 20 Mar 2023 12:23:21 +0100	[thread overview]
Message-ID: <20230320122321.052d58bf@xps-13> (raw)
In-Reply-To: <b12a0baf-b7a0-80a2-fe78-08b3b227e0c5@gmail.com>

Hi Rafał,

zajec5@gmail.com wrote on Mon, 20 Mar 2023 12:17:12 +0100:

> On 7.03.2023 20:25, Miquel Raynal wrote:
> > There is no reason to complain about probe errors in case of deferrals.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > Changes in v2:
> > * Use of dev_err_probe().
> > 
> >   drivers/mtd/mtdcore.c | 9 ++++-----
> >   1 file changed, 4 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> > index 0feacb9fbdac..e4e102585021 100644
> > --- a/drivers/mtd/mtdcore.c
> > +++ b/drivers/mtd/mtdcore.c
> > @@ -536,12 +536,11 @@ static int mtd_nvmem_add(struct mtd_info *mtd)
> >   	mtd->nvmem = nvmem_register(&config);
> >   	if (IS_ERR(mtd->nvmem)) {
> >   		/* Just ignore if there is no NVMEM support in the kernel */
> > -		if (PTR_ERR(mtd->nvmem) == -EOPNOTSUPP) {
> > +		if (PTR_ERR(mtd->nvmem) == -EOPNOTSUPP)
> >   			mtd->nvmem = NULL;
> > -		} else {
> > -			dev_err(&mtd->dev, "Failed to register NVMEM device\n");
> > -			return PTR_ERR(mtd->nvmem);
> > -		}
> > +		else
> > +			return dev_err_probe(&mtd->dev,	PTR_ERR(mtd->nvmem),
> > +					     "Failed to register NVMEM device\n");  
> 
> Even one more improvement request possibility and request from me:
> "Failed to register NVMEM device: %d\n"

I get the request, but as I was saying in the other thread, isn't this
already handled?

https://elixir.bootlin.com/linux/latest/source/drivers/base/core.c#L4961

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/