From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <simon.horman@corigine.com>
Cc: Fedor Pchelkin <pchelkin@ispras.ru>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Minsuk Kang <linuxlovemin@yonsei.ac.kr>,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org,
syzbot+1e608ba4217c96d1952f@syzkaller.appspotmail.com
Subject: Re: [PATCH] nfc: pn533: initialize struct pn533_out_arg properly
Date: Wed, 8 Mar 2023 18:30:35 -0800 [thread overview]
Message-ID: <20230308183035.0fb2febd@kernel.org> (raw)
In-Reply-To: <ZAdcGkqnfRDwJq5y@corigine.com>
On Tue, 7 Mar 2023 16:45:30 +0100 Simon Horman wrote:
> nit: This doesn't follow reverse xmas tree ordering - longest to shortest line.
> It's probably not worth respinning, but I expect the preferred
> approach is (*completely untested!*)
>
> ...
> struct pn533_out_arg arg;
> ...
>
> arg.phy = phy;
Let's do it this way.
And please make sure that the patch is based on top of the netdev/net
tree from git.kernel.org, looks like this version doesn't apply cleanly.
next prev parent reply other threads:[~2023-03-09 2:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 21:48 [PATCH] nfc: pn533: initialize struct pn533_out_arg properly Fedor Pchelkin
2023-03-07 15:45 ` Simon Horman
2023-03-09 2:30 ` Jakub Kicinski [this message]
2023-03-09 16:50 ` [PATCH v2] " Fedor Pchelkin
2023-03-10 11:57 ` Simon Horman
2023-03-11 0:00 ` patchwork-bot+netdevbpf
2023-03-09 16:10 ` [PATCH] " Fedor Pchelkin
2023-03-09 16:41 ` Simon Horman
2023-03-08 10:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308183035.0fb2febd@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=khoroshilov@ispras.ru \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxlovemin@yonsei.ac.kr \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pchelkin@ispras.ru \
--cc=simon.horman@corigine.com \
--cc=syzbot+1e608ba4217c96d1952f@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.