From: Simon Horman <simon.horman@corigine.com>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: Jakub Kicinski <kuba@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Minsuk Kang <linuxlovemin@yonsei.ac.kr>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
lvc-project@linuxtesting.org,
syzbot+1e608ba4217c96d1952f@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] nfc: pn533: initialize struct pn533_out_arg properly
Date: Fri, 10 Mar 2023 12:57:20 +0100 [thread overview]
Message-ID: <ZAsbIB4fk8KhhTpF@corigine.com> (raw)
In-Reply-To: <20230309165050.207390-1-pchelkin@ispras.ru>
On Thu, Mar 09, 2023 at 07:50:50PM +0300, Fedor Pchelkin wrote:
> struct pn533_out_arg used as a temporary context for out_urb is not
> initialized properly. Its uninitialized 'phy' field can be dereferenced in
> error cases inside pn533_out_complete() callback function. It causes the
> following failure:
>
> general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN
> KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
> CPU: 1 PID: 0 Comm: swapper/1 Not tainted 6.2.0-rc3-next-20230110-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
> RIP: 0010:pn533_out_complete.cold+0x15/0x44 drivers/nfc/pn533/usb.c:441
> Call Trace:
> <IRQ>
> __usb_hcd_giveback_urb+0x2b6/0x5c0 drivers/usb/core/hcd.c:1671
> usb_hcd_giveback_urb+0x384/0x430 drivers/usb/core/hcd.c:1754
> dummy_timer+0x1203/0x32d0 drivers/usb/gadget/udc/dummy_hcd.c:1988
> call_timer_fn+0x1da/0x800 kernel/time/timer.c:1700
> expire_timers+0x234/0x330 kernel/time/timer.c:1751
> __run_timers kernel/time/timer.c:2022 [inline]
> __run_timers kernel/time/timer.c:1995 [inline]
> run_timer_softirq+0x326/0x910 kernel/time/timer.c:2035
> __do_softirq+0x1fb/0xaf6 kernel/softirq.c:571
> invoke_softirq kernel/softirq.c:445 [inline]
> __irq_exit_rcu+0x123/0x180 kernel/softirq.c:650
> irq_exit_rcu+0x9/0x20 kernel/softirq.c:662
> sysvec_apic_timer_interrupt+0x97/0xc0 arch/x86/kernel/apic/apic.c:1107
>
> Initialize the field with the pn533_usb_phy currently used.
>
> Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
>
> Fixes: 9dab880d675b ("nfc: pn533: Wait for out_urb's completion in pn533_usb_send_frame()")
> Reported-by: syzbot+1e608ba4217c96d1952f@syzkaller.appspotmail.com
> Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-03-10 11:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 21:48 [PATCH] nfc: pn533: initialize struct pn533_out_arg properly Fedor Pchelkin
2023-03-07 15:45 ` Simon Horman
2023-03-09 2:30 ` Jakub Kicinski
2023-03-09 16:50 ` [PATCH v2] " Fedor Pchelkin
2023-03-10 11:57 ` Simon Horman [this message]
2023-03-11 0:00 ` patchwork-bot+netdevbpf
2023-03-09 16:10 ` [PATCH] " Fedor Pchelkin
2023-03-09 16:41 ` Simon Horman
2023-03-08 10:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAsbIB4fk8KhhTpF@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=khoroshilov@ispras.ru \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxlovemin@yonsei.ac.kr \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pchelkin@ispras.ru \
--cc=syzbot+1e608ba4217c96d1952f@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.