From: Eric Wong <e@80x24.org>
To: Jeff King <peff@peff.net>
Cc: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, gitster@pobox.com, me@ttaylorr.com,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Derrick Stolee" <derrickstolee@github.com>,
"Konstantin Ryabitsev" <konstantin@linuxfoundation.org>
Subject: Re: [PATCH v2] object-file: reprepare alternates when necessary
Date: Thu, 9 Mar 2023 09:06:08 +0000 [thread overview]
Message-ID: <20230309090608.M92573@dcvr> (raw)
In-Reply-To: <ZAmJtnLgwimRBGTb@coredump.intra.peff.net>
Jeff King <peff@peff.net> wrote:
> The only downside might be performance. For sane cases, I think scanning
> the new alternates is OK. I know Eric (cc'd) has some crazy
> 100k-alternate setup (from 407532f82d, etc), but I'd expect a reprepare
> there is already expensive (we already have to re-scan every one of
> those directories for packfiles, and throw out any loose object caches).
I'm not sure if that 100k alternate thing is happening, yet...
(initial specs called for ~30k, but I figured it might grow)
If it does, I'm thinking about enhancing --batch-command, to support
`add-alternate' to dynamically add alternates while running cat-file.
Right now, my biggest use case is only 250 alternates or so.
next prev parent reply other threads:[~2023-03-09 9:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 20:59 [PATCH] object-file: reprepare alternates when necessary Derrick Stolee via GitGitGadget
2023-03-06 22:54 ` Junio C Hamano
2023-03-07 0:28 ` Taylor Blau
2023-03-07 14:52 ` Derrick Stolee
2023-03-07 17:16 ` Junio C Hamano
2023-03-08 15:55 ` Taylor Blau
2023-03-08 17:13 ` Derrick Stolee
2023-03-07 11:28 ` Ævar Arnfjörð Bjarmason
2023-03-07 17:29 ` Junio C Hamano
2023-03-07 18:18 ` Junio C Hamano
2023-03-08 13:29 ` Derrick Stolee
2023-03-08 18:47 ` [PATCH v2] " Derrick Stolee via GitGitGadget
2023-03-08 19:35 ` Junio C Hamano
2023-03-08 20:47 ` Taylor Blau
2023-03-09 7:24 ` Jeff King
2023-03-09 9:06 ` Eric Wong [this message]
2023-03-10 21:29 ` Jonathan Tan
2023-03-11 0:01 ` Junio C Hamano
2023-03-11 3:09 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309090608.M92573@dcvr \
--to=e@80x24.org \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=konstantin@linuxfoundation.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.