All of lore.kernel.org
 help / color / mirror / Atom feed
* [lunn:v6.2.0-net-next-phy-leds 27/28] drivers/net/phy/phy_device.c:3097:13: error: 'struct led_classdev' has no member named 'hw_control_get_device'
@ 2023-03-09  6:02 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-03-09  6:02 UTC (permalink / raw)
  To: Andrew Lunn; +Cc: oe-kbuild-all

tree:   https://github.com/lunn/linux.git v6.2.0-net-next-phy-leds
head:   5e80c5c7b6177d29b99f274eeffbfd2faf6a8985
commit: 9ef4575a04bf842629ba73306f2654e4b34aac62 [27/28] net: phy: Implement hw_control_get_device()
config: m68k-defconfig (https://download.01.org/0day-ci/archive/20230309/202303091418.gZAzIgnX-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/lunn/linux/commit/9ef4575a04bf842629ba73306f2654e4b34aac62
        git remote add lunn https://github.com/lunn/linux.git
        git fetch --no-tags lunn v6.2.0-net-next-phy-leds
        git checkout 9ef4575a04bf842629ba73306f2654e4b34aac62
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303091418.gZAzIgnX-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/phy/phy_device.c: In function 'of_phy_led':
   drivers/net/phy/phy_device.c:3096:21: error: 'struct led_classdev' has no member named 'hw_control_configure'
    3096 |                 cdev->hw_control_configure = phy_led_hw_control_configure;
         |                     ^~
>> drivers/net/phy/phy_device.c:3097:13: error: 'struct led_classdev' has no member named 'hw_control_get_device'
    3097 |         cdev->hw_control_get_device = phy_led_hw_control_get_device;
         |             ^~


vim +3097 drivers/net/phy/phy_device.c

  3067	
  3068	static int of_phy_led(struct phy_device *phydev,
  3069			      struct device_node *led)
  3070	{
  3071		struct device *dev = &phydev->mdio.dev;
  3072		struct led_init_data init_data = {};
  3073		struct led_classdev *cdev;
  3074		struct phy_led *phyled;
  3075		int err;
  3076	
  3077		phyled = devm_kzalloc(dev, sizeof(*phyled), GFP_KERNEL);
  3078		if (!phyled)
  3079			return -ENOMEM;
  3080	
  3081		phyled->phydev = phydev;
  3082		cdev = &phyled->led_cdev;
  3083		INIT_LIST_HEAD(&phyled->led_list);
  3084	
  3085		err = of_property_read_u32(led, "reg", &phyled->index);
  3086		if (err)
  3087			return err;
  3088	
  3089		if (phydev->drv->led_brightness_set)
  3090			cdev->brightness_set_blocking = phy_led_set_brightness;
  3091		if (phydev->drv->led_blink_set)
  3092			cdev->blink_set = phy_led_blink_set;
  3093		if (phydev->drv->led_hw_is_supported &&
  3094		    phydev->drv->led_hw_control_set &&
  3095		    phydev->drv->led_hw_control_get)
  3096			cdev->hw_control_configure = phy_led_hw_control_configure;
> 3097		cdev->hw_control_get_device = phy_led_hw_control_get_device;
  3098		cdev->max_brightness = 1;
  3099		init_data.devicename = dev_name(&phydev->mdio.dev);
  3100		init_data.fwnode = of_fwnode_handle(led);
  3101	
  3102		err = devm_led_classdev_register_ext(dev, cdev, &init_data);
  3103		if (err)
  3104			return err;
  3105	
  3106		list_add(&phyled->led_list, &phydev->led_list);
  3107	
  3108		return 0;
  3109	}
  3110	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-09  6:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-09  6:02 [lunn:v6.2.0-net-next-phy-leds 27/28] drivers/net/phy/phy_device.c:3097:13: error: 'struct led_classdev' has no member named 'hw_control_get_device' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.