From: Al Viro via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Evgeniy Dushistov <dushistov@mail.ru>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH 1/3] ufs: don't flush page immediately for DIRSYNC directories
Date: Fri, 10 Mar 2023 06:52:35 +0000 [thread overview]
Message-ID: <20230310065235.GR3390869@ZenIV> (raw)
In-Reply-To: <20230310063756.GA13484@lst.de>
On Fri, Mar 10, 2023 at 07:37:56AM +0100, Christoph Hellwig wrote:
> On Fri, Mar 10, 2023 at 03:53:53AM +0000, Al Viro wrote:
> > On Tue, Mar 07, 2023 at 03:31:23PM +0100, Christoph Hellwig wrote:
> > > We do not need to writeout modified directory blocks immediately when
> > > modifying them while the page is locked. It is enough to do the flush
> > > somewhat later which has the added benefit that inode times can be
> > > flushed as well. It also allows us to stop depending on
> > > write_one_page() function.
> > >
> > > Ported from an ext2 patch by Jan Kara.
> >
> > Umm... I'll throw it in ufs pile, I guess (tomorrow - I'll need to
> > sort out Fabio's patches in the area as well; IIRC, the latest
> > had been in late December).
>
> Well, the three patches really should go together, otherwise we miss
> yet another merge window.
Umm... Do you need them in the same (never-rebased?) branch, or would
it suffice to have all of them reach mainline by 6.4-rc1?
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Evgeniy Dushistov <dushistov@mail.ru>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 1/3] ufs: don't flush page immediately for DIRSYNC directories
Date: Fri, 10 Mar 2023 06:52:35 +0000 [thread overview]
Message-ID: <20230310065235.GR3390869@ZenIV> (raw)
In-Reply-To: <20230310063756.GA13484@lst.de>
On Fri, Mar 10, 2023 at 07:37:56AM +0100, Christoph Hellwig wrote:
> On Fri, Mar 10, 2023 at 03:53:53AM +0000, Al Viro wrote:
> > On Tue, Mar 07, 2023 at 03:31:23PM +0100, Christoph Hellwig wrote:
> > > We do not need to writeout modified directory blocks immediately when
> > > modifying them while the page is locked. It is enough to do the flush
> > > somewhat later which has the added benefit that inode times can be
> > > flushed as well. It also allows us to stop depending on
> > > write_one_page() function.
> > >
> > > Ported from an ext2 patch by Jan Kara.
> >
> > Umm... I'll throw it in ufs pile, I guess (tomorrow - I'll need to
> > sort out Fabio's patches in the area as well; IIRC, the latest
> > had been in late December).
>
> Well, the three patches really should go together, otherwise we miss
> yet another merge window.
Umm... Do you need them in the same (never-rebased?) branch, or would
it suffice to have all of them reach mainline by 6.4-rc1?
next prev parent reply other threads:[~2023-03-10 6:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 14:31 [Ocfs2-devel] remove most callers of write_one_page v4 Christoph Hellwig via Ocfs2-devel
2023-03-07 14:31 ` Christoph Hellwig
2023-03-07 14:31 ` [Ocfs2-devel] [PATCH 1/3] ufs: don't flush page immediately for DIRSYNC directories Christoph Hellwig via Ocfs2-devel
2023-03-07 14:31 ` Christoph Hellwig
2023-03-10 3:53 ` [Ocfs2-devel] " Al Viro via Ocfs2-devel
2023-03-10 3:53 ` Al Viro
2023-03-10 6:37 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-03-10 6:37 ` Christoph Hellwig
2023-03-10 6:52 ` Al Viro via Ocfs2-devel [this message]
2023-03-10 6:52 ` Al Viro
2023-03-10 7:00 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-03-10 7:00 ` Christoph Hellwig
2023-03-10 7:09 ` [Ocfs2-devel] " Al Viro via Ocfs2-devel
2023-03-10 7:09 ` Al Viro
2023-03-07 14:31 ` [Ocfs2-devel] [PATCH 2/3] ocfs2: don't use write_one_page in ocfs2_duplicate_clusters_by_page Christoph Hellwig via Ocfs2-devel
2023-03-07 14:31 ` Christoph Hellwig
2023-03-10 3:49 ` [Ocfs2-devel] " Al Viro via Ocfs2-devel
2023-03-10 3:49 ` Al Viro
2023-03-07 14:31 ` [Ocfs2-devel] [PATCH 3/3] mm, jfs: move write_one_page/folio_write_one to jfs Christoph Hellwig via Ocfs2-devel
2023-03-07 14:31 ` [PATCH 3/3] mm,jfs: " Christoph Hellwig
2023-03-07 16:21 ` [Ocfs2-devel] [PATCH 3/3] mm, jfs: " Dave Kleikamp via Ocfs2-devel
2023-03-07 16:21 ` [PATCH 3/3] mm,jfs: " Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310065235.GR3390869@ZenIV \
--to=ocfs2-devel@oss.oracle.com \
--cc=dushistov@mail.ru \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.