[PATCH] Staging: qlge: Fix indentation in conditional statement

[PATCH] Staging: qlge: Fix indentation in conditional statement

[Sumitra Sharma]

Add tabs/spaces in conditional statements in qlge_dbg.c to fix the
indentation.

Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
---
 drivers/staging/qlge/qlge_dbg.c | 35 +++++++++++++++------------------
 1 file changed, 16 insertions(+), 19 deletions(-)

diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index b190a2993033..c7e865f515cf 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -351,26 +351,23 @@ static int qlge_get_xgmac_regs(struct qlge_adapter *qdev, u32 *buf,
 		/* We're reading 400 xgmac registers, but we filter out
 		 * several locations that are non-responsive to reads.
 		 */
-		if (i == 0x00000114 ||
-		    i == 0x00000118 ||
-			i == 0x0000013c ||
-			i == 0x00000140 ||
-			(i > 0x00000150 && i < 0x000001fc) ||
-			(i > 0x00000278 && i < 0x000002a0) ||
-			(i > 0x000002c0 && i < 0x000002cf) ||
-			(i > 0x000002dc && i < 0x000002f0) ||
-			(i > 0x000003c8 && i < 0x00000400) ||
-			(i > 0x00000400 && i < 0x00000410) ||
-			(i > 0x00000410 && i < 0x00000420) ||
-			(i > 0x00000420 && i < 0x00000430) ||
-			(i > 0x00000430 && i < 0x00000440) ||
-			(i > 0x00000440 && i < 0x00000450) ||
-			(i > 0x00000450 && i < 0x00000500) ||
-			(i > 0x0000054c && i < 0x00000568) ||
-			(i > 0x000005c8 && i < 0x00000600)) {
+		if ((i == 0x00000114) || (i == 0x00000118) ||
+		    (i == 0x0000013c) || (i == 0x00000140) ||
+		    (i > 0x00000150 && i < 0x000001fc) ||
+		    (i > 0x00000278 && i < 0x000002a0) ||
+		    (i > 0x000002c0 && i < 0x000002cf) ||
+		    (i > 0x000002dc && i < 0x000002f0) ||
+		    (i > 0x000003c8 && i < 0x00000400) ||
+		    (i > 0x00000400 && i < 0x00000410) ||
+		    (i > 0x00000410 && i < 0x00000420) ||
+		    (i > 0x00000420 && i < 0x00000430) ||
+		    (i > 0x00000430 && i < 0x00000440) ||
+		    (i > 0x00000440 && i < 0x00000450) ||
+		    (i > 0x00000450 && i < 0x00000500) ||
+		    (i > 0x0000054c && i < 0x00000568) ||
+		    (i > 0x000005c8 && i < 0x00000600)) {
 			if (other_function)
-				status =
-				qlge_read_other_func_xgmac_reg(qdev, i, buf);
+				status = qlge_read_other_func_xgmac_reg(qdev, i, buf);
 			else
 				status = qlge_read_xgmac_reg(qdev, i, buf);
 
-- 
2.25.1

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Dan Carpenter]

On Sat, Mar 11, 2023 at 07:24:53AM -0800, Sumitra Sharma wrote:
> Add tabs/spaces in conditional statements in qlge_dbg.c to fix the
> indentation.
> 
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> ---
>  drivers/staging/qlge/qlge_dbg.c | 35 +++++++++++++++------------------
>  1 file changed, 16 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
> index b190a2993033..c7e865f515cf 100644
> --- a/drivers/staging/qlge/qlge_dbg.c
> +++ b/drivers/staging/qlge/qlge_dbg.c
> @@ -351,26 +351,23 @@ static int qlge_get_xgmac_regs(struct qlge_adapter *qdev, u32 *buf,
>  		/* We're reading 400 xgmac registers, but we filter out
>  		 * several locations that are non-responsive to reads.
>  		 */
> -		if (i == 0x00000114 ||
> -		    i == 0x00000118 ||
> -			i == 0x0000013c ||
> -			i == 0x00000140 ||

You've written this on top of the other patch which we're not going
to apply so it's not going to work.

> -			(i > 0x00000150 && i < 0x000001fc) ||
> -			(i > 0x00000278 && i < 0x000002a0) ||
> -			(i > 0x000002c0 && i < 0x000002cf) ||
> -			(i > 0x000002dc && i < 0x000002f0) ||
> -			(i > 0x000003c8 && i < 0x00000400) ||
> -			(i > 0x00000400 && i < 0x00000410) ||
> -			(i > 0x00000410 && i < 0x00000420) ||
> -			(i > 0x00000420 && i < 0x00000430) ||
> -			(i > 0x00000430 && i < 0x00000440) ||
> -			(i > 0x00000440 && i < 0x00000450) ||
> -			(i > 0x00000450 && i < 0x00000500) ||
> -			(i > 0x0000054c && i < 0x00000568) ||
> -			(i > 0x000005c8 && i < 0x00000600)) {
> +		if ((i == 0x00000114) || (i == 0x00000118) ||
> +		    (i == 0x0000013c) || (i == 0x00000140) ||

If we could have applied the patch then I wouldn't comment here.  But
since you're going to have to redo it anyway...  I would probably have
kept these on separate lines.

		if ((i == 0x00000114) ||
		    (i == 0x00000118) ||
		    (i == 0x0000013c) ||
	            (i == 0x00000140) ||
		    (i > 0x00000150 && i < 0x000001fc) ||
		    (i > 0x00000278 && i < 0x000002a0) ||

I like that you are looking around and making changes, like this but to
me it seems more readable if 0x114 0x118 etc are all in the same
column.

> +		    (i > 0x00000150 && i < 0x000001fc) ||
> +		    (i > 0x00000278 && i < 0x000002a0) ||
> +		    (i > 0x000002c0 && i < 0x000002cf) ||
> +		    (i > 0x000002dc && i < 0x000002f0) ||
> +		    (i > 0x000003c8 && i < 0x00000400) ||
> +		    (i > 0x00000400 && i < 0x00000410) ||
> +		    (i > 0x00000410 && i < 0x00000420) ||
> +		    (i > 0x00000420 && i < 0x00000430) ||
> +		    (i > 0x00000430 && i < 0x00000440) ||
> +		    (i > 0x00000440 && i < 0x00000450) ||
> +		    (i > 0x00000450 && i < 0x00000500) ||
> +		    (i > 0x0000054c && i < 0x00000568) ||
> +		    (i > 0x000005c8 && i < 0x00000600)) {
>  			if (other_function)
> -				status =
> -				qlge_read_other_func_xgmac_reg(qdev, i, buf);
> +				status = qlge_read_other_func_xgmac_reg(qdev, i, buf);

This change wasn't described in the commit message.  This change is a
borderline situation on the one thing per patch rule.  We would
probably allow it under certain circumstances if it were described
correctly in the commit message.  But with Outreachy we're crazy strict
about stuff like this.  Just send it as a separate patch.

So now this is a v2 patch situation.  Outreachy has their own docs.  But
I have a blog about this which is super short.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/


regards,
dan carpenter

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Sumitra Sharma]

Yes, surely

Thank you again.

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Julia Lawall]

On Sat, 11 Mar 2023, Sumitra Sharma wrote:

> Yes, surely
>
> Thank you again.

Sumitra,

It would be nice to quote at least the most relevant part of what you are
responding to, so people on the list can have some idea of what is being
discussed, and assess whether it concerns them.

julia

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Sumitra Sharma]

Hi julia

I will take care of it next time.

Regards,

Sumitra

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Julia Lawall]

On Sat, 11 Mar 2023, Sumitra Sharma wrote:

> Hi julia
>
> I will take care of it next time.

Take care of what?

julia

>
> Regards,
>
> Sumitra
>

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Sumitra Sharma]

Hi julia

I was referring to the reply you sent in this thread and asking to quote the most relevant information in the mails so that people on the list can know what is being discussed. And I will take care of this in my upcoming mails.

Thanks and regards

Sumitra

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Julia Lawall]

On Sat, 11 Mar 2023, Sumitra Sharma wrote:

> Hi julia
>
> I was referring to the reply you sent in this thread and asking to quote
> the most relevant information in the mails so that people on the list
> can know what is being discussed. And I will take care of this in my
> upcoming mails.

Sorry to press the point, but you should be doing it now, not promising to
do it in the future.

If there is some challenge in doing this, please let us know, and perhaps
someone can offer some advice.

julia

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Sumitra Sharma]

Hi julia,

>> Hi julia
>>
>> I was referring to the reply you sent in this thread and asking to quote
>> the most relevant information in the mails so that people on the list
>> can know what is being discussed. And I will take care of this in my
>> upcoming mails.
>>
>
> Sorry to press the point, but you should be doing it now, not promising to
> do it in the future.
>

I am sorry for repeating my mistake again and again and may be this time
too. But, I am trying to correct it.

>
> If there is some challenge in doing this, please let us know, and perhaps someone can offer some advice.
>

To be honest I am struggling responding inline. Right now I did it
maually by pasting your message into mutt and putting the ">" things. I
know this is not the correct way to do. Please guide me to the correct method of responding inline.

Regards,

Sumitra

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Julia Lawall]

On Sun, 12 Mar 2023, Sumitra Sharma wrote:

> Hi julia,
>
> >> Hi julia
> >>
> >> I was referring to the reply you sent in this thread and asking to quote
> >> the most relevant information in the mails so that people on the list
> >> can know what is being discussed. And I will take care of this in my
> >> upcoming mails.
> >>
> >
> > Sorry to press the point, but you should be doing it now, not promising to
> > do it in the future.
> >
>
> I am sorry for repeating my mistake again and again and may be this time
> too. But, I am trying to correct it.
>
> >
> > If there is some challenge in doing this, please let us know, and perhaps someone can offer some advice.
> >
>
> To be honest I am struggling responding inline. Right now I did it
> maually by pasting your message into mutt and putting the ">" things. I
> know this is not the correct way to do. Please guide me to the correct method of responding inline.

I don't use either gmail or mutt, so I'm not an expert.  But to interact
with others about your patches, you will have to solve this problem.

You should be able to receive messages in mutt.  There is some information
in the Outreachy first patch tutorial:

https://kernelnewbies.org/Outreachyfirstpatch

The following link may be useful:

https://www.makeuseof.com/install-configure-mutt-with-gmail-on-linux/

Once your mail arrives in mutt, you should just be able to respond to
other people and have the >s in front of what they said directly.

julia

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Sumitra Sharma]

On Sun, Mar 12, 2023 at 02:21:56PM +0100, Julia Lawall wrote:
> 
> 
> On Sun, 12 Mar 2023, Sumitra Sharma wrote:
> 
> > Hi julia,
> >
> > >> Hi julia
> > >>
> > >> I was referring to the reply you sent in this thread and asking to quote
> > >> the most relevant information in the mails so that people on the list
> > >> can know what is being discussed. And I will take care of this in my
> > >> upcoming mails.
> > >>
> > >
> > > Sorry to press the point, but you should be doing it now, not promising to
> > > do it in the future.
> > >
> >
> > I am sorry for repeating my mistake again and again and may be this time
> > too. But, I am trying to correct it.
> >
> > >
> > > If there is some challenge in doing this, please let us know, and perhaps someone can offer some advice.
> > >
> >
> > To be honest I am struggling responding inline. Right now I did it
> > maually by pasting your message into mutt and putting the ">" things. I
> > know this is not the correct way to do. Please guide me to the correct method of responding inline.
> 
> I don't use either gmail or mutt, so I'm not an expert.  But to interact
> with others about your patches, you will have to solve this problem.
> 
> You should be able to receive messages in mutt.  There is some information
> in the Outreachy first patch tutorial:
> 
> https://kernelnewbies.org/Outreachyfirstpatch
> 
> The following link may be useful:
> 
> https://www.makeuseof.com/install-configure-mutt-with-gmail-on-linux/
> 
> Once your mail arrives in mutt, you should just be able to respond to
> other people and have the >s in front of what they said directly.
> 
> julia

Thank you julia for your help. I am now able to respond inline.

Regards,

Sumitra

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Julia Lawall]

On Sun, 12 Mar 2023, Sumitra Sharma wrote:

> On Sun, Mar 12, 2023 at 02:21:56PM +0100, Julia Lawall wrote:
> >
> >
> > On Sun, 12 Mar 2023, Sumitra Sharma wrote:
> >
> > > Hi julia,
> > >
> > > >> Hi julia
> > > >>
> > > >> I was referring to the reply you sent in this thread and asking to quote
> > > >> the most relevant information in the mails so that people on the list
> > > >> can know what is being discussed. And I will take care of this in my
> > > >> upcoming mails.
> > > >>
> > > >
> > > > Sorry to press the point, but you should be doing it now, not promising to
> > > > do it in the future.
> > > >
> > >
> > > I am sorry for repeating my mistake again and again and may be this time
> > > too. But, I am trying to correct it.
> > >
> > > >
> > > > If there is some challenge in doing this, please let us know, and perhaps someone can offer some advice.
> > > >
> > >
> > > To be honest I am struggling responding inline. Right now I did it
> > > maually by pasting your message into mutt and putting the ">" things. I
> > > know this is not the correct way to do. Please guide me to the correct method of responding inline.
> >
> > I don't use either gmail or mutt, so I'm not an expert.  But to interact
> > with others about your patches, you will have to solve this problem.
> >
> > You should be able to receive messages in mutt.  There is some information
> > in the Outreachy first patch tutorial:
> >
> > https://kernelnewbies.org/Outreachyfirstpatch
> >
> > The following link may be useful:
> >
> > https://www.makeuseof.com/install-configure-mutt-with-gmail-on-linux/
> >
> > Once your mail arrives in mutt, you should just be able to respond to
> > other people and have the >s in front of what they said directly.
> >
> > julia
>
> Thank you julia for your help. I am now able to respond inline.

OK.  Was the information in the outrechy tutorial sufficient?  If not, it
could be good to extend it.

julia


>
> Regards,
>
> Sumitra
>

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Sumitra Sharma]

On Sun, Mar 12, 2023 at 04:31:48PM +0100, Julia Lawall wrote:
> 
> 
> On Sun, 12 Mar 2023, Sumitra Sharma wrote:
> 
> > On Sun, Mar 12, 2023 at 02:21:56PM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Sun, 12 Mar 2023, Sumitra Sharma wrote:
> > >
> > > > Hi julia,
> > > >
> > > > >> Hi julia
> > > > >>
> > > > >> I was referring to the reply you sent in this thread and asking to quote
> > > > >> the most relevant information in the mails so that people on the list
> > > > >> can know what is being discussed. And I will take care of this in my
> > > > >> upcoming mails.
> > > > >>
> > > > >
> > > > > Sorry to press the point, but you should be doing it now, not promising to
> > > > > do it in the future.
> > > > >
> > > >
> > > > I am sorry for repeating my mistake again and again and may be this time
> > > > too. But, I am trying to correct it.
> > > >
> > > > >
> > > > > If there is some challenge in doing this, please let us know, and perhaps someone can offer some advice.
> > > > >
> > > >
> > > > To be honest I am struggling responding inline. Right now I did it
> > > > maually by pasting your message into mutt and putting the ">" things. I
> > > > know this is not the correct way to do. Please guide me to the correct method of responding inline.
> > >
> > > I don't use either gmail or mutt, so I'm not an expert.  But to interact
> > > with others about your patches, you will have to solve this problem.
> > >
> > > You should be able to receive messages in mutt.  There is some information
> > > in the Outreachy first patch tutorial:
> > >
> > > https://kernelnewbies.org/Outreachyfirstpatch
> > >
> > > The following link may be useful:
> > >
> > > https://www.makeuseof.com/install-configure-mutt-with-gmail-on-linux/
> > >
> > > Once your mail arrives in mutt, you should just be able to respond to
> > > other people and have the >s in front of what they said directly.
> > >
> > > julia
> >
> > Thank you julia for your help. I am now able to respond inline.
> 
> OK.  Was the information in the outrechy tutorial sufficient?  If not, it
> could be good to extend it.
> 
> julia
> 
> 
> >
> > Regards,
> >
> > Sumitra
> >

Hi julia

No the information present in the outreachy tutorial is not sufficient.
It doesnt contains steps to make the inbox. Infact the other link https://www.makeuseof.com/install-configure-mutt-with-gmail-on-linux/ was more of use.

Regards,

Sumitra

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Khadija Kamran]

On Sun, Mar 12, 2023 at 04:31:48PM +0100, Julia Lawall wrote:
> OK.  Was the information in the outrechy tutorial sufficient?  If not, it
> could be good to extend it.
> 
> julia
>

Hey Julia!

I thought I should reply here too. I hope that is not a problem.

I had a hard time configuring mutt, from the information in the
outreachy tutorial. I could send my patches but I had no idea how to
respond to mails from INBOX and how to send inline replies.

Regards,
Khadija

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Julia Lawall]

> > OK.  Was the information in the outrechy tutorial sufficient?  If not, it
> > could be good to extend it.
> >
> > julia
> >
> >
> > >
> > > Regards,
> > >
> > > Sumitra
> > >
>
> Hi julia
>
> No the information present in the outreachy tutorial is not sufficient.
> It doesnt contains steps to make the inbox. Infact the other link https://www.makeuseof.com/install-configure-mutt-with-gmail-on-linux/ was more of use.

OK, it would be good to extend it.

Note that you should not just reply at the end of the previous message.
You should reply under the relevant text, like I have done.

julia

>
> Regards,
>
> Sumitra
>
>

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Julia Lawall]

On Sun, 12 Mar 2023, Khadija Kamran wrote:

> On Sun, Mar 12, 2023 at 04:31:48PM +0100, Julia Lawall wrote:
> > OK.  Was the information in the outrechy tutorial sufficient?  If not, it
> > could be good to extend it.
> >
> > julia
> >
>
> Hey Julia!
>
> I thought I should reply here too. I hope that is not a problem.
>
> I had a hard time configuring mutt, from the information in the
> outreachy tutorial. I could send my patches but I had no idea how to
> respond to mails from INBOX and how to send inline replies.

OK, now Sumitra can help you :)

julia


>
> Regards,
> Khadija
>
>

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Deepak R Varma]

On Sun, Mar 12, 2023 at 08:56:24PM +0500, Khadija Kamran wrote:
> On Sun, Mar 12, 2023 at 04:31:48PM +0100, Julia Lawall wrote:
> > OK.  Was the information in the outrechy tutorial sufficient?  If not, it
> > could be good to extend it.
> > 
> > julia
> >
> 
> Hey Julia!
> 
> I thought I should reply here too. I hope that is not a problem.
> 
> I had a hard time configuring mutt, from the information in the
> outreachy tutorial. I could send my patches but I had no idea how to
> respond to mails from INBOX and how to send inline replies.

Hello,
Using mutt was equally difficult for me when I started with the Linux community
couple of years ago. I did this following to build some comfort with this tool
and learn the Linux Community Patch communication protocol.

1. Install and configure mutt
	I followed this youtube video for my first setup of mutt: https://www.youtube.com/watch?v=2jMInHnpNfQ
	Note that some settings may vary from one email service provider to
	another. You may need to do additional search to get the correct email
	server settings for your email service provider.
2. Practice mutt
	I had another account that used to exchange emails with from my newly
	configured mutt account. I started with 4 paragraph dummy email and kept
	on sending it across a few times to learn the mutt commands such as
	write new mail, reply, reply-all, switch to sent emails folder,
	fold/unfold, move emails across mailboxes, delete emails, recover
	deleted emails etc.
3. I subscribed to couple of Linux Kernel development mailing lists available
at http://vger.kernel.org/vger-lists.html My objective was to understand how
developers communicate on patch submissions. Just reading through these email
exchanges for a 2-3 days helped me understand how community emailing works.
If you wish to do this, choose a mailing list that has moderate traffic [bellow
80 emails in a day, otherwise this can distract you.

4. Refer to the mutt.org documentation for additional learning and configuration.

I suppose most of the applicants have by now configured mutt well. Please read
through the previous advice offered by the mentors and experts. If you still
have questions, feel free to ask.

It is a nice proposal to update documentation about using mutt in the Outreachy
tutorial. But you all should also continue to focus on getting good patches
submitted and accepted within the stipulated time frame of the application
period.



> 
> Regards,
> Khadija
> 
> 

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Sumitra Sharma]

On Sun, Mar 12, 2023 at 08:56:24PM +0500, Khadija Kamran wrote:
> On Sun, Mar 12, 2023 at 04:31:48PM +0100, Julia Lawall wrote:
> > OK.  Was the information in the outrechy tutorial sufficient?  If not, it
> > could be good to extend it.
> > 
> > julia
> >
> 
> Hey Julia!
> 
> I thought I should reply here too. I hope that is not a problem.
> 
> I had a hard time configuring mutt, from the information in the
> outreachy tutorial. I could send my patches but I had no idea how to
> respond to mails from INBOX and how to send inline replies.
> 

- After installing mutt and esmtprc, create two files "esmtprc" and "muttrc" in home directory.
	
	touch ~/.esmtprc
	chmod g-rwx ~/.esmtprc
	chmod o-rwx ~/.esmtprc
	touch ~/.muttrc
        chmod g-rwx ~/.muttrc
        chmod o-rwx ~/.muttrc

- Edit .esmtprc
	
	identity "my.email@gmail.com"
	hostname smtp.gmail.com:587
	username "my.email@gmail.com"
	password "<mailbox password>"
	starttls required 

- Open the ~/.muttrc
        - Add the information

                set sendmail="/usr/bin/esmtp"
                set envelope_from=yes
                set from="Your Name <my.email@gmail.com>"
                set use_from=yes
                set edit_headers=yes

                # IMAP settings
                set imap_user = "username@gmail.com"
                set imap_pass = "<mailbox password>"

                # SMTP settings
                set smtp_url = "smtps://username@smtp.gmail.com"
                set smtp_pass = "<mailbox password>"

                # Remote Gmail folders
                set folder = "imaps://imap.gmail.com/"
                set spoolfile = "+INBOX"
                set postponed = "+[Gmail]/Drafts"
                set record = "+[Gmail]/Sent Mail"
                set trash = "+[Gmail]/Trash"

        - Where the imap_pass, smtp_pass would be the App password or
          the mailbox password.

- To get the App password refer https://support.google.com/accounts/answer/185833?hl=en


Regards,

Sumitra



> Regards,
> Khadija
> 

Re: [PATCH] Staging: qlge: Fix indentation in conditional statement

[Khadija Kamran]

On Sun, Mar 12, 2023 at 10:31:12AM -0700, Sumitra Sharma wrote:
> On Sun, Mar 12, 2023 at 08:56:24PM +0500, Khadija Kamran wrote:
> > On Sun, Mar 12, 2023 at 04:31:48PM +0100, Julia Lawall wrote:
> > > OK.  Was the information in the outrechy tutorial sufficient?  If not, it
> > > could be good to extend it.
> > > 
> > > julia
> > >
> > 
> > Hey Julia!
> > 
> > I thought I should reply here too. I hope that is not a problem.
> > 
> > I had a hard time configuring mutt, from the information in the
> > outreachy tutorial. I could send my patches but I had no idea how to
> > respond to mails from INBOX and how to send inline replies.
> > 
> 
> - After installing mutt and esmtprc, create two files "esmtprc" and "muttrc" in home directory.
> 	
> 	touch ~/.esmtprc
> 	chmod g-rwx ~/.esmtprc
> 	chmod o-rwx ~/.esmtprc
> 	touch ~/.muttrc
>         chmod g-rwx ~/.muttrc
>         chmod o-rwx ~/.muttrc
> 
> - Edit .esmtprc
> 	
> 	identity "my.email@gmail.com"
> 	hostname smtp.gmail.com:587
> 	username "my.email@gmail.com"
> 	password "<mailbox password>"
> 	starttls required 
> 
> - Open the ~/.muttrc
>         - Add the information
> 
>                 set sendmail="/usr/bin/esmtp"
>                 set envelope_from=yes
>                 set from="Your Name <my.email@gmail.com>"
>                 set use_from=yes
>                 set edit_headers=yes
> 
>                 # IMAP settings
>                 set imap_user = "username@gmail.com"
>                 set imap_pass = "<mailbox password>"
> 
>                 # SMTP settings
>                 set smtp_url = "smtps://username@smtp.gmail.com"
>                 set smtp_pass = "<mailbox password>"
> 
>                 # Remote Gmail folders
>                 set folder = "imaps://imap.gmail.com/"
>                 set spoolfile = "+INBOX"
>                 set postponed = "+[Gmail]/Drafts"
>                 set record = "+[Gmail]/Sent Mail"
>                 set trash = "+[Gmail]/Trash"
> 
>         - Where the imap_pass, smtp_pass would be the App password or
>           the mailbox password.
> 
> - To get the App password refer https://support.google.com/accounts/answer/185833?hl=en
> 
>

Thank you so much Sumitra.
I had a hard time initially but I have already configured mutt. And I am
successfully communicating through this tool. :) 

> Regards,
> 
> Sumitra
> 
> 
> 
> > Regards,
> > Khadija
> >