From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Halaney <ahalaney@redhat.com>
Cc: linux-kernel@vger.kernel.org, agross@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
vkoul@kernel.org, bhupesh.sharma@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
richardcochran@gmail.com, linux@armlinux.org.uk,
veekhee@apple.com, tee.min.tan@linux.intel.com,
mohammad.athari.ismail@intel.com, jonathanh@nvidia.com,
ruppala@nvidia.com, bmasney@redhat.com,
andrey.konovalov@linaro.org, linux-arm-msm@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, ncai@quicinc.com,
jsuraj@qti.qualcomm.com, hisunil@quicinc.com
Subject: Re: [PATCH net-next 08/11] net: stmmac: Add EMAC3 variant of dwmac4
Date: Mon, 13 Mar 2023 17:39:04 -0700 [thread overview]
Message-ID: <20230313173904.3d611e83@kernel.org> (raw)
In-Reply-To: <20230313165620.128463-9-ahalaney@redhat.com>
On Mon, 13 Mar 2023 11:56:17 -0500 Andrew Halaney wrote:
> EMAC3 is a Qualcomm variant of dwmac4 that functions the same, but has a
> different address space layout for MTL and DMA registers. This makes the
> patch a bit more complicated than we would like so let's explain why the
> current approach was used.
Please drop all the static inlines in C sources, you're wrapping
a single function call, the compiler will do the right thing.
Please no more than 6 function arguments.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Halaney <ahalaney@redhat.com>
Cc: linux-kernel@vger.kernel.org, agross@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
vkoul@kernel.org, bhupesh.sharma@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
richardcochran@gmail.com, linux@armlinux.org.uk,
veekhee@apple.com, tee.min.tan@linux.intel.com,
mohammad.athari.ismail@intel.com, jonathanh@nvidia.com,
ruppala@nvidia.com, bmasney@redhat.com,
andrey.konovalov@linaro.org, linux-arm-msm@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, ncai@quicinc.com,
jsuraj@qti.qualcomm.com, hisunil@quicinc.com
Subject: Re: [PATCH net-next 08/11] net: stmmac: Add EMAC3 variant of dwmac4
Date: Mon, 13 Mar 2023 17:39:04 -0700 [thread overview]
Message-ID: <20230313173904.3d611e83@kernel.org> (raw)
In-Reply-To: <20230313165620.128463-9-ahalaney@redhat.com>
On Mon, 13 Mar 2023 11:56:17 -0500 Andrew Halaney wrote:
> EMAC3 is a Qualcomm variant of dwmac4 that functions the same, but has a
> different address space layout for MTL and DMA registers. This makes the
> patch a bit more complicated than we would like so let's explain why the
> current approach was used.
Please drop all the static inlines in C sources, you're wrapping
a single function call, the compiler will do the right thing.
Please no more than 6 function arguments.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-14 0:40 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 16:56 [PATCH net-next 00/11] Add EMAC3 support for sa8540p-ride Andrew Halaney
2023-03-13 16:56 ` Andrew Halaney
2023-03-13 16:56 ` [PATCH net-next 01/11] dt-bindings: net: snps,dwmac: Update interrupt-names Andrew Halaney
2023-03-13 16:56 ` Andrew Halaney
2023-03-16 7:13 ` Krzysztof Kozlowski
2023-03-16 7:13 ` Krzysztof Kozlowski
2023-03-16 16:15 ` Andrew Halaney
2023-03-16 16:15 ` Andrew Halaney
2023-03-16 19:20 ` Krzysztof Kozlowski
2023-03-16 19:20 ` Krzysztof Kozlowski
2023-03-13 16:56 ` [PATCH net-next 02/11] dt-bindings: net: snps,dwmac: Add Qualcomm Ethernet ETHQOS compatibles Andrew Halaney
2023-03-13 16:56 ` Andrew Halaney
2023-03-13 16:56 ` [PATCH net-next 03/11] dt-bindings: net: qcom,ethqos: Convert bindings to yaml Andrew Halaney
2023-03-13 16:56 ` Andrew Halaney
2023-03-16 7:18 ` Krzysztof Kozlowski
2023-03-16 7:18 ` Krzysztof Kozlowski
2023-03-13 16:56 ` [PATCH net-next 04/11] dt-bindings: net: qcom,ethqos: Add Qualcomm sc8280xp compatibles Andrew Halaney
2023-03-13 16:56 ` Andrew Halaney
2023-03-16 7:19 ` Krzysztof Kozlowski
2023-03-16 7:19 ` Krzysztof Kozlowski
2023-03-13 16:56 ` [PATCH net-next 05/11] clk: qcom: gcc-sc8280xp: Add EMAC GDSCs Andrew Halaney
2023-03-13 16:56 ` Andrew Halaney
2023-03-13 22:57 ` Stephen Boyd
2023-03-13 22:57 ` Stephen Boyd
2023-03-14 13:53 ` Andrew Halaney
2023-03-14 13:53 ` Andrew Halaney
2023-03-14 15:13 ` Konrad Dybcio
2023-03-14 15:13 ` Konrad Dybcio
2023-03-14 16:08 ` Andrew Halaney
2023-03-14 16:08 ` Andrew Halaney
2023-03-16 22:21 ` Andrew Halaney
2023-03-16 22:21 ` Andrew Halaney
2023-03-13 16:56 ` [PATCH net-next 06/11] arm64: dts: qcom: sc8280xp: Add ethernet nodes Andrew Halaney
2023-03-13 16:56 ` Andrew Halaney
2023-03-13 16:56 ` [PATCH net-next 07/11] arm64: dts: qcom: sa8540p-ride: " Andrew Halaney
2023-03-13 16:56 ` Andrew Halaney
2023-03-13 16:56 ` [PATCH net-next 08/11] net: stmmac: Add EMAC3 variant of dwmac4 Andrew Halaney
2023-03-13 16:56 ` Andrew Halaney
2023-03-14 0:39 ` Jakub Kicinski [this message]
2023-03-14 0:39 ` Jakub Kicinski
2023-03-16 18:36 ` Andrew Halaney
2023-03-16 18:36 ` Andrew Halaney
2023-03-16 18:52 ` Jakub Kicinski
2023-03-16 18:52 ` Jakub Kicinski
2023-03-16 23:01 ` Russell King (Oracle)
2023-03-16 23:01 ` Russell King (Oracle)
2023-03-16 23:18 ` Jakub Kicinski
2023-03-16 23:18 ` Jakub Kicinski
2023-03-14 0:59 ` Andrew Lunn
2023-03-14 0:59 ` Andrew Lunn
2023-03-13 16:56 ` [PATCH net-next 09/11] net: ethernet: stmmac: dwmac-qcom-ethqos: Respect phy-mode and TX delay Andrew Halaney
2023-03-13 16:56 ` Andrew Halaney
2023-03-13 16:56 ` [PATCH net-next 10/11] net: ethernet: stmmac: dwmac-qcom-ethqos: Use loopback_en for all speeds Andrew Halaney
2023-03-13 16:56 ` Andrew Halaney
2023-03-13 16:56 ` [PATCH net-next 11/11] net: stmmac: dwmac-qcom-ethqos: Add EMAC3 support Andrew Halaney
2023-03-13 16:56 ` Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313173904.3d611e83@kernel.org \
--to=kuba@kernel.org \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=bhupesh.sharma@linaro.org \
--cc=bmasney@redhat.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hisunil@quicinc.com \
--cc=joabreu@synopsys.com \
--cc=jonathanh@nvidia.com \
--cc=jsuraj@qti.qualcomm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=mohammad.athari.ismail@intel.com \
--cc=mturquette@baylibre.com \
--cc=ncai@quicinc.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ruppala@nvidia.com \
--cc=sboyd@kernel.org \
--cc=tee.min.tan@linux.intel.com \
--cc=veekhee@apple.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.