All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Ivan Bornyakov <i.bornyakov@metrotek.ru>
Cc: linux-imx@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] bus: imx-weim: fix branch condition evaluates to a garbage value
Date: Tue, 14 Mar 2023 11:44:58 +0800	[thread overview]
Message-ID: <20230314034458.GQ143566@dragon> (raw)
In-Reply-To: <20230306132526.8763-1-i.bornyakov@metrotek.ru>

On Mon, Mar 06, 2023 at 04:25:26PM +0300, Ivan Bornyakov wrote:
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
> 
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
> 
> Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
> Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> Cc: stable@vger.kernel.org
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

Ok, picked this version up instead.

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Ivan Bornyakov <i.bornyakov@metrotek.ru>
Cc: linux-imx@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] bus: imx-weim: fix branch condition evaluates to a garbage value
Date: Tue, 14 Mar 2023 11:44:58 +0800	[thread overview]
Message-ID: <20230314034458.GQ143566@dragon> (raw)
In-Reply-To: <20230306132526.8763-1-i.bornyakov@metrotek.ru>

On Mon, Mar 06, 2023 at 04:25:26PM +0300, Ivan Bornyakov wrote:
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
> 
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
> 
> Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
> Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> Cc: stable@vger.kernel.org
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

Ok, picked this version up instead.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-03-14  3:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06  6:05 [PATCH RESEND] bus: imx-weim: fix branch condition evaluates to a garbage value Ivan Bornyakov
2023-03-06  6:05 ` Ivan Bornyakov
2023-03-06 11:19 ` Fabio Estevam
2023-03-06 11:19   ` Fabio Estevam
2023-03-06 13:10 ` Ivan Bornyakov
2023-03-06 13:10   ` Ivan Bornyakov
2023-03-06 13:12   ` Fabio Estevam
2023-03-06 13:12     ` Fabio Estevam
2023-03-06 13:25 ` [PATCH v2] " Ivan Bornyakov
2023-03-06 13:25   ` Ivan Bornyakov
2023-03-13  6:10   ` Ivan Bornyakov
2023-03-13  6:10     ` Ivan Bornyakov
2023-03-14  3:44   ` Shawn Guo [this message]
2023-03-14  3:44     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230314034458.GQ143566@dragon \
    --to=shawnguo@kernel.org \
    --cc=festevam@gmail.com \
    --cc=i.bornyakov@metrotek.ru \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.