Re: [PATCH v11 1/2] arm64: dts: imx8mm-evkb: add support for i.MX8MM-EVKB

From: Shawn Guo <shawnguo@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Johannes Schneider <johannes.schneider@leica-geosystems.com>,
	devicetree@vger.kernel.org, Richard Zhu <hongxing.zhu@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v11 1/2] arm64: dts: imx8mm-evkb: add support for i.MX8MM-EVKB
Date: Tue, 14 Mar 2023 14:39:32 +0800	[thread overview]
Message-ID: <20230314063932.GR143566@dragon> (raw)
In-Reply-To: <20230307085747.mrqeoi4mkggby73o@pengutronix.de>

On Tue, Mar 07, 2023 at 09:57:47AM +0100, Marco Felsch wrote:
> Hi Shawn,
> 
> On 23-03-07, Shawn Guo wrote:
> > On Mon, Jan 30, 2023 at 06:25:52PM +0100, Johannes Schneider wrote:
> > > Add devicetree for the EVKB, which comes with LPDDR4 and a different
> > > PMIC.
> > > 
> > > The regulator min/max values are taken from the evk's schematic:
> > > 8MMINILPD4-CPU  SPF-31399_C2.pdf
> > > 
> > > Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
> > 
> > The patch doesn't compile at all (see below), so I took a closer look
> > and decided to drop the series.
> > 
> > > ---
> > >  arch/arm64/boot/dts/freescale/Makefile        |   1 +
> > >  arch/arm64/boot/dts/freescale/imx8mm-evkb.dts | 134 ++++++++++++++++++
> > >  2 files changed, 135 insertions(+)
> > >  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-evkb.dts
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > > index 3ea9edc87909..3bccc4d10928 100644
> > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > @@ -55,6 +55,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-data-modul-edm-sbc.dtb
> > >  dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> > >  dtb-$(CONFIG_ARCH_MXC) += imx8mm-emcon-avari.dtb
> > >  dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-evkb.dtb
> > 
> > I prefer to name it imx8mm-evk-revb.dtb or imx8mm-evk-b.dtb.
> 
> Unfortunately it's not revision B, it is evkb. The 'first' evk has
> plenty revisions. I think the most recent for the imx8mm-evk is C5. For
> the imx8mm-evkb the most recent revision is A4. Even this is not 100
> percent correct since the EVK consist of a SoM and a baseboard. The
> baseboard isn't changed for the EVKB but the SoM. The new SoM schematics
> name the new SoM 8MMINILPD4-CPU2. But in the end you can't buy it
> separately:
> - https://www.nxp.com/design/development-boards/i-mx-evaluation-and-development-boards/evaluation-kit-for-the-i-mx-8m-mini-applications-processor:8MMINILPD4-EVK

Ok, thanks for the information, Marco!

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel