All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: fix address length for LCDIF2
Date: Tue, 14 Mar 2023 14:46:45 +0800	[thread overview]
Message-ID: <20230314064645.GU143566@dragon> (raw)
In-Reply-To: <20230308092420.2742432-1-alexander.stein@ew.tq-group.com>

On Wed, Mar 08, 2023 at 10:24:19AM +0100, Alexander Stein wrote:
> 0x238 is the offset for PANIC0_THRES, so the length needs to be 4 bytes
> greater than that.
> 
> Fixes: 94e6197dadc9 ("arm64: dts: imx8mp: Add LCDIF2 & LDB nodes")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Does it make sense to increase the length to 0x10000 instead which
> is the size mentioned in the memory map in the RM?

Makes sense to me.

Shawn

> 
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index a19224fe1a6a..722e36d7b420 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1128,7 +1128,7 @@ aips4: bus@32c00000 {
>  
>  			lcdif2: display-controller@32e90000 {
>  				compatible = "fsl,imx8mp-lcdif";
> -				reg = <0x32e90000 0x238>;
> +				reg = <0x32e90000 0x23c>;
>  				interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX8MP_CLK_MEDIA_DISP2_PIX_ROOT>,
>  					 <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>,
> -- 
> 2.34.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: fix address length for LCDIF2
Date: Tue, 14 Mar 2023 14:46:45 +0800	[thread overview]
Message-ID: <20230314064645.GU143566@dragon> (raw)
In-Reply-To: <20230308092420.2742432-1-alexander.stein@ew.tq-group.com>

On Wed, Mar 08, 2023 at 10:24:19AM +0100, Alexander Stein wrote:
> 0x238 is the offset for PANIC0_THRES, so the length needs to be 4 bytes
> greater than that.
> 
> Fixes: 94e6197dadc9 ("arm64: dts: imx8mp: Add LCDIF2 & LDB nodes")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Does it make sense to increase the length to 0x10000 instead which
> is the size mentioned in the memory map in the RM?

Makes sense to me.

Shawn

> 
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index a19224fe1a6a..722e36d7b420 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1128,7 +1128,7 @@ aips4: bus@32c00000 {
>  
>  			lcdif2: display-controller@32e90000 {
>  				compatible = "fsl,imx8mp-lcdif";
> -				reg = <0x32e90000 0x238>;
> +				reg = <0x32e90000 0x23c>;
>  				interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX8MP_CLK_MEDIA_DISP2_PIX_ROOT>,
>  					 <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>,
> -- 
> 2.34.1
> 

  reply	other threads:[~2023-03-14  6:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08  9:24 [PATCH 1/1] arm64: dts: imx8mp: fix address length for LCDIF2 Alexander Stein
2023-03-08  9:24 ` Alexander Stein
2023-03-14  6:46 ` Shawn Guo [this message]
2023-03-14  6:46   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230314064645.GU143566@dragon \
    --to=shawnguo@kernel.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.