From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH 1/5] nvmet: Fix identify Namespace handling
Date: Wed, 15 Mar 2023 14:35:08 +0100 [thread overview]
Message-ID: <20230315133508.GA24915@lst.de> (raw)
In-Reply-To: <20230315105939.305825-2-damien.lemoal@opensource.wdc.com>
On Wed, Mar 15, 2023 at 07:59:35PM +0900, Damien Le Moal wrote:
> The identify command with cns set to NVME_ID_CNS_NS does not directly
> depend on the command set. The NVMe specifications is rather confusing
> here as it appears that this command only applies to the NVM command
> set. However, footnote 8 of Figure 273 in the NVMe 2.0 base
> specifications clearly state that this command applies to NVM command
> sets that support logical blocks, that is, NVM and ZNS. Both the NVM and
> ZNS command set specifications also list this identify as mandatory.
>
> The command handling should thus not look at the csi field since it is
> defined as unused for this command. Given that we do not support the
> KV command set, simply remove the csi switch-case for that command
> handling and call directly nvmet_execute_identify_ns() in
> nvmet_execute_identify().
Yes, this CNS value pre-dates the addition of the CSI value,
and thus CSI should be ignored.
next prev parent reply other threads:[~2023-03-15 13:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 10:59 [PATCH 0/5] Fix nvme target identify command handling Damien Le Moal
2023-03-15 10:59 ` [PATCH 1/5] nvmet: Fix identify Namespace handling Damien Le Moal
2023-03-15 13:35 ` Christoph Hellwig [this message]
2023-03-15 10:59 ` [PATCH 2/5] nvmet: Fix Identify Controller handling Damien Le Moal
2023-03-15 13:35 ` Christoph Hellwig
2023-03-15 10:59 ` [PATCH 3/5] nvmet: Fix Identify Active Namespace ID list handling Damien Le Moal
2023-03-15 10:59 ` [PATCH 4/5] nvmet: Fix I/O Command Set specific Identify Controller Damien Le Moal
2023-03-15 13:38 ` Christoph Hellwig
2023-03-15 23:38 ` Damien Le Moal
2023-03-15 10:59 ` [PATCH 5/5] nvmet: Cleanup nvmet_execute_identify() Damien Le Moal
2023-03-15 13:38 ` Christoph Hellwig
2023-03-15 14:07 ` [PATCH 0/5] Fix nvme target identify command handling Christoph Hellwig
2023-03-15 22:50 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315133508.GA24915@lst.de \
--to=hch@lst.de \
--cc=damien.lemoal@opensource.wdc.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.