From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH 2/5] nvmet: Fix Identify Controller handling
Date: Wed, 15 Mar 2023 14:35:26 +0100 [thread overview]
Message-ID: <20230315133526.GB24915@lst.de> (raw)
In-Reply-To: <20230315105939.305825-3-damien.lemoal@opensource.wdc.com>
On Wed, Mar 15, 2023 at 07:59:36PM +0900, Damien Le Moal wrote:
> The identify command with cns set to NVME_ID_CNS_CTRL does not depend on
> the command set. The execution of this command should thus not look at
> the csi specified in the command. Simplify nvmet_execute_identify() to
> directly call nvmet_execute_identify_ctrl() without the csi switch-case.
Indeed - same as the last one.
next prev parent reply other threads:[~2023-03-15 13:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 10:59 [PATCH 0/5] Fix nvme target identify command handling Damien Le Moal
2023-03-15 10:59 ` [PATCH 1/5] nvmet: Fix identify Namespace handling Damien Le Moal
2023-03-15 13:35 ` Christoph Hellwig
2023-03-15 10:59 ` [PATCH 2/5] nvmet: Fix Identify Controller handling Damien Le Moal
2023-03-15 13:35 ` Christoph Hellwig [this message]
2023-03-15 10:59 ` [PATCH 3/5] nvmet: Fix Identify Active Namespace ID list handling Damien Le Moal
2023-03-15 10:59 ` [PATCH 4/5] nvmet: Fix I/O Command Set specific Identify Controller Damien Le Moal
2023-03-15 13:38 ` Christoph Hellwig
2023-03-15 23:38 ` Damien Le Moal
2023-03-15 10:59 ` [PATCH 5/5] nvmet: Cleanup nvmet_execute_identify() Damien Le Moal
2023-03-15 13:38 ` Christoph Hellwig
2023-03-15 14:07 ` [PATCH 0/5] Fix nvme target identify command handling Christoph Hellwig
2023-03-15 22:50 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315133526.GB24915@lst.de \
--to=hch@lst.de \
--cc=damien.lemoal@opensource.wdc.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.