[PATCH] Correct documentation errors in nf_tables.h

[PATCH] Correct documentation errors in nf_tables.h

[Matthieu De Beule]

For NFTA_RANGE_OP incorrectly said it was a nft_cmp_ops instead of nft_range_ops
NFTA_LOG_GROUP and NFTA_LOG_QTHRESHOLD were documented as NLA_U32 instead of NLA_U16
---
 include/uapi/linux/netfilter/nf_tables.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/uapi/linux/netfilter/nf_tables.h b/include/uapi/linux/netfilter/nf_tables.h
index 466fd3f4447c..71ddb0562e67 100644
--- a/include/uapi/linux/netfilter/nf_tables.h
+++ b/include/uapi/linux/netfilter/nf_tables.h
@@ -669,7 +669,7 @@ enum nft_range_ops {
  * enum nft_range_attributes - nf_tables range expression netlink attributes
  *
  * @NFTA_RANGE_SREG: source register of data to compare (NLA_U32: nft_registers)
- * @NFTA_RANGE_OP: cmp operation (NLA_U32: nft_cmp_ops)
+ * @NFTA_RANGE_OP: cmp operation (NLA_U32: nft_range_ops)
  * @NFTA_RANGE_FROM_DATA: data range from (NLA_NESTED: nft_data_attributes)
  * @NFTA_RANGE_TO_DATA: data range to (NLA_NESTED: nft_data_attributes)
  */
@@ -1217,10 +1217,10 @@ enum nft_last_attributes {
 /**
  * enum nft_log_attributes - nf_tables log expression netlink attributes
  *
- * @NFTA_LOG_GROUP: netlink group to send messages to (NLA_U32)
+ * @NFTA_LOG_GROUP: netlink group to send messages to (NLA_U16)
  * @NFTA_LOG_PREFIX: prefix to prepend to log messages (NLA_STRING)
  * @NFTA_LOG_SNAPLEN: length of payload to include in netlink message (NLA_U32)
- * @NFTA_LOG_QTHRESHOLD: queue threshold (NLA_U32)
+ * @NFTA_LOG_QTHRESHOLD: queue threshold (NLA_U16)
  * @NFTA_LOG_LEVEL: log level (NLA_U32)
  * @NFTA_LOG_FLAGS: logging flags (NLA_U32)
  */
--
2.38.4

Re: [PATCH] Correct documentation errors in nf_tables.h

[Florian Westphal]

Matthieu De Beule <matthieu.debeule@proton.ch> wrote:

Subject should have '[PATCH nf-next] netfilter: ' prefix.

> For NFTA_RANGE_OP incorrectly said it was a nft_cmp_ops instead of nft_range_ops
> NFTA_LOG_GROUP and NFTA_LOG_QTHRESHOLD were documented as NLA_U32 instead of NLA_U16

scripts/checkpatch.pl 0001*
ERROR: Missing Signed-off-by: line by nominal patch author 'Matthieu De Beule <matthieu.debeule@proton.ch>'

Please fix this up and send a v2.