[djwong-xfs:xfile-page-caching 272/274] fs/xfs/xfs_buf.c:327 xfs_buf_free() warn: bitwise AND condition is false here

[djwong-xfs:xfile-page-caching 272/274] fs/xfs/xfs_buf.c:327 xfs_buf_free() warn: bitwise AND condition is false here

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: "Darrick J. Wong" <darrick.wong@oracle.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git xfile-page-caching
head:   67bb67e9a9941400f950d75d77991bf99c54ed05
commit: 6e9bb84130cdd2e0e6b8edbb639eed401bbcd4f7 [272/274] xfs: map xfile pages directly into xfs_buf
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: ia64-randconfig-m031-20230312 (https://download.01.org/0day-ci/archive/20230317/202303172342.ADsIQSWr-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202303172342.ADsIQSWr-lkp@intel.com/

New smatch warnings:
fs/xfs/xfs_buf.c:327 xfs_buf_free() warn: bitwise AND condition is false here

Old smatch warnings:
fs/xfs/xfs_buf.c:794 xfs_buf_get_map() error: we previously assumed 'bp' could be null (see line 776)
fs/xfs/xfs_buf.c:1701 _xfs_buf_ioapply() warn: bitwise AND condition is false here
fs/xfs/xfs_buf.c:2075 xfs_free_buftarg() warn: bitwise AND condition is false here
fs/xfs/xfs_buf.c:2558 xfs_buftarg_nr_sectors() warn: bitwise AND condition is false here

vim +327 fs/xfs/xfs_buf.c

298f3422450663 fs/xfs/xfs_buf.c           Dave Chinner      2022-07-14  315  
25a409572b5f6e fs/xfs/xfs_buf.c           Christoph Hellwig 2019-10-24  316  static void
ce8e922c0e79c8 fs/xfs/linux-2.6/xfs_buf.c Nathan Scott      2006-01-11  317  xfs_buf_free(
e82226138b20d4 fs/xfs/xfs_buf.c           Dave Chinner      2020-12-16  318  	struct xfs_buf		*bp)
^1da177e4c3f41 fs/xfs/linux-2.6/xfs_buf.c Linus Torvalds    2005-04-16  319  {
0b1b213fcf3a84 fs/xfs/linux-2.6/xfs_buf.c Christoph Hellwig 2009-12-14  320  	trace_xfs_buf_free(bp, _RET_IP_);
^1da177e4c3f41 fs/xfs/linux-2.6/xfs_buf.c Linus Torvalds    2005-04-16  321  
430cbeb86fdcbb fs/xfs/linux-2.6/xfs_buf.c Dave Chinner      2010-12-02  322  	ASSERT(list_empty(&bp->b_lru));
430cbeb86fdcbb fs/xfs/linux-2.6/xfs_buf.c Dave Chinner      2010-12-02  323  
6e9bb84130cdd2 fs/xfs/xfs_buf.c           Darrick J. Wong   2023-03-06  324  	if (xfs_buf_is_vmapped(bp))
6e9bb84130cdd2 fs/xfs/xfs_buf.c           Darrick J. Wong   2023-03-06  325  		vm_unmap_ram(bp->b_addr, bp->b_page_count);
6e9bb84130cdd2 fs/xfs/xfs_buf.c           Darrick J. Wong   2023-03-06  326  
6e9bb84130cdd2 fs/xfs/xfs_buf.c           Darrick J. Wong   2023-03-06 @327  	if (bp->b_flags & _XBF_DIRECT_MAP)
6e9bb84130cdd2 fs/xfs/xfs_buf.c           Darrick J. Wong   2023-03-06  328  		xfile_buf_unmap_pages(bp);
6e9bb84130cdd2 fs/xfs/xfs_buf.c           Darrick J. Wong   2023-03-06  329  	else if (bp->b_flags & _XBF_PAGES)
e7d236a6fe5102 fs/xfs/xfs_buf.c           Dave Chinner      2021-06-01  330  		xfs_buf_free_pages(bp);
e7d236a6fe5102 fs/xfs/xfs_buf.c           Dave Chinner      2021-06-01  331  	else if (bp->b_flags & _XBF_KMEM)
0e6e847ffe3743 fs/xfs/linux-2.6/xfs_buf.c Dave Chinner      2011-03-26  332  		kmem_free(bp->b_addr);
e7d236a6fe5102 fs/xfs/xfs_buf.c           Dave Chinner      2021-06-01  333  
298f3422450663 fs/xfs/xfs_buf.c           Dave Chinner      2022-07-14  334  	call_rcu(&bp->b_rcu, xfs_buf_free_callback);
^1da177e4c3f41 fs/xfs/linux-2.6/xfs_buf.c Linus Torvalds    2005-04-16  335  }
^1da177e4c3f41 fs/xfs/linux-2.6/xfs_buf.c Linus Torvalds    2005-04-16  336  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests