[Buildroot] [PATCH 1/1] package/shadow: fix libsemanage dependency

[Buildroot] [PATCH 1/1] package/shadow: fix libsemanage dependency

[Fabrice Fontaine]

Fix the following build failure raised since the addition of the package
in commit f78c5cb5cae93a9e63dad4361d78e1787759382f:

Makefile:576: *** libsemanage is in the dependency chain of shadow that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.

Fixes:
 - http://autobuild.buildroot.org/results/e528e07874815d7f1cb951084ec985d76fe22d2e

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/shadow/shadow.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/shadow/shadow.mk b/package/shadow/shadow.mk
index d8f913a648..4bc3cce037 100644
--- a/package/shadow/shadow.mk
+++ b/package/shadow/shadow.mk
@@ -87,7 +87,7 @@ else
 SHADOW_CONF_OPTS += --without-libcrack
 endif
 
-ifeq ($(BR2_PACKAGE_LIBSELINUX),y)
+ifeq ($(BR2_PACKAGE_LIBSELINUX)$(BR2_PACKAGE_LIBSEMANAGE),yy)
 SHADOW_CONF_OPTS += --with-selinux
 SHADOW_DEPENDENCIES += libselinux libsemanage
 else
-- 
2.39.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/shadow: fix libsemanage dependency

[Raphael Pavlidis]

Hi Frabrice,
thanks for the fix. The patch looks good for me.

Besides that, should I not get an email if a build fails in a package, whom I am the developer in DEVELOPERS file?

Thanks,
Raphael Pavlidis

18.03.2023 13:30:13 Fabrice Fontaine <fontaine.fabrice@gmail.com>:

> Fix the following build failure raised since the addition of the package
> in commit f78c5cb5cae93a9e63dad4361d78e1787759382f:
> 
> Makefile:576: *** libsemanage is in the dependency chain of shadow that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.
> 
> Fixes:
> - http://autobuild.buildroot.org/results/e528e07874815d7f1cb951084ec985d76fe22d2e
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/shadow/shadow.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/shadow/shadow.mk b/package/shadow/shadow.mk
> index d8f913a648..4bc3cce037 100644
> --- a/package/shadow/shadow.mk
> +++ b/package/shadow/shadow.mk
> @@ -87,7 +87,7 @@ else
> SHADOW_CONF_OPTS += --without-libcrack
> endif
> 
> -ifeq ($(BR2_PACKAGE_LIBSELINUX),y)
> +ifeq ($(BR2_PACKAGE_LIBSELINUX)$(BR2_PACKAGE_LIBSEMANAGE),yy)
> SHADOW_CONF_OPTS += --with-selinux
> SHADOW_DEPENDENCIES += libselinux libsemanage
> else
> -- 
> 2.39.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/shadow: fix libsemanage dependency

[Thomas Petazzoni via buildroot]

Hello Raphael,

On Sat, 18 Mar 2023 18:52:27 +0100 (GMT+01:00)
Raphael Pavlidis <raphael.pavlidis@gmail.com> wrote:

> Besides that, should I not get an email if a build fails in a
> package, whom I am the developer in DEVELOPERS file?

In general, yes. Except here the failure (see
http://autobuild.buildroot.org/results/e528e07874815d7f1cb951084ec985d76fe22d2e/build-end.log)
looks like this:

make: Entering directory '/tmp/instance-11/buildroot'
Makefile:576: *** libsemanage is in the dependency chain of shadow that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.
make: Leaving directory '/tmp/instance-11/buildroot'

and the autobuild script does not have logic to interpret that as
"shadow has an issue", so this build failure is classified as having an
"unknown" failure reason.

The autobuild script is able to detect the failing package when the end
of the error log looks like this:

make[1]: Leaving directory '/home/thomas/autobuild/instance-1/output-1/build/bluez5_utils-5.66'
make: *** [package/pkg-generic.mk:293: /home/thomas/autobuild/instance-1/output-1/build/bluez5_utils-5.66/.stamp_built] Error 2
make: Leaving directory '/home/thomas/autobuild/instance-1/buildroot'

Of course, this logic could be improved to also understand the "XYZ is
in the dependency chain of ABC...". If you're curious, the logic is at
https://gitlab.com/buildroot.org/buildroot-test/-/blob/master/web/import.inc.php#L244.
WARNING: ugly PHP code behind this link, make sure to wear appropriate
eye protection equipment before clicking the link and reading the code.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/shadow: fix libsemanage dependency

[Thomas Petazzoni via buildroot]

On Sat, 18 Mar 2023 13:30:10 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following build failure raised since the addition of the package
> in commit f78c5cb5cae93a9e63dad4361d78e1787759382f:
> 
> Makefile:576: *** libsemanage is in the dependency chain of shadow that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e528e07874815d7f1cb951084ec985d76fe22d2e
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/shadow/shadow.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot