From: Rob Herring <robh@kernel.org>
To: Russell King <linux@armlinux.org.uk>, Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] video: ARM CLCD: Use of_address_to_resource()
Date: Sun, 19 Mar 2023 11:32:41 -0500 [thread overview]
Message-ID: <20230319163241.226984-1-robh@kernel.org> (raw)
Replace of_get_address() and of_translate_address() with single call
to of_address_to_resource(). With this, use ioremap() instead of
of_iomap() which would parse "reg" a second time.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/video/fbdev/amba-clcd.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
index f65c96d1394d..1289bfe6e872 100644
--- a/drivers/video/fbdev/amba-clcd.c
+++ b/drivers/video/fbdev/amba-clcd.c
@@ -759,7 +759,7 @@ static int clcdfb_of_vram_setup(struct clcd_fb *fb)
{
int err;
struct device_node *memory;
- u64 size;
+ struct resource res;
err = clcdfb_of_init_display(fb);
if (err)
@@ -769,18 +769,20 @@ static int clcdfb_of_vram_setup(struct clcd_fb *fb)
if (!memory)
return -ENODEV;
- fb->fb.screen_base = of_iomap(memory, 0);
- if (!fb->fb.screen_base) {
- of_node_put(memory);
- return -ENOMEM;
- }
- fb->fb.fix.smem_start = of_translate_address(memory,
- of_get_address(memory, 0, &size, NULL));
- fb->fb.fix.smem_len = size;
- of_node_put(memory);
+ err = of_address_to_resource(memory, 0, &res);
+ if (err)
+ goto out;
- return 0;
+ fb->fb.screen_base = ioremap(res.start, resource_size(&res));
+ if (!fb->fb.screen_base)
+ goto out;
+
+ fb->fb.fix.smem_start = res.start;
+ fb->fb.fix.smem_len = resource_size(&res);
+out:
+ of_node_put(memory);
+ return err;
}
static int clcdfb_of_vram_mmap(struct clcd_fb *fb, struct vm_area_struct *vma)
--
2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Russell King <linux@armlinux.org.uk>, Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: [PATCH] video: ARM CLCD: Use of_address_to_resource()
Date: Sun, 19 Mar 2023 11:32:41 -0500 [thread overview]
Message-ID: <20230319163241.226984-1-robh@kernel.org> (raw)
Replace of_get_address() and of_translate_address() with single call
to of_address_to_resource(). With this, use ioremap() instead of
of_iomap() which would parse "reg" a second time.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/video/fbdev/amba-clcd.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
index f65c96d1394d..1289bfe6e872 100644
--- a/drivers/video/fbdev/amba-clcd.c
+++ b/drivers/video/fbdev/amba-clcd.c
@@ -759,7 +759,7 @@ static int clcdfb_of_vram_setup(struct clcd_fb *fb)
{
int err;
struct device_node *memory;
- u64 size;
+ struct resource res;
err = clcdfb_of_init_display(fb);
if (err)
@@ -769,18 +769,20 @@ static int clcdfb_of_vram_setup(struct clcd_fb *fb)
if (!memory)
return -ENODEV;
- fb->fb.screen_base = of_iomap(memory, 0);
- if (!fb->fb.screen_base) {
- of_node_put(memory);
- return -ENOMEM;
- }
- fb->fb.fix.smem_start = of_translate_address(memory,
- of_get_address(memory, 0, &size, NULL));
- fb->fb.fix.smem_len = size;
- of_node_put(memory);
+ err = of_address_to_resource(memory, 0, &res);
+ if (err)
+ goto out;
- return 0;
+ fb->fb.screen_base = ioremap(res.start, resource_size(&res));
+ if (!fb->fb.screen_base)
+ goto out;
+
+ fb->fb.fix.smem_start = res.start;
+ fb->fb.fix.smem_len = resource_size(&res);
+out:
+ of_node_put(memory);
+ return err;
}
static int clcdfb_of_vram_mmap(struct clcd_fb *fb, struct vm_area_struct *vma)
--
2.39.2
next reply other threads:[~2023-03-19 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 16:32 Rob Herring [this message]
2023-03-19 16:32 ` [PATCH] video: ARM CLCD: Use of_address_to_resource() Rob Herring
2023-03-19 17:27 ` Helge Deller
2023-03-19 17:27 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230319163241.226984-1-robh@kernel.org \
--to=robh@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.