From: "Michael S. Tsirkin" <mst@redhat.com>
To: michael.christie@oracle.com
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
stefanha@redhat.com, jasowang@redhat.com, sgarzare@redhat.com,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 0/7] vhost-scsi: Fix crashes and management op hangs
Date: Tue, 21 Mar 2023 03:12:40 -0400 [thread overview]
Message-ID: <20230321031147-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <e1a96cd4-e520-caf5-7d5f-1de270c4fecb@oracle.com>
On Mon, Mar 20, 2023 at 09:29:50PM -0500, michael.christie@oracle.com wrote:
> On 3/20/23 9:06 PM, Mike Christie wrote:
> > The following patches were made over Linus tree.
>
> Hi Michael, I see you merged my first version of the patchset in your
> vhost branch.
>
> Do you want me to just send a followup patchset?
>
> The major diff between the 2 versions:
>
> 1. I added the first 2 patches which fix some bugs in the existing code
> I found while doing some code review and testing another LIO patchset
> plus v1.
>
> Note: The other day I posted that I thought the 3rd patch in v1 caused
> the bugs but they were already in the code.
>
> 2. In v2 I made one of the patches not need the vhost device lock when
> unmapping/mapping LUNs, so you can add new LUNs even if one LUN on the same
> vhost_scsi device was hung.
>
> Since it's not regressions with the existing patches, I can just send those
> as a followup patchset if that's preferred.
It's ok, I will drop v1 and replace it with v2.
Do you feel any of this is needed in this release?
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: michael.christie@oracle.com
Cc: linux-scsi@vger.kernel.org,
virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org, stefanha@redhat.com
Subject: Re: [PATCH v2 0/7] vhost-scsi: Fix crashes and management op hangs
Date: Tue, 21 Mar 2023 03:12:40 -0400 [thread overview]
Message-ID: <20230321031147-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <e1a96cd4-e520-caf5-7d5f-1de270c4fecb@oracle.com>
On Mon, Mar 20, 2023 at 09:29:50PM -0500, michael.christie@oracle.com wrote:
> On 3/20/23 9:06 PM, Mike Christie wrote:
> > The following patches were made over Linus tree.
>
> Hi Michael, I see you merged my first version of the patchset in your
> vhost branch.
>
> Do you want me to just send a followup patchset?
>
> The major diff between the 2 versions:
>
> 1. I added the first 2 patches which fix some bugs in the existing code
> I found while doing some code review and testing another LIO patchset
> plus v1.
>
> Note: The other day I posted that I thought the 3rd patch in v1 caused
> the bugs but they were already in the code.
>
> 2. In v2 I made one of the patches not need the vhost device lock when
> unmapping/mapping LUNs, so you can add new LUNs even if one LUN on the same
> vhost_scsi device was hung.
>
> Since it's not regressions with the existing patches, I can just send those
> as a followup patchset if that's preferred.
It's ok, I will drop v1 and replace it with v2.
Do you feel any of this is needed in this release?
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-03-21 7:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 2:06 [PATCH v2 0/7] vhost-scsi: Fix crashes and management op hangs Mike Christie
2023-03-21 2:06 ` Mike Christie
2023-03-21 2:06 ` [PATCH v2 1/7] vhost-scsi: Fix vhost_scsi struct use after free Mike Christie
2023-03-21 2:06 ` Mike Christie
2023-03-21 2:06 ` [PATCH v2 2/7] vhost-scsi: Fix crash during LUN unmapping Mike Christie
2023-03-21 2:06 ` Mike Christie
2023-03-21 2:06 ` [PATCH v2 3/7] vhost-scsi: Delay releasing our refcount on the tpg Mike Christie
2023-03-21 2:06 ` Mike Christie
2023-03-21 2:06 ` [PATCH v2 4/7] vhost-scsi: Drop device mutex use in vhost_scsi_do_plug Mike Christie
2023-03-21 2:06 ` Mike Christie
2023-03-21 2:06 ` [PATCH v2 5/7] vhost-scsi: Check for a cleared backend before queueing an event Mike Christie
2023-03-21 2:06 ` Mike Christie
2023-03-21 2:06 ` [PATCH v2 6/7] vhost-scsi: Drop vhost_scsi_mutex use in port callouts Mike Christie
2023-03-21 2:06 ` Mike Christie
2023-03-21 2:06 ` [PATCH v2 7/7] vhost-scsi: Reduce vhost_scsi_mutex use Mike Christie
2023-03-21 2:06 ` Mike Christie
2023-03-21 2:29 ` [PATCH v2 0/7] vhost-scsi: Fix crashes and management op hangs michael.christie
2023-03-21 2:29 ` michael.christie
2023-03-21 7:12 ` Michael S. Tsirkin [this message]
2023-03-21 7:12 ` Michael S. Tsirkin
2023-03-21 17:25 ` Mike Christie
2023-03-21 17:25 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321031147-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.