From: Lee Jones <lee@kernel.org>
To: cy_huang@richtek.com
Cc: pavel@ucw.cz, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, chiaen_wu@richtek.com,
jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] leds: rgb: mt6370: Fix implicit declaration for FIELD_GET
Date: Wed, 22 Mar 2023 15:28:20 +0000 [thread overview]
Message-ID: <20230322152820.GG2673958@google.com> (raw)
In-Reply-To: <1679067760-19098-1-git-send-email-cy_huang@richtek.com>
On Fri, 17 Mar 2023, cy_huang@richtek.com wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> 0-DAY CI Kernel Test Service reported the implicit declaration error below:
>
> drivers/leds/rgb/leds-mt6370-rgb.c: In function'mt6370_check_vendor_info':
> >> drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration
> of function 'FIELD_GET' [-Werror=implicit-function-declaration]
> 889 | vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
> |
>
> Add the missing header 'bitfield.h' to fix it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202303171729.CcgyFx17-lkp@intel.com/
> Fixes: 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> drivers/leds/rgb/leds-mt6370-rgb.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks
--
Lee Jones [李琼斯]
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: cy_huang@richtek.com
Cc: pavel@ucw.cz, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, chiaen_wu@richtek.com,
jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] leds: rgb: mt6370: Fix implicit declaration for FIELD_GET
Date: Wed, 22 Mar 2023 15:28:20 +0000 [thread overview]
Message-ID: <20230322152820.GG2673958@google.com> (raw)
In-Reply-To: <1679067760-19098-1-git-send-email-cy_huang@richtek.com>
On Fri, 17 Mar 2023, cy_huang@richtek.com wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> 0-DAY CI Kernel Test Service reported the implicit declaration error below:
>
> drivers/leds/rgb/leds-mt6370-rgb.c: In function'mt6370_check_vendor_info':
> >> drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration
> of function 'FIELD_GET' [-Werror=implicit-function-declaration]
> 889 | vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
> |
>
> Add the missing header 'bitfield.h' to fix it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202303171729.CcgyFx17-lkp@intel.com/
> Fixes: 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> drivers/leds/rgb/leds-mt6370-rgb.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-22 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 15:42 [PATCH] leds: rgb: mt6370: Fix implicit declaration for FIELD_GET cy_huang
2023-03-17 15:42 ` cy_huang
2023-03-22 15:28 ` Lee Jones [this message]
2023-03-22 15:28 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322152820.GG2673958@google.com \
--to=lee@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chiaen_wu@richtek.com \
--cc=cy_huang@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.