From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Mickaël Salaün" <mic@digikod.net>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Pali Rohár" <pali@kernel.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
"Juergen Gross" <jgross@suse.com>,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v6 2/4] PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource()
Date: Wed, 22 Mar 2023 14:35:25 -0500 [thread overview]
Message-ID: <20230322193525.GA2487882@bhelgaas> (raw)
In-Reply-To: <20230320131633.61680-3-andriy.shevchenko@linux.intel.com>
On Mon, Mar 20, 2023 at 03:16:31PM +0200, Andy Shevchenko wrote:
> ...
> -#define pci_bus_for_each_resource(bus, res, i) \
> - for (i = 0; \
> - (res = pci_bus_resource_n(bus, i)) || i < PCI_BRIDGE_RESOURCE_NUM; \
> - i++)
> +#define __pci_bus_for_each_resource(bus, res, __i, vartype) \
> + for (vartype __i = 0; \
> + res = pci_bus_resource_n(bus, __i), __i < PCI_BRIDGE_RESOURCE_NUM; \
> + __i++)
> +
> +#define pci_bus_for_each_resource(bus, res, i) \
> + __pci_bus_for_each_resource(bus, res, i, )
> +
> +#define pci_bus_for_each_resource_p(bus, res) \
> + __pci_bus_for_each_resource(bus, res, __i, unsigned int)
I like these changes a lot, too!
Same comments about _p vs _idx and __pci_bus_for_each_resource(...,
vartype).
Also would prefer 80 char max instead of 81.
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Mickaël Salaün" <mic@digikod.net>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Pali Rohár" <pali@kernel.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
"Juergen Gross" <jgross@suse.com>,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-pci@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org,
"Miguel Ojeda" <ojeda@kernel.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
"Matt Turner" <mattst88@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Anatolij Gustschin" <agust@denx.de>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Rich Felker" <dalias@libc.org>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"David S. Miller" <davem@davemloft.net>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>
Subject: Re: [PATCH v6 2/4] PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource()
Date: Wed, 22 Mar 2023 14:35:25 -0500 [thread overview]
Message-ID: <20230322193525.GA2487882@bhelgaas> (raw)
In-Reply-To: <20230320131633.61680-3-andriy.shevchenko@linux.intel.com>
On Mon, Mar 20, 2023 at 03:16:31PM +0200, Andy Shevchenko wrote:
> ...
> -#define pci_bus_for_each_resource(bus, res, i) \
> - for (i = 0; \
> - (res = pci_bus_resource_n(bus, i)) || i < PCI_BRIDGE_RESOURCE_NUM; \
> - i++)
> +#define __pci_bus_for_each_resource(bus, res, __i, vartype) \
> + for (vartype __i = 0; \
> + res = pci_bus_resource_n(bus, __i), __i < PCI_BRIDGE_RESOURCE_NUM; \
> + __i++)
> +
> +#define pci_bus_for_each_resource(bus, res, i) \
> + __pci_bus_for_each_resource(bus, res, i, )
> +
> +#define pci_bus_for_each_resource_p(bus, res) \
> + __pci_bus_for_each_resource(bus, res, __i, unsigned int)
I like these changes a lot, too!
Same comments about _p vs _idx and __pci_bus_for_each_resource(...,
vartype).
Also would prefer 80 char max instead of 81.
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
"Rich Felker" <dalias@libc.org>,
linux-sh@vger.kernel.org, linux-pci@vger.kernel.org,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
linux-mips@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Andrew Lunn" <andrew@lunn.ch>,
sparclinux@vger.kernel.org,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-acpi@vger.kernel.org, "Miguel Ojeda" <ojeda@kernel.org>,
xen-devel@lists.xenproject.org,
"Matt Turner" <mattst88@gmail.com>,
"Anatolij Gustschin" <agust@denx.de>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"Mickaël Salaün" <mic@digikod.net>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
"Juergen Gross" <jgross@suse.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
linuxppc-dev@lists.ozlabs.org,
"Randy Dunlap" <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>,
linux-alpha@vger.kernel.org, "Pali Rohár" <pali@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Maciej W. Rozycki" <macro@orcam.me.uk>
Subject: Re: [PATCH v6 2/4] PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource()
Date: Wed, 22 Mar 2023 14:35:25 -0500 [thread overview]
Message-ID: <20230322193525.GA2487882@bhelgaas> (raw)
In-Reply-To: <20230320131633.61680-3-andriy.shevchenko@linux.intel.com>
On Mon, Mar 20, 2023 at 03:16:31PM +0200, Andy Shevchenko wrote:
> ...
> -#define pci_bus_for_each_resource(bus, res, i) \
> - for (i = 0; \
> - (res = pci_bus_resource_n(bus, i)) || i < PCI_BRIDGE_RESOURCE_NUM; \
> - i++)
> +#define __pci_bus_for_each_resource(bus, res, __i, vartype) \
> + for (vartype __i = 0; \
> + res = pci_bus_resource_n(bus, __i), __i < PCI_BRIDGE_RESOURCE_NUM; \
> + __i++)
> +
> +#define pci_bus_for_each_resource(bus, res, i) \
> + __pci_bus_for_each_resource(bus, res, i, )
> +
> +#define pci_bus_for_each_resource_p(bus, res) \
> + __pci_bus_for_each_resource(bus, res, __i, unsigned int)
I like these changes a lot, too!
Same comments about _p vs _idx and __pci_bus_for_each_resource(...,
vartype).
Also would prefer 80 char max instead of 81.
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Mickaël Salaün" <mic@digikod.net>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Pali Rohár" <pali@kernel.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
"Juergen Gross" <jgross@suse.com>,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-pci@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org,
"Miguel Ojeda" <ojeda@kernel.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
"Matt Turner" <mattst88@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Anatolij Gustschin" <agust@denx.de>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Rich Felker" <dalias@libc.org>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"David S. Miller" <davem@davemloft.net>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>
Subject: Re: [PATCH v6 2/4] PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource()
Date: Wed, 22 Mar 2023 14:35:25 -0500 [thread overview]
Message-ID: <20230322193525.GA2487882@bhelgaas> (raw)
In-Reply-To: <20230320131633.61680-3-andriy.shevchenko@linux.intel.com>
On Mon, Mar 20, 2023 at 03:16:31PM +0200, Andy Shevchenko wrote:
> ...
> -#define pci_bus_for_each_resource(bus, res, i) \
> - for (i = 0; \
> - (res = pci_bus_resource_n(bus, i)) || i < PCI_BRIDGE_RESOURCE_NUM; \
> - i++)
> +#define __pci_bus_for_each_resource(bus, res, __i, vartype) \
> + for (vartype __i = 0; \
> + res = pci_bus_resource_n(bus, __i), __i < PCI_BRIDGE_RESOURCE_NUM; \
> + __i++)
> +
> +#define pci_bus_for_each_resource(bus, res, i) \
> + __pci_bus_for_each_resource(bus, res, i, )
> +
> +#define pci_bus_for_each_resource_p(bus, res) \
> + __pci_bus_for_each_resource(bus, res, __i, unsigned int)
I like these changes a lot, too!
Same comments about _p vs _idx and __pci_bus_for_each_resource(...,
vartype).
Also would prefer 80 char max instead of 81.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-22 19:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 13:16 [PATCH v6 0/4] Add pci_dev_for_each_resource() helper and update users Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-20 13:16 ` [PATCH v6 1/4] PCI: Introduce pci_dev_for_each_resource() Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-22 19:28 ` Bjorn Helgaas
2023-03-22 19:28 ` Bjorn Helgaas
2023-03-22 19:28 ` Bjorn Helgaas
2023-03-22 19:28 ` Bjorn Helgaas
2023-03-23 14:30 ` Andy Shevchenko
2023-03-23 14:30 ` Andy Shevchenko
2023-03-23 14:30 ` Andy Shevchenko
2023-03-23 14:30 ` Andy Shevchenko
2023-03-23 15:02 ` Bjorn Helgaas
2023-03-23 15:02 ` Bjorn Helgaas
2023-03-23 15:02 ` Bjorn Helgaas
2023-03-23 15:02 ` Bjorn Helgaas
2023-03-23 15:08 ` Andy Shevchenko
2023-03-23 15:08 ` Andy Shevchenko
2023-03-23 15:08 ` Andy Shevchenko
2023-03-23 15:08 ` Andy Shevchenko
2023-03-23 16:28 ` Geert Uytterhoeven
2023-03-23 16:28 ` Geert Uytterhoeven
2023-03-23 16:28 ` Geert Uytterhoeven
2023-03-23 16:28 ` Geert Uytterhoeven
2023-03-20 13:16 ` [PATCH v6 2/4] PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource() Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-22 19:35 ` Bjorn Helgaas [this message]
2023-03-22 19:35 ` Bjorn Helgaas
2023-03-22 19:35 ` Bjorn Helgaas
2023-03-22 19:35 ` Bjorn Helgaas
2023-03-20 13:16 ` [PATCH v6 3/4] EISA: Convert to use pci_bus_for_each_resource_p() Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-20 13:16 ` [PATCH v6 4/4] pcmcia: " Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
2023-03-20 13:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322193525.GA2487882@bhelgaas \
--to=helgaas@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=jgross@suse.com \
--cc=kw@linux.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=macro@orcam.me.uk \
--cc=mic@digikod.net \
--cc=mika.westerberg@linux.intel.com \
--cc=mpe@ellerman.id.au \
--cc=pali@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=schnelle@linux.ibm.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.