From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 0/3] Move container utils to testcases/lib/
Date: Thu, 23 Mar 2023 10:22:13 +0100 [thread overview]
Message-ID: <20230323092213.GE405493@pevik> (raw)
In-Reply-To: <20230313153056.GB10305@pevik>
> > Hi!
> > > Preparation for https://github.com/linux-test-project/ltp/issues/991.
> > > NOTE: this patch conflicts with my other patch [1]
> > > (touching testcases/lib/{Makefile,.gitignore}).
> > > Kind regards,
> > > Petr
> > > [1] https://patchwork.ozlabs.org/project/ltp/patch/20230307145517.1359-2-pvorel@suse.cz/
> > > Petr Vorel (3):
> > > ns_exec.c: Rename to testcases/lib/tst_ns_exec.c
> > > ns_create.c: Rename to testcases/lib/tst_ns_create.c
> > > ns_ifmove.c: Rename to testcases/lib/tst_ns_ifmove.c
> > > doc/namespaces-helper-tools.txt | 14 ++++++------
> > > .../ns_common.h => include/tst_ns_common.h | 6 ++---
> > I'm not sure about moving this header into top level include, it would
> > probably make more sense to add it next to the C files that include it.
> Sure, I'll put it there before merge (if it's the only thing to change).
BTW having header in testcases/lib/ will require to move ns_create.c together
with ns_exec.c in single commit (squash these 2 commits). But that should not be
a big deal.
Kind regards,
Petr
> Kind regards,
> Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-03-23 9:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 12:41 [LTP] [PATCH 0/3] Move container utils to testcases/lib/ Petr Vorel
2023-03-10 12:41 ` [LTP] [PATCH 1/3] ns_exec.c: Rename to testcases/lib/tst_ns_exec.c Petr Vorel
2023-03-10 12:41 ` [LTP] [PATCH 2/3] ns_create.c: Rename to testcases/lib/tst_ns_create.c Petr Vorel
2023-03-10 12:41 ` [LTP] [PATCH 3/3] ns_ifmove.c: Rename to testcases/lib/tst_ns_ifmove.c Petr Vorel
2023-03-10 12:42 ` [LTP] [PATCH 0/3] Move container utils to testcases/lib/ Petr Vorel
2023-03-13 15:06 ` Cyril Hrubis
2023-03-13 15:30 ` Petr Vorel
2023-03-23 9:22 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323092213.GE405493@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.