From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 0/3] Move container utils to testcases/lib/
Date: Mon, 13 Mar 2023 16:06:19 +0100 [thread overview]
Message-ID: <ZA87677RI2ddqkJm@yuki> (raw)
In-Reply-To: <20230310124125.14279-1-pvorel@suse.cz>
Hi!
> Preparation for https://github.com/linux-test-project/ltp/issues/991.
>
> NOTE: this patch conflicts with my other patch [1]
> (touching testcases/lib/{Makefile,.gitignore}).
>
> Kind regards,
> Petr
>
> [1] https://patchwork.ozlabs.org/project/ltp/patch/20230307145517.1359-2-pvorel@suse.cz/
>
>
> Petr Vorel (3):
> ns_exec.c: Rename to testcases/lib/tst_ns_exec.c
> ns_create.c: Rename to testcases/lib/tst_ns_create.c
> ns_ifmove.c: Rename to testcases/lib/tst_ns_ifmove.c
>
> doc/namespaces-helper-tools.txt | 14 ++++++------
> .../ns_common.h => include/tst_ns_common.h | 6 ++---
I'm not sure about moving this header into top level include, it would
probably make more sense to add it next to the C files that include it.
> .../kernel/containers/netns/netns_lib.sh | 22 +++++++++----------
> .../kernel/containers/netns/netns_sysfs.sh | 13 ++++++-----
> testcases/kernel/containers/share/.gitignore | 3 ---
> testcases/kernel/containers/share/Makefile | 22 -------------------
> testcases/kernel/fs/fs_bind/fs_bind_lib.sh | 7 +++---
> testcases/lib/.gitignore | 3 +++
> testcases/lib/Makefile | 2 +-
> testcases/lib/tst_net.sh | 16 +++++++-------
> .../share/ns_create.c => lib/tst_ns_create.c} | 5 +++--
> .../share/ns_exec.c => lib/tst_ns_exec.c} | 8 +++----
> .../share/ns_ifmove.c => lib/tst_ns_ifmove.c} | 2 +-
> 13 files changed, 52 insertions(+), 71 deletions(-)
> rename testcases/kernel/containers/share/ns_common.h => include/tst_ns_common.h (89%)
> delete mode 100644 testcases/kernel/containers/share/.gitignore
> delete mode 100644 testcases/kernel/containers/share/Makefile
> rename testcases/{kernel/containers/share/ns_create.c => lib/tst_ns_create.c} (92%)
> rename testcases/{kernel/containers/share/ns_exec.c => lib/tst_ns_exec.c} (91%)
> rename testcases/{kernel/containers/share/ns_ifmove.c => lib/tst_ns_ifmove.c} (97%)
>
> --
> 2.39.2
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-03-13 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 12:41 [LTP] [PATCH 0/3] Move container utils to testcases/lib/ Petr Vorel
2023-03-10 12:41 ` [LTP] [PATCH 1/3] ns_exec.c: Rename to testcases/lib/tst_ns_exec.c Petr Vorel
2023-03-10 12:41 ` [LTP] [PATCH 2/3] ns_create.c: Rename to testcases/lib/tst_ns_create.c Petr Vorel
2023-03-10 12:41 ` [LTP] [PATCH 3/3] ns_ifmove.c: Rename to testcases/lib/tst_ns_ifmove.c Petr Vorel
2023-03-10 12:42 ` [LTP] [PATCH 0/3] Move container utils to testcases/lib/ Petr Vorel
2023-03-13 15:06 ` Cyril Hrubis [this message]
2023-03-13 15:30 ` Petr Vorel
2023-03-23 9:22 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA87677RI2ddqkJm@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.