From: Cai Huoqing <cai.huoqing@linux.dev>
To: cai.huoqing@linux.dev
Cc: Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Yan-Hsuan Chuang <tony0620emma@gmail.com>,
Ping-Ke Shih <pkshih@realtek.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ath11k@lists.infradead.org, ath12k@lists.infradead.org
Subject: [PATCH 5/5] wifi: rtw89: Remove redundant pci_clear_master
Date: Thu, 23 Mar 2023 19:26:13 +0800 [thread overview]
Message-ID: <20230323112613.7550-5-cai.huoqing@linux.dev> (raw)
In-Reply-To: <20230323112613.7550-1-cai.huoqing@linux.dev>
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;
pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}
pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
drivers/net/wireless/realtek/rtw89/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
index ec8bb5f10482..75bd3ac4dd71 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.c
+++ b/drivers/net/wireless/realtek/rtw89/pci.c
@@ -2694,7 +2694,6 @@ static int rtw89_pci_claim_device(struct rtw89_dev *rtwdev,
static void rtw89_pci_declaim_device(struct rtw89_dev *rtwdev,
struct pci_dev *pdev)
{
- pci_clear_master(pdev);
pci_disable_device(pdev);
}
--
2.34.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Cai Huoqing <cai.huoqing@linux.dev>
To: cai.huoqing@linux.dev
Cc: Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Yan-Hsuan Chuang <tony0620emma@gmail.com>,
Ping-Ke Shih <pkshih@realtek.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ath11k@lists.infradead.org, ath12k@lists.infradead.org
Subject: [PATCH 5/5] wifi: rtw89: Remove redundant pci_clear_master
Date: Thu, 23 Mar 2023 19:26:13 +0800 [thread overview]
Message-ID: <20230323112613.7550-5-cai.huoqing@linux.dev> (raw)
In-Reply-To: <20230323112613.7550-1-cai.huoqing@linux.dev>
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;
pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}
pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
drivers/net/wireless/realtek/rtw89/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
index ec8bb5f10482..75bd3ac4dd71 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.c
+++ b/drivers/net/wireless/realtek/rtw89/pci.c
@@ -2694,7 +2694,6 @@ static int rtw89_pci_claim_device(struct rtw89_dev *rtwdev,
static void rtw89_pci_declaim_device(struct rtw89_dev *rtwdev,
struct pci_dev *pdev)
{
- pci_clear_master(pdev);
pci_disable_device(pdev);
}
--
2.34.1
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Cai Huoqing <cai.huoqing@linux.dev>
To: cai.huoqing@linux.dev
Cc: Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Yan-Hsuan Chuang <tony0620emma@gmail.com>,
Ping-Ke Shih <pkshih@realtek.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ath11k@lists.infradead.org, ath12k@lists.infradead.org
Subject: [PATCH 5/5] wifi: rtw89: Remove redundant pci_clear_master
Date: Thu, 23 Mar 2023 19:26:13 +0800 [thread overview]
Message-ID: <20230323112613.7550-5-cai.huoqing@linux.dev> (raw)
In-Reply-To: <20230323112613.7550-1-cai.huoqing@linux.dev>
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;
pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}
pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
drivers/net/wireless/realtek/rtw89/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
index ec8bb5f10482..75bd3ac4dd71 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.c
+++ b/drivers/net/wireless/realtek/rtw89/pci.c
@@ -2694,7 +2694,6 @@ static int rtw89_pci_claim_device(struct rtw89_dev *rtwdev,
static void rtw89_pci_declaim_device(struct rtw89_dev *rtwdev,
struct pci_dev *pdev)
{
- pci_clear_master(pdev);
pci_disable_device(pdev);
}
--
2.34.1
--
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k
WARNING: multiple messages have this Message-ID (diff)
From: Cai Huoqing <cai.huoqing@linux.dev>
To: cai.huoqing@linux.dev
Cc: Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Yan-Hsuan Chuang <tony0620emma@gmail.com>,
Ping-Ke Shih <pkshih@realtek.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ath11k@lists.infradead.org, ath12k@lists.infradead.org
Subject: [PATCH 5/5] wifi: rtw89: Remove redundant pci_clear_master
Date: Thu, 23 Mar 2023 19:26:13 +0800 [thread overview]
Message-ID: <20230323112613.7550-5-cai.huoqing@linux.dev> (raw)
In-Reply-To: <20230323112613.7550-1-cai.huoqing@linux.dev>
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;
pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}
pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
drivers/net/wireless/realtek/rtw89/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
index ec8bb5f10482..75bd3ac4dd71 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.c
+++ b/drivers/net/wireless/realtek/rtw89/pci.c
@@ -2694,7 +2694,6 @@ static int rtw89_pci_claim_device(struct rtw89_dev *rtwdev,
static void rtw89_pci_declaim_device(struct rtw89_dev *rtwdev,
struct pci_dev *pdev)
{
- pci_clear_master(pdev);
pci_disable_device(pdev);
}
--
2.34.1
next prev parent reply other threads:[~2023-03-23 11:32 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 11:26 [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear_master Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-23 11:26 ` [PATCH 2/5] wifi: ath10k: " Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-26 9:30 ` Simon Horman
2023-03-26 9:30 ` Simon Horman
2023-03-26 9:30 ` Simon Horman
2023-03-26 9:30 ` Simon Horman
2023-03-23 11:26 ` [PATCH 3/5] wifi: ath12k: " Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-26 9:31 ` Simon Horman
2023-03-26 9:31 ` Simon Horman
2023-03-26 9:31 ` Simon Horman
2023-03-26 9:31 ` Simon Horman
2023-03-23 11:26 ` [PATCH 4/5] wifi: rtw88: " Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-26 9:31 ` Simon Horman
2023-03-26 9:31 ` Simon Horman
2023-03-26 9:31 ` Simon Horman
2023-03-26 9:31 ` Simon Horman
2023-03-27 0:36 ` Ping-Ke Shih
2023-03-31 14:49 ` Kalle Valo
2023-03-31 14:49 ` Kalle Valo
2023-03-31 14:49 ` Kalle Valo
2023-03-31 14:49 ` Kalle Valo
2023-03-23 11:26 ` Cai Huoqing [this message]
2023-03-23 11:26 ` [PATCH 5/5] wifi: rtw89: " Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-23 11:26 ` Cai Huoqing
2023-03-26 9:31 ` Simon Horman
2023-03-26 9:31 ` Simon Horman
2023-03-26 9:31 ` Simon Horman
2023-03-26 9:31 ` Simon Horman
2023-03-27 0:37 ` Ping-Ke Shih
2023-04-03 13:38 ` Kalle Valo
2023-04-03 13:38 ` Kalle Valo
2023-04-03 13:38 ` Kalle Valo
2023-04-03 13:38 ` Kalle Valo
2023-03-26 9:30 ` [PATCH 1/5] wifi: ath11k: " Simon Horman
2023-03-26 9:30 ` Simon Horman
2023-03-26 9:30 ` Simon Horman
2023-03-26 9:30 ` Simon Horman
2023-04-12 10:03 ` Kalle Valo
2023-04-12 10:03 ` Kalle Valo
2023-04-12 10:03 ` Kalle Valo
2023-04-12 10:03 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323112613.7550-5-cai.huoqing@linux.dev \
--to=cai.huoqing@linux.dev \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.