All of lore.kernel.org
 help / color / mirror / Atom feed
From: ChiYuan Huang <cy_huang@richtek.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: ChiaEn Wu <chiaen_wu@richtek.com>, <corbet@lwn.net>,
	<lee@kernel.org>, <matthias.bgg@gmail.com>,
	<andriy.shevchenko@linux.intel.com>, <jacek.anaszewski@gmail.com>,
	<angelogioacchino.delregno@collabora.com>,
	<linux-doc@vger.kernel.org>, <peterwu.pub@gmail.com>,
	<linux-leds@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <szunichen@gmail.com>
Subject: Re: [PATCH v18 1/3] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support
Date: Tue, 28 Mar 2023 14:03:30 +0800	[thread overview]
Message-ID: <20230328060330.GA32398@linuxcarl2.richtek.com> (raw)
In-Reply-To: <ZCGCGb9E4KYlFNXR@duo.ucw.cz>

On Mon, Mar 27, 2023 at 01:46:33PM +0200, Pavel Machek wrote:
> Hi!
> 
> > The MediaTek MT6370 is a highly-integrated smart power management IC,
> > which includes a single cell Li-Ion/Li-Polymer switching battery
> > charger, a USB Type-C & Power Delivery (PD) controller, dual
> > Flash LED current sources, a RGB LED driver, a backlight WLED driver,
> > a display bias driver and a general LDO for portable devices.
> > 
> > Add support for the MediaTek MT6370 Current Sink Type LED Indicator
> > driver. It can control four channels current-sink RGB LEDs with 3 modes:
> > constant current, PWM, and breath mode.
> > 
> > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> > Co-developed-by: Alice Chen <alice_chen@richtek.com>
> > Signed-off-by: Alice Chen <alice_chen@richtek.com>
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> 
> 
> > +++ b/drivers/leds/rgb/Makefile
> > @@ -2,3 +2,4 @@
> >  
> >  obj-$(CONFIG_LEDS_PWM_MULTICOLOR)	+= leds-pwm-multicolor.o
> >  obj-$(CONFIG_LEDS_QCOM_LPG)		+= leds-qcom-lpg.o
> > +obj-$(CONFIG_LEDS_MT6370_RGB)		+= leds-mt6370-rgb.o
> 
> I'd preffer leds-mt6370 name. We already have "rgb" in directory
> name...
> 
Yap, sure,

But for mt6370 leds, except rgb indicators, there are also flashes for camera.
To keep the postfix in filename can more precisely tell what the file for.


> Otherwise looks good. Thanks for doing this.
> 
> BR,
> 								Pavel
> -- 
> People of Russia, stop Putin before his war on Ukraine escalates.



WARNING: multiple messages have this Message-ID (diff)
From: ChiYuan Huang <cy_huang@richtek.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: ChiaEn Wu <chiaen_wu@richtek.com>, <corbet@lwn.net>,
	<lee@kernel.org>, <matthias.bgg@gmail.com>,
	<andriy.shevchenko@linux.intel.com>, <jacek.anaszewski@gmail.com>,
	<angelogioacchino.delregno@collabora.com>,
	<linux-doc@vger.kernel.org>, <peterwu.pub@gmail.com>,
	<linux-leds@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <szunichen@gmail.com>
Subject: Re: [PATCH v18 1/3] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support
Date: Tue, 28 Mar 2023 14:03:30 +0800	[thread overview]
Message-ID: <20230328060330.GA32398@linuxcarl2.richtek.com> (raw)
In-Reply-To: <ZCGCGb9E4KYlFNXR@duo.ucw.cz>

On Mon, Mar 27, 2023 at 01:46:33PM +0200, Pavel Machek wrote:
> Hi!
> 
> > The MediaTek MT6370 is a highly-integrated smart power management IC,
> > which includes a single cell Li-Ion/Li-Polymer switching battery
> > charger, a USB Type-C & Power Delivery (PD) controller, dual
> > Flash LED current sources, a RGB LED driver, a backlight WLED driver,
> > a display bias driver and a general LDO for portable devices.
> > 
> > Add support for the MediaTek MT6370 Current Sink Type LED Indicator
> > driver. It can control four channels current-sink RGB LEDs with 3 modes:
> > constant current, PWM, and breath mode.
> > 
> > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> > Co-developed-by: Alice Chen <alice_chen@richtek.com>
> > Signed-off-by: Alice Chen <alice_chen@richtek.com>
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> 
> 
> > +++ b/drivers/leds/rgb/Makefile
> > @@ -2,3 +2,4 @@
> >  
> >  obj-$(CONFIG_LEDS_PWM_MULTICOLOR)	+= leds-pwm-multicolor.o
> >  obj-$(CONFIG_LEDS_QCOM_LPG)		+= leds-qcom-lpg.o
> > +obj-$(CONFIG_LEDS_MT6370_RGB)		+= leds-mt6370-rgb.o
> 
> I'd preffer leds-mt6370 name. We already have "rgb" in directory
> name...
> 
Yap, sure,

But for mt6370 leds, except rgb indicators, there are also flashes for camera.
To keep the postfix in filename can more precisely tell what the file for.


> Otherwise looks good. Thanks for doing this.
> 
> BR,
> 								Pavel
> -- 
> People of Russia, stop Putin before his war on Ukraine escalates.



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-28  6:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10  6:55 [PATCH v18 0/3] Add MediaTek MT6370 PMIC support ChiaEn Wu
2023-03-10  6:55 ` ChiaEn Wu
2023-03-10  6:55 ` [PATCH v18 1/3] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support ChiaEn Wu
2023-03-10  6:55   ` ChiaEn Wu
2023-03-17  7:53   ` Lee Jones
2023-03-17  7:53     ` Lee Jones
2023-03-27 11:46   ` Pavel Machek
2023-03-27 11:46     ` Pavel Machek
2023-03-28  6:03     ` ChiYuan Huang [this message]
2023-03-28  6:03       ` ChiYuan Huang
2023-03-10  6:55 ` [PATCH v18 2/3] leds: flash: mt6370: Add MediaTek MT6370 flashlight support ChiaEn Wu
2023-03-10  6:55   ` ChiaEn Wu
2023-03-17  8:00   ` Lee Jones
2023-03-17  8:00     ` Lee Jones
2023-03-17  8:03     ` Lee Jones
2023-03-17  8:03       ` Lee Jones
2023-03-10  6:55 ` [PATCH v18 3/3] docs: leds: Add MT6370 RGB LED pattern document ChiaEn Wu
2023-03-10  6:55   ` ChiaEn Wu
2023-03-16 15:51   ` Lee Jones
2023-03-16 15:51     ` Lee Jones
2023-03-17  1:06     ` ChiYuan Huang
2023-03-17  1:06       ` ChiYuan Huang
2023-03-17  8:04   ` Lee Jones
2023-03-17  8:04     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230328060330.GA32398@linuxcarl2.richtek.com \
    --to=cy_huang@richtek.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chiaen_wu@richtek.com \
    --cc=corbet@lwn.net \
    --cc=jacek.anaszewski@gmail.com \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=peterwu.pub@gmail.com \
    --cc=szunichen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.