All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>
Cc: Bang Li <libang.linuxer@gmail.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtdblock: tolerate corrected bit-flips
Date: Tue, 28 Mar 2023 16:00:27 +0200	[thread overview]
Message-ID: <20230328160027.21b5b340@xps-13> (raw)
In-Reply-To: <1785377500.357636.1680009710991.JavaMail.zimbra@nod.at>

Hi Richard,

richard@nod.at wrote on Tue, 28 Mar 2023 15:21:50 +0200 (CEST):

> Hi!
> 
> ----- Ursprüngliche Mail -----
> > libang.linuxer@gmail.com wrote on Thu, 23 Mar 2023 22:03:50 +0800:
> >   
> >> mtd_read() may return -EUCLEAN in case of corrected bit-flips.This
> >> particular condition should not be treated like an error.  
> > 
> > I'm fine with the patch, Richard, are you okay as well?  
> 
> Hm yes. I see the bug. I think it broke about 10 years ago
> by e47f68587b82 ("mtd: check for max_bitflips in mtd_read_oob()").
> 
> In the early day I'd expect someone to hit this bug but I guess
> on the last 10 years mtdblock had no real users.

Right.

Well, anyhow I guess this patch deserves a Fixes/Cc: stable # v3.7+

Li, can you please re-send with the proper tags? Thanks.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>
Cc: Bang Li <libang.linuxer@gmail.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtdblock: tolerate corrected bit-flips
Date: Tue, 28 Mar 2023 16:00:27 +0200	[thread overview]
Message-ID: <20230328160027.21b5b340@xps-13> (raw)
In-Reply-To: <1785377500.357636.1680009710991.JavaMail.zimbra@nod.at>

Hi Richard,

richard@nod.at wrote on Tue, 28 Mar 2023 15:21:50 +0200 (CEST):

> Hi!
> 
> ----- Ursprüngliche Mail -----
> > libang.linuxer@gmail.com wrote on Thu, 23 Mar 2023 22:03:50 +0800:
> >   
> >> mtd_read() may return -EUCLEAN in case of corrected bit-flips.This
> >> particular condition should not be treated like an error.  
> > 
> > I'm fine with the patch, Richard, are you okay as well?  
> 
> Hm yes. I see the bug. I think it broke about 10 years ago
> by e47f68587b82 ("mtd: check for max_bitflips in mtd_read_oob()").
> 
> In the early day I'd expect someone to hit this bug but I guess
> on the last 10 years mtdblock had no real users.

Right.

Well, anyhow I guess this patch deserves a Fixes/Cc: stable # v3.7+

Li, can you please re-send with the proper tags? Thanks.

Thanks,
Miquèl

  reply	other threads:[~2023-03-28 14:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 14:03 [PATCH] mtdblock: tolerate corrected bit-flips Bang Li
2023-03-23 14:03 ` Bang Li
2023-03-28 12:58 ` Miquel Raynal
2023-03-28 12:58   ` Miquel Raynal
2023-03-28 13:21   ` Richard Weinberger
2023-03-28 13:21     ` Richard Weinberger
2023-03-28 14:00     ` Miquel Raynal [this message]
2023-03-28 14:00       ` Miquel Raynal
  -- strict thread matches above, loose matches on Subject: below --
2023-03-14 16:56 Bang Li
2023-03-14 16:56 ` Bang Li
2023-03-22 16:08 ` Miquel Raynal
2023-03-22 16:08   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230328160027.21b5b340@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=libang.linuxer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.