All of lore.kernel.org
 help / color / mirror / Atom feed
* [isilence:optimise-rsrc-update 10/10] io_uring/rsrc.c:277:17: error: too many arguments to function 'io_put_rsrc_node'
@ 2023-03-29 20:51 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-03-29 20:51 UTC (permalink / raw)
  To: Pavel Begunkov; +Cc: oe-kbuild-all

tree:   https://github.com/isilence/linux optimise-rsrc-update
head:   c9b1352d2a9473070aa6ab1a4c562dcec430aa1a
commit: c9b1352d2a9473070aa6ab1a4c562dcec430aa1a [10/10] io_uring/rsrc: protect node refs with uring_lock
config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20230330/202303300455.IaikC7R2-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/isilence/linux/commit/c9b1352d2a9473070aa6ab1a4c562dcec430aa1a
        git remote add isilence https://github.com/isilence/linux
        git fetch --no-tags isilence optimise-rsrc-update
        git checkout c9b1352d2a9473070aa6ab1a4c562dcec430aa1a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303300455.IaikC7R2-lkp@intel.com/

All errors (new ones prefixed by >>):

   io_uring/rsrc.c: In function 'io_rsrc_node_switch':
>> io_uring/rsrc.c:277:17: error: too many arguments to function 'io_put_rsrc_node'
     277 |                 io_put_rsrc_node(rsrc_node, 1);
         |                 ^~~~~~~~~~~~~~~~
   In file included from io_uring/rsrc.c:17:
   io_uring/rsrc.h:109:20: note: declared here
     109 | static inline void io_put_rsrc_node(struct io_rsrc_node *node)
         |                    ^~~~~~~~~~~~~~~~


vim +/io_put_rsrc_node +277 io_uring/rsrc.c

   259	
   260	void io_rsrc_node_switch(struct io_ring_ctx *ctx,
   261				 struct io_rsrc_data *data_to_kill)
   262		__must_hold(&ctx->uring_lock)
   263	{
   264		WARN_ON_ONCE(!ctx->rsrc_backup_node);
   265		WARN_ON_ONCE(data_to_kill && !ctx->rsrc_node);
   266	
   267		if (data_to_kill) {
   268			struct io_rsrc_node *rsrc_node = ctx->rsrc_node;
   269	
   270			rsrc_node->rsrc_data = data_to_kill;
   271			spin_lock_irq(&ctx->rsrc_ref_lock);
   272			list_add_tail(&rsrc_node->node, &ctx->rsrc_ref_list);
   273			spin_unlock_irq(&ctx->rsrc_ref_lock);
   274	
   275			atomic_inc(&data_to_kill->refs);
   276			/* put master ref */
 > 277			io_put_rsrc_node(rsrc_node, 1);
   278			ctx->rsrc_node = NULL;
   279		}
   280	
   281		if (!ctx->rsrc_node) {
   282			ctx->rsrc_node = ctx->rsrc_backup_node;
   283			ctx->rsrc_backup_node = NULL;
   284		}
   285	}
   286	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-29 20:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-29 20:51 [isilence:optimise-rsrc-update 10/10] io_uring/rsrc.c:277:17: error: too many arguments to function 'io_put_rsrc_node' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.