From: Francesco Dolcini <francesco@dolcini.it>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
dri-devel@lists.freedesktop.org
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org
Subject: [PATCH v1 6/6] drm/bridge: tc358768: Add atomic_get_input_bus_fmts() implementation
Date: Thu, 30 Mar 2023 11:59:41 +0200 [thread overview]
Message-ID: <20230330095941.428122-7-francesco@dolcini.it> (raw)
In-Reply-To: <20230330095941.428122-1-francesco@dolcini.it>
From: Francesco Dolcini <francesco.dolcini@toradex.com>
Add atomic_get_input_bus_fmts() implementation, tc358768 has a parallel
RGB input interface with the actual bus format depending on the amount
of parallel input data lines.
Without this change when the tc358768 is used with less than 24bit the
color mapping is completely wrong.
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
drivers/gpu/drm/bridge/tc358768.c | 44 +++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
index 4462264274af..c41620409a39 100644
--- a/drivers/gpu/drm/bridge/tc358768.c
+++ b/drivers/gpu/drm/bridge/tc358768.c
@@ -9,6 +9,7 @@
#include <linux/gpio/consumer.h>
#include <linux/i2c.h>
#include <linux/kernel.h>
+#include <linux/media-bus-format.h>
#include <linux/module.h>
#include <linux/regmap.h>
#include <linux/regulator/consumer.h>
@@ -918,6 +919,44 @@ static void tc358768_bridge_enable(struct drm_bridge *bridge)
}
}
+#define MAX_INPUT_SEL_FORMATS 1
+
+static u32 *
+tc358768_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
+ struct drm_bridge_state *bridge_state,
+ struct drm_crtc_state *crtc_state,
+ struct drm_connector_state *conn_state,
+ u32 output_fmt,
+ unsigned int *num_input_fmts)
+{
+ struct tc358768_priv *priv = bridge_to_tc358768(bridge);
+ u32 *input_fmts;
+
+ *num_input_fmts = 0;
+
+ input_fmts = kcalloc(MAX_INPUT_SEL_FORMATS, sizeof(*input_fmts),
+ GFP_KERNEL);
+ if (!input_fmts)
+ return NULL;
+
+ switch (priv->pd_lines) {
+ case 16:
+ input_fmts[0] = MEDIA_BUS_FMT_RGB565_1X16;
+ break;
+ case 18:
+ input_fmts[0] = MEDIA_BUS_FMT_RGB666_1X18;
+ break;
+ default:
+ case 24:
+ input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24;
+ break;
+ };
+
+ *num_input_fmts = MAX_INPUT_SEL_FORMATS;
+
+ return input_fmts;
+}
+
static const struct drm_bridge_funcs tc358768_bridge_funcs = {
.attach = tc358768_bridge_attach,
.mode_valid = tc358768_bridge_mode_valid,
@@ -925,6 +964,11 @@ static const struct drm_bridge_funcs tc358768_bridge_funcs = {
.enable = tc358768_bridge_enable,
.disable = tc358768_bridge_disable,
.post_disable = tc358768_bridge_post_disable,
+
+ .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
+ .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
+ .atomic_reset = drm_atomic_helper_bridge_reset,
+ .atomic_get_input_bus_fmts = tc358768_atomic_get_input_bus_fmts,
};
static const struct drm_bridge_timings default_tc358768_timings = {
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Francesco Dolcini <francesco@dolcini.it>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
dri-devel@lists.freedesktop.org
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v1 6/6] drm/bridge: tc358768: Add atomic_get_input_bus_fmts() implementation
Date: Thu, 30 Mar 2023 11:59:41 +0200 [thread overview]
Message-ID: <20230330095941.428122-7-francesco@dolcini.it> (raw)
In-Reply-To: <20230330095941.428122-1-francesco@dolcini.it>
From: Francesco Dolcini <francesco.dolcini@toradex.com>
Add atomic_get_input_bus_fmts() implementation, tc358768 has a parallel
RGB input interface with the actual bus format depending on the amount
of parallel input data lines.
Without this change when the tc358768 is used with less than 24bit the
color mapping is completely wrong.
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
drivers/gpu/drm/bridge/tc358768.c | 44 +++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
index 4462264274af..c41620409a39 100644
--- a/drivers/gpu/drm/bridge/tc358768.c
+++ b/drivers/gpu/drm/bridge/tc358768.c
@@ -9,6 +9,7 @@
#include <linux/gpio/consumer.h>
#include <linux/i2c.h>
#include <linux/kernel.h>
+#include <linux/media-bus-format.h>
#include <linux/module.h>
#include <linux/regmap.h>
#include <linux/regulator/consumer.h>
@@ -918,6 +919,44 @@ static void tc358768_bridge_enable(struct drm_bridge *bridge)
}
}
+#define MAX_INPUT_SEL_FORMATS 1
+
+static u32 *
+tc358768_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
+ struct drm_bridge_state *bridge_state,
+ struct drm_crtc_state *crtc_state,
+ struct drm_connector_state *conn_state,
+ u32 output_fmt,
+ unsigned int *num_input_fmts)
+{
+ struct tc358768_priv *priv = bridge_to_tc358768(bridge);
+ u32 *input_fmts;
+
+ *num_input_fmts = 0;
+
+ input_fmts = kcalloc(MAX_INPUT_SEL_FORMATS, sizeof(*input_fmts),
+ GFP_KERNEL);
+ if (!input_fmts)
+ return NULL;
+
+ switch (priv->pd_lines) {
+ case 16:
+ input_fmts[0] = MEDIA_BUS_FMT_RGB565_1X16;
+ break;
+ case 18:
+ input_fmts[0] = MEDIA_BUS_FMT_RGB666_1X18;
+ break;
+ default:
+ case 24:
+ input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24;
+ break;
+ };
+
+ *num_input_fmts = MAX_INPUT_SEL_FORMATS;
+
+ return input_fmts;
+}
+
static const struct drm_bridge_funcs tc358768_bridge_funcs = {
.attach = tc358768_bridge_attach,
.mode_valid = tc358768_bridge_mode_valid,
@@ -925,6 +964,11 @@ static const struct drm_bridge_funcs tc358768_bridge_funcs = {
.enable = tc358768_bridge_enable,
.disable = tc358768_bridge_disable,
.post_disable = tc358768_bridge_post_disable,
+
+ .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
+ .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
+ .atomic_reset = drm_atomic_helper_bridge_reset,
+ .atomic_get_input_bus_fmts = tc358768_atomic_get_input_bus_fmts,
};
static const struct drm_bridge_timings default_tc358768_timings = {
--
2.25.1
next prev parent reply other threads:[~2023-03-30 10:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 9:59 [PATCH v1 0/6] drm/bridge: tc358768: Improve parallel RGB input configuration Francesco Dolcini
2023-03-30 9:59 ` Francesco Dolcini
2023-03-30 9:59 ` [PATCH v1 1/6] dt-bindings: display: bridge: toshiba,tc358768: Fix typo Francesco Dolcini
2023-03-30 9:59 ` [PATCH v1 1/6] dt-bindings: display: bridge: toshiba, tc358768: " Francesco Dolcini
2023-03-31 8:41 ` [PATCH v1 1/6] dt-bindings: display: bridge: toshiba,tc358768: " Krzysztof Kozlowski
2023-03-31 8:41 ` Krzysztof Kozlowski
2023-03-30 9:59 ` [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594 Francesco Dolcini
2023-03-30 9:59 ` [PATCH v1 2/6] dt-bindings: display: bridge: toshiba, tc358768: " Francesco Dolcini
2023-03-31 8:42 ` [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: " Krzysztof Kozlowski
2023-03-31 8:42 ` Krzysztof Kozlowski
2023-03-31 9:30 ` Francesco Dolcini
2023-03-31 9:30 ` Francesco Dolcini
2023-03-31 9:33 ` Krzysztof Kozlowski
2023-03-31 9:33 ` Krzysztof Kozlowski
2023-03-30 9:59 ` [PATCH v1 3/6] dt-bindings: display: bridge: toshiba,tc358768: add parallel input mode Francesco Dolcini
2023-03-30 9:59 ` [PATCH v1 3/6] dt-bindings: display: bridge: toshiba, tc358768: " Francesco Dolcini
2023-03-31 8:48 ` [PATCH v1 3/6] dt-bindings: display: bridge: toshiba,tc358768: " Krzysztof Kozlowski
2023-03-31 8:48 ` Krzysztof Kozlowski
2023-03-31 9:40 ` Francesco Dolcini
2023-03-31 9:40 ` Francesco Dolcini
2023-04-03 21:01 ` Rob Herring
2023-04-03 21:01 ` Rob Herring
2023-04-03 21:10 ` Francesco Dolcini
2023-04-03 21:10 ` Francesco Dolcini
2023-04-03 21:20 ` Francesco Dolcini
2023-04-03 21:20 ` Francesco Dolcini
2023-04-14 8:42 ` Francesco Dolcini
2023-04-14 8:42 ` Francesco Dolcini
2023-03-30 9:59 ` [PATCH v1 4/6] drm/bridge: tc358768: Add TC9594 Francesco Dolcini
2023-03-30 9:59 ` Francesco Dolcini
2023-03-30 9:59 ` [PATCH v1 5/6] drm/bridge: tc358768: Add parallel data format cfg Francesco Dolcini
2023-03-30 9:59 ` Francesco Dolcini
2023-03-30 9:59 ` Francesco Dolcini [this message]
2023-03-30 9:59 ` [PATCH v1 6/6] drm/bridge: tc358768: Add atomic_get_input_bus_fmts() implementation Francesco Dolcini
2023-04-20 9:51 ` Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330095941.428122-7-francesco@dolcini.it \
--to=francesco@dolcini.it \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=francesco.dolcini@toradex.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.