From: Francis Laniel <francis.laniel@amarulasolutions.com>
To: u-boot@lists.denx.de
Cc: "Michael Nazzareno Trimarchi" <michael@amarulasolutions.com>,
"Tom Rini" <trini@konsulko.com>, "Simon Glass" <sjg@chromium.org>,
"Harald Seiler" <hws@denx.de>,
"Francis Laniel" <francis.laniel@amarulasolutions.com>,
"Albert ARIBAUD (3ADEV)" <albert.aribaud@3adev.fr>,
"Tony Dinh" <mibodhi@gmail.com>,
"Sergei Antonov" <saproj@gmail.com>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Masahisa Kojima" <masahisa.kojima@linaro.org>,
"Pali Rohár" <pali@kernel.org>, "Stefan Roese" <sr@denx.de>,
"John Keeping" <john@metanate.com>,
"Roger Knecht" <rknecht@pm.me>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Sughosh Ganu" <sughosh.ganu@linaro.org>,
"Alexey Romanov" <avromanov@sberdevices.ru>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
"Hector Palacios" <hector.palacios@digi.com>,
"Marek Vasut" <marex@denx.de>,
"Rasmus Villemoes" <rasmus.villemoes@prevas.dk>,
"AKASHI Takahiro" <takahiro.akashi@linaro.org>,
"Rui Miguel Silva" <rui.silva@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Andrew Scull" <ascull@google.com>
Subject: [RFC PATCH v7 09/23] cli: Add menu for hush parser
Date: Thu, 30 Mar 2023 20:46:57 +0100 [thread overview]
Message-ID: <20230330194716.23623-10-francis.laniel@amarulasolutions.com> (raw)
In-Reply-To: <20230330194716.23623-1-francis.laniel@amarulasolutions.com>
For the moment, the menu contains only entry: HUSH_OLD_PARSER which is the
default.
The goal is to prepare the field to add a new hush parser which guarantees
actual behavior is still correct.
Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
---
cmd/Kconfig | 21 +++++++++++++++++++++
common/Makefile | 3 ++-
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 2caa4af71c..1b9d04680d 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -23,6 +23,27 @@ config HUSH_PARSER
If disabled, you get the old, much simpler behaviour with a somewhat
smaller memory footprint.
+menu "Hush flavor to use"
+ depends on HUSH_PARSER
+
+ config HUSH_OLD_PARSER
+ bool "Use hush old parser"
+ default y
+ help
+ This option enables the old flavor of hush based on hush Busybox from
+ 2005.
+
+ It is actually the default U-Boot shell when decided to use hush as shell.
+
+ config HUSH_2021_PARSER
+ bool "Use hush 2021 parser"
+ help
+ This option enables the new flavor of hush based on hush Busybox from
+ 2021.
+
+ For the moment, it is highly experimental and should be used at own risks.
+endmenu
+
config CMDLINE_EDITING
bool "Enable command line editing"
depends on CMDLINE
diff --git a/common/Makefile b/common/Makefile
index a50302d8b5..ddb89306ee 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -8,7 +8,8 @@ ifndef CONFIG_SPL_BUILD
obj-y += init/
obj-y += main.o
obj-y += exports.o
-obj-$(CONFIG_HUSH_PARSER) += cli_hush.o
+obj-$(CONFIG_HUSH_OLD_PARSER) += cli_hush.o
+obj-$(CONFIG_HUSH_2021_PARSER) += cli_hush_2021.o
obj-$(CONFIG_AUTOBOOT) += autoboot.o
# # boards
--
2.34.1
next prev parent reply other threads:[~2023-03-30 20:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 19:46 [RFC PATCH v7 00/23] Modernize U-Boot shell Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 01/23] test: Add framework to test hush behavior Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 02/23] test: hush: Test hush if/else Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 03/23] test/py: hush_if_test: Remove the test file Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 04/23] test: hush: Test hush variable expansion Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:46 ` [RFC PATCH v7 05/23] test: hush: Test hush commands list Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 06/23] test: hush: Test hush loops Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 07/23] cli: Add Busybox upstream hush.c file Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 08/23] cli: Port Busybox 2021 hush to U-Boot Francis Laniel
2023-03-30 19:46 ` Francis Laniel [this message]
2023-04-01 6:32 ` [RFC PATCH v7 09/23] cli: Add menu for hush parser Simon Glass
2023-03-30 19:46 ` [RFC PATCH v7 10/23] global_data.h: add GD_FLG_HUSH_OLD_PARSER flag Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:46 ` [RFC PATCH v7 11/23] cmd: Add new parser command Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-04-01 22:44 ` Francis Laniel
2023-03-30 19:47 ` [RFC PATCH v7 12/23] cli: Enables using hush 2021 parser as command line parser Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:47 ` [RFC PATCH v7 13/23] cli: hush_2021: Enable variables expansion for hush 2021 Francis Laniel
2023-03-30 19:47 ` [RFC PATCH v7 14/23] cli: hush_2021: Add functions to be called from run_command() Francis Laniel
2023-03-30 19:47 ` [RFC PATCH v7 15/23] cli: add hush 2021 as parser for run_command*() Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:47 ` [RFC PATCH v7 16/23] test: hush: Fix instructions list tests for hush 2021 Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:47 ` [RFC PATCH v7 17/23] test: hush: Fix variable expansion " Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:47 ` [RFC PATCH v7 18/23] cli: hush_2021: Enable using < and > as string compare operators Francis Laniel
2023-03-30 19:47 ` [RFC PATCH v7 19/23] cli: hush_2021: Enable if keyword Francis Laniel
2023-03-30 19:47 ` [RFC PATCH v7 20/23] cli: hush_2021: Enable loops Francis Laniel
2023-03-30 19:47 ` [RFC PATCH v7 21/23] test: hush: Fix loop tests for hush 2021 Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:47 ` [RFC PATCH v7 22/23] cli: hush_2021: Add upstream commits up to 30th January 2023 Francis Laniel
2023-03-30 19:47 ` [RFC PATCH v7 23/23] DO NOT MERGE: only to make CI happy Francis Laniel
2023-03-30 20:17 ` Tony Dinh
2023-03-30 22:14 ` Francis Laniel
2023-03-31 23:17 ` Tony Dinh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330194716.23623-10-francis.laniel@amarulasolutions.com \
--to=francis.laniel@amarulasolutions.com \
--cc=albert.aribaud@3adev.fr \
--cc=ascull@google.com \
--cc=avromanov@sberdevices.ru \
--cc=fabrice.gasnier@foss.st.com \
--cc=hector.palacios@digi.com \
--cc=hws@denx.de \
--cc=ilias.apalodimas@linaro.org \
--cc=john@metanate.com \
--cc=linus.walleij@linaro.org \
--cc=marex@denx.de \
--cc=masahisa.kojima@linaro.org \
--cc=mibodhi@gmail.com \
--cc=michael@amarulasolutions.com \
--cc=neil.armstrong@linaro.org \
--cc=pali@kernel.org \
--cc=patrice.chotard@foss.st.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=rknecht@pm.me \
--cc=rui.silva@linaro.org \
--cc=saproj@gmail.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=sughosh.ganu@linaro.org \
--cc=takahiro.akashi@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.