From: Francis Laniel <francis.laniel@amarulasolutions.com>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de,
"Michael Nazzareno Trimarchi" <michael@amarulasolutions.com>,
"Tom Rini" <trini@konsulko.com>, "Harald Seiler" <hws@denx.de>,
"Albert ARIBAUD (3ADEV)" <albert.aribaud@3adev.fr>,
"Tony Dinh" <mibodhi@gmail.com>,
"Sergei Antonov" <saproj@gmail.com>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Masahisa Kojima" <masahisa.kojima@linaro.org>,
"Pali Rohár" <pali@kernel.org>, "Stefan Roese" <sr@denx.de>,
"John Keeping" <john@metanate.com>,
"Roger Knecht" <rknecht@pm.me>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Marko" <robimarko@gmail.com>,
"Alexey Romanov" <avromanov@sberdevices.ru>,
"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
"Marek Vasut" <marex@denx.de>,
"Hector Palacios" <hector.palacios@digi.com>,
"Rasmus Villemoes" <rasmus.villemoes@prevas.dk>,
"AKASHI Takahiro" <takahiro.akashi@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rui Miguel Silva" <rui.silva@linaro.org>,
"Andrew Scull" <ascull@google.com>
Subject: Re: [RFC PATCH v7 11/23] cmd: Add new parser command
Date: Sat, 01 Apr 2023 23:44:10 +0100 [thread overview]
Message-ID: <4819006.31r3eYUQgx@pwmachine> (raw)
In-Reply-To: <CAPnjgZ0Q6hBdPy0i7rL2sDTvWFTysDaVB72t+EYcKz-5o+i8dA@mail.gmail.com>
Hi.
Le samedi 1 avril 2023, 07:32:14 WEST Simon Glass a écrit :
> Hi Francis,
>
> On Fri, 31 Mar 2023 at 08:49, Francis Laniel
>
> <francis.laniel@amarulasolutions.com> wrote:
> > This command can be used to print the current parser with 'parser print'.
> > It can also be used to set the current parser with 'parser set'.
> > For the moment, only one value is valid for set: old.
> >
> > Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
> > ---
> >
> > cmd/Makefile | 2 +
> > cmd/parser.c | 120 +++++++++++++++++++++++++++++++++++++++++++++++++++
> > common/cli.c | 3 +-
> > 3 files changed, 124 insertions(+), 1 deletion(-)
> > create mode 100644 cmd/parser.c
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Thank you for the reviews!
>
> But I wonder whether 'cli' might be a better name for this command? We
> use cli everywhere else.
"Naming thing is hard" [1].
Thank you for the suggestion! I changed it to cli which I think is a better
name as it is less abstract than parser.
> Also can you add doc/usage for this?
Done! I was not aware of doc/usage/cmd before.
> Regards,
> Simon
By the way, I also addressed your other comments on patches 4 and 9.
Best regards.
---
[1] https://www.karlton.org/2017/12/naming-things-hard/
next prev parent reply other threads:[~2023-04-01 22:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 19:46 [RFC PATCH v7 00/23] Modernize U-Boot shell Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 01/23] test: Add framework to test hush behavior Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 02/23] test: hush: Test hush if/else Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 03/23] test/py: hush_if_test: Remove the test file Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 04/23] test: hush: Test hush variable expansion Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:46 ` [RFC PATCH v7 05/23] test: hush: Test hush commands list Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 06/23] test: hush: Test hush loops Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 07/23] cli: Add Busybox upstream hush.c file Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 08/23] cli: Port Busybox 2021 hush to U-Boot Francis Laniel
2023-03-30 19:46 ` [RFC PATCH v7 09/23] cli: Add menu for hush parser Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:46 ` [RFC PATCH v7 10/23] global_data.h: add GD_FLG_HUSH_OLD_PARSER flag Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:46 ` [RFC PATCH v7 11/23] cmd: Add new parser command Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-04-01 22:44 ` Francis Laniel [this message]
2023-03-30 19:47 ` [RFC PATCH v7 12/23] cli: Enables using hush 2021 parser as command line parser Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:47 ` [RFC PATCH v7 13/23] cli: hush_2021: Enable variables expansion for hush 2021 Francis Laniel
2023-03-30 19:47 ` [RFC PATCH v7 14/23] cli: hush_2021: Add functions to be called from run_command() Francis Laniel
2023-03-30 19:47 ` [RFC PATCH v7 15/23] cli: add hush 2021 as parser for run_command*() Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:47 ` [RFC PATCH v7 16/23] test: hush: Fix instructions list tests for hush 2021 Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:47 ` [RFC PATCH v7 17/23] test: hush: Fix variable expansion " Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:47 ` [RFC PATCH v7 18/23] cli: hush_2021: Enable using < and > as string compare operators Francis Laniel
2023-03-30 19:47 ` [RFC PATCH v7 19/23] cli: hush_2021: Enable if keyword Francis Laniel
2023-03-30 19:47 ` [RFC PATCH v7 20/23] cli: hush_2021: Enable loops Francis Laniel
2023-03-30 19:47 ` [RFC PATCH v7 21/23] test: hush: Fix loop tests for hush 2021 Francis Laniel
2023-04-01 6:32 ` Simon Glass
2023-03-30 19:47 ` [RFC PATCH v7 22/23] cli: hush_2021: Add upstream commits up to 30th January 2023 Francis Laniel
2023-03-30 19:47 ` [RFC PATCH v7 23/23] DO NOT MERGE: only to make CI happy Francis Laniel
2023-03-30 20:17 ` Tony Dinh
2023-03-30 22:14 ` Francis Laniel
2023-03-31 23:17 ` Tony Dinh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4819006.31r3eYUQgx@pwmachine \
--to=francis.laniel@amarulasolutions.com \
--cc=albert.aribaud@3adev.fr \
--cc=ascull@google.com \
--cc=avromanov@sberdevices.ru \
--cc=fabrice.gasnier@foss.st.com \
--cc=hector.palacios@digi.com \
--cc=hws@denx.de \
--cc=ilias.apalodimas@linaro.org \
--cc=john@metanate.com \
--cc=linus.walleij@linaro.org \
--cc=marex@denx.de \
--cc=masahisa.kojima@linaro.org \
--cc=mibodhi@gmail.com \
--cc=michael@amarulasolutions.com \
--cc=neil.armstrong@linaro.org \
--cc=pali@kernel.org \
--cc=patrick.delaunay@foss.st.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=rknecht@pm.me \
--cc=robimarko@gmail.com \
--cc=rui.silva@linaro.org \
--cc=saproj@gmail.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=takahiro.akashi@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.