Re: [PATCH 5/6] firmware: smccc: Allow errata management to be overridden by device tree

From: kernel test robot <lkp@intel.com>
To: James Morse <james.morse@arm.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Marc Zyngier <maz@kernel.org>,
	Oliver Upton <oliver.upton@linux.dev>,
	James Morse <james.morse@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH 5/6] firmware: smccc: Allow errata management to be overridden by device tree
Date: Fri, 31 Mar 2023 04:44:26 +0800	[thread overview]
Message-ID: <202303310444.3JHIsByA-lkp@intel.com> (raw)
In-Reply-To: <20230330165128.3237939-6-james.morse@arm.com>

Hi James,

I love your patch! Perhaps something to improve:

[auto build test WARNING on arm64/for-next/core]
[also build test WARNING on robh/for-next arm/for-next arm/fixes kvmarm/next soc/for-next linus/master v6.3-rc4 next-20230330]
[cannot apply to xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/James-Morse/dt-bindings-firmware-Add-arm-errata-management/20230331-005505
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
patch link:    https://lore.kernel.org/r/20230330165128.3237939-6-james.morse%40arm.com
patch subject: [PATCH 5/6] firmware: smccc: Allow errata management to be overridden by device tree
config: arm64-randconfig-r032-20230329 (https://download.01.org/0day-ci/archive/20230331/202303310444.3JHIsByA-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/79e2d2cd6684ebd4e8c4787905486b63301117a9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review James-Morse/dt-bindings-firmware-Add-arm-errata-management/20230331-005505
        git checkout 79e2d2cd6684ebd4e8c4787905486b63301117a9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/firmware/smccc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303310444.3JHIsByA-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/firmware/smccc/em.c:142:5: warning: no previous prototype for 'arm_smccc_em_dt_alloc_tbl_entry' [-Wmissing-prototypes]
     142 | int arm_smccc_em_dt_alloc_tbl_entry(struct device_node *np, const char *name,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/arm_smccc_em_dt_alloc_tbl_entry +142 drivers/firmware/smccc/em.c

   141	
 > 142	int arm_smccc_em_dt_alloc_tbl_entry(struct device_node *np, const char *name,
   143					    struct arm_em_dt_supplement_array *entry)
   144	{
   145		int ret = of_property_count_u32_elems(np, name);
   146	
   147		if (ret <= 0)
   148			return 0;
   149		if (ret > ARRAY_SIZE(entry->val))
   150			return -E2BIG;
   151	
   152		entry->num = ret;
   153		return of_property_read_u32_array(np, name, entry->val, entry->num);
   154	}
   155	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests