From: Jakub Kicinski <kuba@kernel.org>
To: Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"zbr@ioremap.net" <zbr@ioremap.net>,
"brauner@kernel.org" <brauner@kernel.org>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>,
"leon@kernel.org" <leon@kernel.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"socketcan@hartkopp.net" <socketcan@hartkopp.net>,
"petrm@nvidia.com" <petrm@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 1/6] netlink: Reverse the patch which removed filtering
Date: Sat, 1 Apr 2023 12:12:12 -0700 [thread overview]
Message-ID: <20230401121212.454abf11@kernel.org> (raw)
In-Reply-To: <88FD5EFE-6946-42C4-881B-329C3FE01D26@oracle.com>
On Sat, 1 Apr 2023 18:24:11 +0000 Anjali Kulkarni wrote:
> > nit: slight divergence between __u32 and u32 types, something to clean
> > up if you post v5
>
> Thanks so much! Will do. Any comments on the connector patches?
patch 3 looks fine as far as I can read thru the ugly in place casts
patch 5 looks a bit connector specific, no idea :S
patch 6 does seem to lift the NET_ADMIN for group 0
and from &init_user_ns, CAP_NET_ADMIN to net->user_ns, CAP_NET_ADMIN
whether that's right or not I have no idea :(
Also, BTW, on the coding level:
+static int cn_bind(struct net *net, int group)
+{
+ unsigned long groups = 0;
+ groups = (unsigned long) group;
+
+ if (test_bit(CN_IDX_PROC - 1, &groups))
Why not just
+static int cn_bind(struct net *net, int group)
+{
+ if (group == CN_IDX_PROC)
?
Who are you hoping will merge this?
next prev parent reply other threads:[~2023-04-01 19:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 23:55 [PATCH v4 0/6] Process connector bug fixes & enhancements Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 1/6] netlink: Reverse the patch which removed filtering Anjali Kulkarni
2023-04-01 4:08 ` Jakub Kicinski
2023-04-01 4:09 ` Jakub Kicinski
2023-04-01 18:24 ` Anjali Kulkarni
2023-04-01 19:12 ` Jakub Kicinski [this message]
2023-04-01 19:58 ` Anjali Kulkarni
2023-04-03 20:47 ` Jakub Kicinski
2023-04-02 2:32 ` Anjali Kulkarni
2023-04-03 20:50 ` Jakub Kicinski
2023-04-04 18:06 ` Anjali Kulkarni
2023-04-26 23:58 ` Anjali Kulkarni
2023-04-27 17:03 ` Jakub Kicinski
2023-05-11 16:04 ` Anjali Kulkarni
2023-06-01 16:15 ` Anjali Kulkarni
2023-06-01 16:24 ` Jakub Kicinski
2023-06-01 16:34 ` Anjali Kulkarni
2023-06-01 16:43 ` Jakub Kicinski
2023-06-01 16:49 ` Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 2/6] netlink: Add new netlink_release function Anjali Kulkarni
2023-04-01 4:08 ` Jakub Kicinski
2023-03-31 23:55 ` [PATCH v4 3/6] connector/cn_proc: Add filtering to fix some bugs Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 4/6] connector/cn_proc: Test code for proc connector Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 5/6] connector/cn_proc: Performance improvements Anjali Kulkarni
2023-06-01 16:25 ` Jakub Kicinski
2023-06-01 16:38 ` Anjali Kulkarni
2023-06-01 16:48 ` Jakub Kicinski
2023-06-01 16:53 ` Anjali Kulkarni
2023-06-01 17:15 ` Jakub Kicinski
2023-06-02 22:23 ` Anjali Kulkarni
2023-06-02 23:02 ` Jakub Kicinski
2023-03-31 23:55 ` [PATCH v4 6/6] connector/cn_proc: Allow non-root users access Anjali Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230401121212.454abf11@kernel.org \
--to=kuba@kernel.org \
--cc=anjali.k.kulkarni@oracle.com \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=socketcan@hartkopp.net \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.