All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Junhao He <hejunhao3@huawei.com>
Cc: <will@kernel.org>, <linux-kernel@vger.kernel.org>,
	<mark.rutland@arm.com>, <linux-arm-kernel@lists.infradead.org>,
	<catalin.marinas@arm.com>, <kernel-team@android.com>,
	<linuxarm@huawei.com>, <yangyicong@huawei.com>,
	<f.fangjian@huawei.com>, <shenyang39@huawei.com>,
	<prime.zeng@hisilicon.com>
Subject: Re: [PATCH 1/2] drivers/perf: hisi: Remove redundant initialized of pmu->name
Date: Mon, 3 Apr 2023 12:02:51 +0100	[thread overview]
Message-ID: <20230403120251.00003fd7@Huawei.com> (raw)
In-Reply-To: <20230403081423.62460-2-hejunhao3@huawei.com>

On Mon, 3 Apr 2023 16:14:22 +0800
Junhao He <hejunhao3@huawei.com> wrote:

> "pmu->name" is initialized by perf_pmu_register() function, so remove
> the redundant initialized in hisi_pmu_init().
> 
> Signed-off-by: Junhao He <hejunhao3@huawei.com>
LGTM

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
>  drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c  | 2 +-
>  drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c | 2 +-
>  drivers/perf/hisilicon/hisi_uncore_hha_pmu.c  | 2 +-
>  drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c  | 2 +-
>  drivers/perf/hisilicon/hisi_uncore_pa_pmu.c   | 2 +-
>  drivers/perf/hisilicon/hisi_uncore_pmu.c      | 4 +---
>  drivers/perf/hisilicon/hisi_uncore_pmu.h      | 3 +--
>  drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c | 2 +-
>  8 files changed, 8 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c b/drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c
> index 4c67d57217a7..40f1bc9f9b91 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c
> @@ -316,7 +316,7 @@ static int hisi_cpa_pmu_probe(struct platform_device *pdev)
>  	if (!name)
>  		return -ENOMEM;
>  
> -	hisi_pmu_init(cpa_pmu, name, THIS_MODULE);
> +	hisi_pmu_init(cpa_pmu, THIS_MODULE);
>  
>  	/* Power Management should be disabled before using CPA PMU. */
>  	hisi_cpa_pmu_disable_pm(cpa_pmu);
> diff --git a/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c b/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
> index 8c3ffcbfd4c0..8a3d74ddcd6d 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
> @@ -516,7 +516,7 @@ static int hisi_ddrc_pmu_probe(struct platform_device *pdev)
>  				      "hisi_sccl%u_ddrc%u", ddrc_pmu->sccl_id,
>  				      ddrc_pmu->index_id);
>  
> -	hisi_pmu_init(ddrc_pmu, name, THIS_MODULE);
> +	hisi_pmu_init(ddrc_pmu, THIS_MODULE);
>  
>  	ret = perf_pmu_register(&ddrc_pmu->pmu, name, -1);
>  	if (ret) {
> diff --git a/drivers/perf/hisilicon/hisi_uncore_hha_pmu.c b/drivers/perf/hisilicon/hisi_uncore_hha_pmu.c
> index 806698b9eabf..5701a84edb0e 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_hha_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_hha_pmu.c
> @@ -519,7 +519,7 @@ static int hisi_hha_pmu_probe(struct platform_device *pdev)
>  
>  	name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "hisi_sccl%u_hha%u",
>  			      hha_pmu->sccl_id, hha_pmu->index_id);
> -	hisi_pmu_init(hha_pmu, name, THIS_MODULE);
> +	hisi_pmu_init(hha_pmu, THIS_MODULE);
>  
>  	ret = perf_pmu_register(&hha_pmu->pmu, name, -1);
>  	if (ret) {
> diff --git a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
> index 5b2c35f1658a..68596b566344 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
> @@ -557,7 +557,7 @@ static int hisi_l3c_pmu_probe(struct platform_device *pdev)
>  	 */
>  	name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "hisi_sccl%u_l3c%u",
>  			      l3c_pmu->sccl_id, l3c_pmu->ccl_id);
> -	hisi_pmu_init(l3c_pmu, name, THIS_MODULE);
> +	hisi_pmu_init(l3c_pmu, THIS_MODULE);
>  
>  	ret = perf_pmu_register(&l3c_pmu->pmu, name, -1);
>  	if (ret) {
> diff --git a/drivers/perf/hisilicon/hisi_uncore_pa_pmu.c b/drivers/perf/hisilicon/hisi_uncore_pa_pmu.c
> index afe3419f3f6d..71b6687d6696 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_pa_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_pa_pmu.c
> @@ -412,7 +412,7 @@ static int hisi_pa_pmu_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> -	hisi_pmu_init(pa_pmu, name, THIS_MODULE);
> +	hisi_pmu_init(pa_pmu, THIS_MODULE);
>  	ret = perf_pmu_register(&pa_pmu->pmu, name, -1);
>  	if (ret) {
>  		dev_err(pa_pmu->dev, "PMU register failed, ret = %d\n", ret);
> diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.c b/drivers/perf/hisilicon/hisi_uncore_pmu.c
> index f1b0f5e1a28f..2823f381930d 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.c
> @@ -531,12 +531,10 @@ int hisi_uncore_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node)
>  }
>  EXPORT_SYMBOL_GPL(hisi_uncore_pmu_offline_cpu);
>  
> -void hisi_pmu_init(struct hisi_pmu *hisi_pmu, const char *name,
> -		   struct module *module)
> +void hisi_pmu_init(struct hisi_pmu *hisi_pmu, struct module *module)
>  {
>  	struct pmu *pmu = &hisi_pmu->pmu;
>  
> -	pmu->name               = name;
>  	pmu->module             = module;
>  	pmu->task_ctx_nr        = perf_invalid_context;
>  	pmu->event_init         = hisi_uncore_pmu_event_init;
> diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.h b/drivers/perf/hisilicon/hisi_uncore_pmu.h
> index f8e3cc6903d7..07890a8e96ca 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_pmu.h
> +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.h
> @@ -121,6 +121,5 @@ ssize_t hisi_uncore_pmu_identifier_attr_show(struct device *dev,
>  int hisi_uncore_pmu_init_irq(struct hisi_pmu *hisi_pmu,
>  			     struct platform_device *pdev);
>  
> -void hisi_pmu_init(struct hisi_pmu *hisi_pmu, const char *name,
> -		   struct module *module);
> +void hisi_pmu_init(struct hisi_pmu *hisi_pmu, struct module *module);
>  #endif /* __HISI_UNCORE_PMU_H__ */
> diff --git a/drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c b/drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c
> index 1e354433776a..6fe534a665ed 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c
> @@ -445,7 +445,7 @@ static int hisi_sllc_pmu_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> -	hisi_pmu_init(sllc_pmu, name, THIS_MODULE);
> +	hisi_pmu_init(sllc_pmu, THIS_MODULE);
>  
>  	ret = perf_pmu_register(&sllc_pmu->pmu, name, -1);
>  	if (ret) {


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Junhao He <hejunhao3@huawei.com>
Cc: <will@kernel.org>, <linux-kernel@vger.kernel.org>,
	<mark.rutland@arm.com>, <linux-arm-kernel@lists.infradead.org>,
	<catalin.marinas@arm.com>, <kernel-team@android.com>,
	<linuxarm@huawei.com>, <yangyicong@huawei.com>,
	<f.fangjian@huawei.com>, <shenyang39@huawei.com>,
	<prime.zeng@hisilicon.com>
Subject: Re: [PATCH 1/2] drivers/perf: hisi: Remove redundant initialized of pmu->name
Date: Mon, 3 Apr 2023 12:02:51 +0100	[thread overview]
Message-ID: <20230403120251.00003fd7@Huawei.com> (raw)
In-Reply-To: <20230403081423.62460-2-hejunhao3@huawei.com>

On Mon, 3 Apr 2023 16:14:22 +0800
Junhao He <hejunhao3@huawei.com> wrote:

> "pmu->name" is initialized by perf_pmu_register() function, so remove
> the redundant initialized in hisi_pmu_init().
> 
> Signed-off-by: Junhao He <hejunhao3@huawei.com>
LGTM

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
>  drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c  | 2 +-
>  drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c | 2 +-
>  drivers/perf/hisilicon/hisi_uncore_hha_pmu.c  | 2 +-
>  drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c  | 2 +-
>  drivers/perf/hisilicon/hisi_uncore_pa_pmu.c   | 2 +-
>  drivers/perf/hisilicon/hisi_uncore_pmu.c      | 4 +---
>  drivers/perf/hisilicon/hisi_uncore_pmu.h      | 3 +--
>  drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c | 2 +-
>  8 files changed, 8 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c b/drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c
> index 4c67d57217a7..40f1bc9f9b91 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c
> @@ -316,7 +316,7 @@ static int hisi_cpa_pmu_probe(struct platform_device *pdev)
>  	if (!name)
>  		return -ENOMEM;
>  
> -	hisi_pmu_init(cpa_pmu, name, THIS_MODULE);
> +	hisi_pmu_init(cpa_pmu, THIS_MODULE);
>  
>  	/* Power Management should be disabled before using CPA PMU. */
>  	hisi_cpa_pmu_disable_pm(cpa_pmu);
> diff --git a/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c b/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
> index 8c3ffcbfd4c0..8a3d74ddcd6d 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
> @@ -516,7 +516,7 @@ static int hisi_ddrc_pmu_probe(struct platform_device *pdev)
>  				      "hisi_sccl%u_ddrc%u", ddrc_pmu->sccl_id,
>  				      ddrc_pmu->index_id);
>  
> -	hisi_pmu_init(ddrc_pmu, name, THIS_MODULE);
> +	hisi_pmu_init(ddrc_pmu, THIS_MODULE);
>  
>  	ret = perf_pmu_register(&ddrc_pmu->pmu, name, -1);
>  	if (ret) {
> diff --git a/drivers/perf/hisilicon/hisi_uncore_hha_pmu.c b/drivers/perf/hisilicon/hisi_uncore_hha_pmu.c
> index 806698b9eabf..5701a84edb0e 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_hha_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_hha_pmu.c
> @@ -519,7 +519,7 @@ static int hisi_hha_pmu_probe(struct platform_device *pdev)
>  
>  	name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "hisi_sccl%u_hha%u",
>  			      hha_pmu->sccl_id, hha_pmu->index_id);
> -	hisi_pmu_init(hha_pmu, name, THIS_MODULE);
> +	hisi_pmu_init(hha_pmu, THIS_MODULE);
>  
>  	ret = perf_pmu_register(&hha_pmu->pmu, name, -1);
>  	if (ret) {
> diff --git a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
> index 5b2c35f1658a..68596b566344 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
> @@ -557,7 +557,7 @@ static int hisi_l3c_pmu_probe(struct platform_device *pdev)
>  	 */
>  	name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "hisi_sccl%u_l3c%u",
>  			      l3c_pmu->sccl_id, l3c_pmu->ccl_id);
> -	hisi_pmu_init(l3c_pmu, name, THIS_MODULE);
> +	hisi_pmu_init(l3c_pmu, THIS_MODULE);
>  
>  	ret = perf_pmu_register(&l3c_pmu->pmu, name, -1);
>  	if (ret) {
> diff --git a/drivers/perf/hisilicon/hisi_uncore_pa_pmu.c b/drivers/perf/hisilicon/hisi_uncore_pa_pmu.c
> index afe3419f3f6d..71b6687d6696 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_pa_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_pa_pmu.c
> @@ -412,7 +412,7 @@ static int hisi_pa_pmu_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> -	hisi_pmu_init(pa_pmu, name, THIS_MODULE);
> +	hisi_pmu_init(pa_pmu, THIS_MODULE);
>  	ret = perf_pmu_register(&pa_pmu->pmu, name, -1);
>  	if (ret) {
>  		dev_err(pa_pmu->dev, "PMU register failed, ret = %d\n", ret);
> diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.c b/drivers/perf/hisilicon/hisi_uncore_pmu.c
> index f1b0f5e1a28f..2823f381930d 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.c
> @@ -531,12 +531,10 @@ int hisi_uncore_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node)
>  }
>  EXPORT_SYMBOL_GPL(hisi_uncore_pmu_offline_cpu);
>  
> -void hisi_pmu_init(struct hisi_pmu *hisi_pmu, const char *name,
> -		   struct module *module)
> +void hisi_pmu_init(struct hisi_pmu *hisi_pmu, struct module *module)
>  {
>  	struct pmu *pmu = &hisi_pmu->pmu;
>  
> -	pmu->name               = name;
>  	pmu->module             = module;
>  	pmu->task_ctx_nr        = perf_invalid_context;
>  	pmu->event_init         = hisi_uncore_pmu_event_init;
> diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.h b/drivers/perf/hisilicon/hisi_uncore_pmu.h
> index f8e3cc6903d7..07890a8e96ca 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_pmu.h
> +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.h
> @@ -121,6 +121,5 @@ ssize_t hisi_uncore_pmu_identifier_attr_show(struct device *dev,
>  int hisi_uncore_pmu_init_irq(struct hisi_pmu *hisi_pmu,
>  			     struct platform_device *pdev);
>  
> -void hisi_pmu_init(struct hisi_pmu *hisi_pmu, const char *name,
> -		   struct module *module);
> +void hisi_pmu_init(struct hisi_pmu *hisi_pmu, struct module *module);
>  #endif /* __HISI_UNCORE_PMU_H__ */
> diff --git a/drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c b/drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c
> index 1e354433776a..6fe534a665ed 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c
> @@ -445,7 +445,7 @@ static int hisi_sllc_pmu_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> -	hisi_pmu_init(sllc_pmu, name, THIS_MODULE);
> +	hisi_pmu_init(sllc_pmu, THIS_MODULE);
>  
>  	ret = perf_pmu_register(&sllc_pmu->pmu, name, -1);
>  	if (ret) {


  reply	other threads:[~2023-04-03 11:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03  8:14 [PATCH 0/2]Fix NULL pointer and doing cleanup Junhao He
2023-04-03  8:14 ` Junhao He
2023-04-03  8:14 ` [PATCH 1/2] drivers/perf: hisi: Remove redundant initialized of pmu->name Junhao He
2023-04-03  8:14   ` Junhao He
2023-04-03 11:02   ` Jonathan Cameron [this message]
2023-04-03 11:02     ` Jonathan Cameron
2023-04-03  8:14 ` [PATCH 2/2] drivers/perf: hisi: add NULL check for name Junhao He
2023-04-03  8:14   ` Junhao He
2023-04-03 11:08   ` Jonathan Cameron
2023-04-03 11:08     ` Jonathan Cameron
2023-04-17 15:03 ` [PATCH 0/2]Fix NULL pointer and doing cleanup Will Deacon
2023-04-17 15:03   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230403120251.00003fd7@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=catalin.marinas@arm.com \
    --cc=f.fangjian@huawei.com \
    --cc=hejunhao3@huawei.com \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=prime.zeng@hisilicon.com \
    --cc=shenyang39@huawei.com \
    --cc=will@kernel.org \
    --cc=yangyicong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.